From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: bob.c.feng@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Tue, 23 Jul 2019 19:03:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jul 2019 19:03:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,300,1559545200"; d="scan'208";a="177519732" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by FMSMGA003.fm.intel.com with ESMTP; 23 Jul 2019 19:03:37 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 23 Jul 2019 19:03:37 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.232]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.60]) with mapi id 14.03.0439.000; Wed, 24 Jul 2019 10:03:35 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" , Laszlo Ersek CC: Andrew Fish , "Kinney, Michael D" , Philippe Mathieu-Daude , "Gao, Liming" , "Wu, Hao A" , Stefan Berger Subject: Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script (and Maintainers.txt format change) Thread-Topic: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script (and Maintainers.txt format change) Thread-Index: AQHVPhBz5xXv181IXkKyGWiX6JxKvKbZCzxQ Date: Wed, 24 Jul 2019 02:03:34 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160B46D94@SHSMSX105.ccr.corp.intel.com> References: <20190712170128.6495-1-leif.lindholm@linaro.org> <6799dc07-2d8c-0ad1-286e-23b2b68c413a@redhat.com> <20190719090027.GP2712@bivouac.eciton.net> In-Reply-To: <20190719090027.GP2712@bivouac.eciton.net> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch looks fine for me. Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif= Lindholm Sent: Friday, July 19, 2019 5:00 PM To: Laszlo Ersek Cc: edk2-devel-groups-io ; Andrew Fish ; Kinney, Michael D ; Philippe Mathieu-Daud= e ; Feng, Bob C ; Gao, Liming ; Wu, Hao A ; Stefan Berger Subject: Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script (= and Maintainers.txt format change) On Thu, Jul 18, 2019 at 11:17:30PM +0200, Laszlo Ersek wrote: > On 07/18/19 18:27, Leif Lindholm wrote: > > Laszlo, Hao - I have prepared a set for pushing as below. > >=20 > > (Reviewed-by: Leif Lindholm for all of=20 > > your > > patches.) > > *But*, I need a review from Bob and/or Liming before I push the final= one: > > "BaseTools: add GetMaintainer.py script" - > > https://edk2.groups.io/g/devel/message/43666 > >=20 > > I have verified reviews/acks by all affected reviewers, except for=20 > > Stefan Berger for Ovmf TCG/TPM2. >=20 > Stefan's R-b has arrived as well: >=20 > http://mid.mail-archive.com/7201b3fb-d84b-30e0-61c8-bf9bb9defa7a@linux > .ibm.com >=20 > So, I agree, those four patches regarding OvmfPkg reviewership are now= =20 > fully approved. >=20 > Please pick up Phil's feedback as well. >=20 > > While I would prefer to have that too, this is a file format shift -= =20 > > not a change in responsibility areas. > > Laszlo, do you agree? > > If so, I can push 1-7/8 as is. >=20 > See above -- then I'm OK. 1-7/8 pushed as: 3dafa0382286..296c908c6968 Will push the GetMaintainer.py script once approved by BaseTools maintaine= rs. Thanks! / Leif > Thank you! > Laszlo >=20 > >=20 > > / > > Leif > >=20 > > Hao A Wu (1): > > Maintainers.txt: Fine-grained review ownership for MdeModulePkg > >=20 > > Laszlo Ersek (4): > > Maintainers.txt: split out section "ArmVirtPkg: modules used on Xen" > > Maintainers.txt: split out section "OvmfPkg: Xen-related modules" > > Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related > > modules" > > Maintainers.txt: split out section "OvmfPkg: CSM modules" > >=20 > > Leif Lindholm (3): > > Maintainers.txt: update for filesystem area descriptions > > Maintainers.txt: add wildcard path association for Arm/AArch64 > > BaseTools: add GetMaintainer.py script > >=20 > >=20 > > On Fri, 12 Jul 2019 at 18:01, Leif Lindholm=20 > > > > wrote: > >=20 > >> Changes are available directly from: > >> > >> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=3Dupstrea > >> ming/git-maintainer-v1 > >> > >> This series adds new tags to the Maintainers.txt format, making it=20 > >> possible to describe which filesystem paths are looked after by=20 > >> which people, and hence automating the extraction of a list over=20 > >> who should be cc:d on a patch submission. > >> > >> Remaining shorcomings in v1: > >> - Will still be misparsing OvmfPkg and MdeModulePkg due to non-tag li= nes > >> interspersed with the tag lines. These lines will be removed as are= as of > >> responsibility is formally rewritten as tags. > >> - * Wildcard support is not fully filesystem compliant except in firs= t or > >> last position in the file pattern (it translates as regex .* elsewh= ere). > >> However, actual cases of mismatch are expected to be unlikely, and = they > >> will be false positives rather than false negatives - so I think th= is is > >> good enough at least for a start. > >> - Provides no information of why certain people or meiling lists were > >> picked - it just bundles all recipients up, deduplicates them, and > >> prints them out. > >> > >> Using the script requires the gitpython module to be installed. > >> > >> Worthwhile mentioning outside the ChangeLog is the added -l flag,=20 > >> which lets you look up what a given path would return in the way of m= atches. > >> E.g. "python BaseTools/Scripts/GetMaintainer.py -l Non/Existing/Path" > >> would return: > >> --- > >> Non/Existing/Path > >> "Non/Existing/Path": no maintainers found, looking for default > >> Andrew Fish > >> Laszlo Ersek > >> Leif Lindholm > >> Michael D Kinney > >> devel@edk2.groups.io > >> --- > >> > >> This series would still result in GetMaintainers.py missing some=20 > >> maintainers/reviewers due to descriptions in prose rather than=20 > >> filename patterns. My preferred way of handling this would be to=20 > >> merge 1-2/3 as soon as found acceptable, following up and merging=20 > >> patches to update ArmVirtPkg, MdeModulePkg, and OvmfPkg, and=20 > >> finally once the file is consistent, proceed to merge 3/3. > >> > >> Changelog: > >> v1: > >> - Rebase to current Maintainers.txt. > >> - Fix typos and missed bits in Maintainers.txt. > >> - Get rid of the magic '' filename, let the single-char '*' > >> wildcard resolve this (_using_ the magic '' filename in th= e > >> script, but treating it as if it was a file in the top-level direct= ory). > >> - Add -l flag to script to look up which maintainers would be returne= d for > >> a given path (which need not exist). > >> rfc: > >> - Split patches up > >> - one for new Maintainers.txt format (documentation and F: tags). > >> - one for adding a new wilcards responsibility area for */Arm, */AA= rch64 > >> - one for the GetMaintainer.py script > >> - Reworked wildcard handling based on Laszlo's explanation > >> - Trailing / covers everything under that directory > >> - Trailing * does not cover subdirectories > >> - Added support for X: tag > >> - Added support for magic '' pathname > >> - Also prints mailing list addresses for matching L: tags > >> > >> Cc: Andrew Fish > >> Cc: Laszlo Ersek > >> Cc: Michael D Kinney > >> Cc: Bob Feng > >> Cc: Liming Gao > >> Cc: Philippe Mathieu-Daude > >> Cc: "Wu, Hao A" > >> > >> Leif Lindholm (3): > >> Maintainers.txt: update for filesystem area descriptions > >> Maintainers.txt: add wildcard path association for Arm/AArch64 > >> BaseTools: add GetMaintainer.py script > >> > >> BaseTools/Scripts/GetMaintainer.py | 190 +++++++++++++++++++++++++++= ++ > >> Maintainers.txt | 54 ++++++++ > >> 2 files changed, 244 insertions(+) create mode 100644=20 > >> BaseTools/Scripts/GetMaintainer.py > >> > >> -- > >> 2.20.1 > >> > >> > >=20 >=20