From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>
Subject: Re: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives
Date: Fri, 2 Aug 2019 07:59:31 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160B51D4D@SHSMSX105.ccr.corp.intel.com> (raw)
In-Reply-To: <20190802001314.25980-1-michael.d.kinney@intel.com>
For the patch set,
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Michael D Kinney
Sent: Friday, August 2, 2019 8:13 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>
Subject: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives
https://bugzilla.tianocore.org/show_bug.cgi?id=2044
* Add '--no-textconv' to 'git show' command to disable binary->text conversion.
* Ignore blank lines in patch
* Ignore lines with 'copy from ' and 'copy to ' prefixes
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
Michael D Kinney (3):
BaseTools/PatchCheck: Ignore blank lines in diff
BaseTools/PatchCheck: Add copy from/to keywords
BaseTools/PatchCheck: Disable text conversion in 'git show'
BaseTools/Scripts/PatchCheck.py | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--
2.21.0.windows.1
next prev parent reply other threads:[~2019-08-02 7:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 0:13 [Patch 0/3] BaseTools/PatchCheck: Fix false positives Michael D Kinney
2019-08-02 0:13 ` [Patch 1/3] BaseTools/PatchCheck: Ignore blank lines in diff Michael D Kinney
2019-08-02 0:13 ` [Patch 2/3] BaseTools/PatchCheck: Add copy from/to keywords Michael D Kinney
2019-08-02 0:13 ` [Patch 3/3] BaseTools/PatchCheck: Disable text conversion in 'git show' Michael D Kinney
2019-08-02 18:29 ` Jordan Justen
2019-08-02 18:51 ` Michael D Kinney
2019-08-02 23:57 ` Laszlo Ersek
2019-08-05 22:01 ` [edk2-devel] " Michael D Kinney
2019-08-07 13:26 ` Laszlo Ersek
2019-08-07 19:42 ` Jordan Justen
2019-08-08 20:57 ` Laszlo Ersek
2019-08-08 21:08 ` Michael D Kinney
2019-08-08 21:15 ` Andrew Fish
2019-08-08 22:34 ` Laszlo Ersek
2019-08-02 7:59 ` Bob Feng [this message]
2019-08-02 18:30 ` [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives Jordan Justen
2019-08-07 11:41 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D160B51D4D@SHSMSX105.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox