From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Fri, 02 Aug 2019 00:59:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Aug 2019 00:59:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,337,1559545200"; d="scan'208";a="175512290" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 02 Aug 2019 00:59:34 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 2 Aug 2019 00:59:34 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 2 Aug 2019 00:59:33 -0700 Received: from shsmsx105.ccr.corp.intel.com ([169.254.11.15]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Fri, 2 Aug 2019 15:59:32 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Gao, Liming" , "Justen, Jordan L" Subject: Re: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives Thread-Topic: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positives Thread-Index: AQHVSMcZoZnxZ/HcrEWlQM3xfwdCOqbnfmhg Date: Fri, 2 Aug 2019 07:59:31 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D160B51D4D@SHSMSX105.ccr.corp.intel.com> References: <20190802001314.25980-1-michael.d.kinney@intel.com> In-Reply-To: <20190802001314.25980-1-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the patch set, Reviewed-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Mich= ael D Kinney Sent: Friday, August 2, 2019 8:13 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Justen, Jordan L Subject: [edk2-devel] [Patch 0/3] BaseTools/PatchCheck: Fix false positive= s https://bugzilla.tianocore.org/show_bug.cgi?id=3D2044 * Add '--no-textconv' to 'git show' command to disable binary->text conver= sion. * Ignore blank lines in patch * Ignore lines with 'copy from ' and 'copy to ' prefixes Cc: Bob Feng Cc: Liming Gao Cc: Jordan Justen Signed-off-by: Michael D Kinney Michael D Kinney (3): BaseTools/PatchCheck: Ignore blank lines in diff BaseTools/PatchCheck: Add copy from/to keywords BaseTools/PatchCheck: Disable text conversion in 'git show' BaseTools/Scripts/PatchCheck.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) --=20 2.21.0.windows.1