Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

["Bob Feng" <bob.c.feng@intel.com>]

Thanks Leif, I'll push the patches.

I file a BZ https://bugzilla.tianocore.org/show_bug.cgi?id=2072 for the --hash issue.

Thanks,
Bob

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif Lindholm
Sent: Friday, August 9, 2019 9:29 PM
To: Laszlo Ersek <lersek@redhat.com>
Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Andrew Fish <afish@apple.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] [Patch 00/10 V8] Enable multiple process AutoGen

On Fri, Aug 09, 2019 at 02:54:31PM +0200, Laszlo Ersek wrote:
> On 08/09/19 03:37, Feng, Bob C wrote:
> > Thanks for your response.
> > 
> > I'm going to push this patch set late today, if there is no more comments.
> 
> Sorry, I have to disagree about that. There is a NACK standing from 
> Leif
> -- he will have to rescind that NACK explicitly, for you to push the series.
> 
> Leif: can you please confirm, in light of the new information [*] if 
> you are OK with this v8 patchset being merged?
> 
> [*] The new information is that "--hash" breaks "pick-up" after 
> Ctrl-C, independently of the present patchset. So, it's not a 
> regression from the new work, and if "--hash" is removed from the 
> command line, the "pick-up" is successful both with and without these patches.

Ah, it was not clear to me that the bug was reproducible with --hash without this set. (I read it as the bug was only reproducible with this set if using --hash, which is not the same thing.)

In that case, I rescind my NACK.

Thank you for the clarification, Laszlo.

I would say this makes a fix for the --hash issue a hard requirement for the stable tag.

Best Regards,

Leif