From: "Bob Feng" <bob.c.feng@intel.com>
To: "Shi, Steven" <steven.shi@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Rodriguez, Christian" <christian.rodriguez@intel.com>,
"Johnson, Michael" <michael.johnson@intel.com>,
"lersek@redhat.com" <lersek@redhat.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"afish@apple.com" <afish@apple.com>,
"Cetola, Stephano" <stephano.cetola@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH v6 0/5] Build cache enhancement
Date: Fri, 16 Aug 2019 04:06:07 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D161524323@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190815142621.7644-1-steven.shi@intel.com>
For this patch set,
Reviewed-by: Bob Feng <bob.c.feng@intel.com>
-----Original Message-----
From: Shi, Steven
Sent: Thursday, August 15, 2019 10:26 PM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Rodriguez, Christian <christian.rodriguez@intel.com>; Johnson, Michael <michael.johnson@intel.com>; lersek@redhat.com; leif.lindholm@linaro.org; afish@apple.com; Cetola, Stephano <stephano.cetola@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Shi, Steven <steven.shi@intel.com>
Subject: [PATCH v6 0/5] Build cache enhancement
From: "Shi, Steven" <steven.shi@intel.com>
This patch set is for the 201908 stable tag
Enhance the edk2 build cache with below patches:
Patch 01/05: Improve the cache hit rate through new cache checkpoint and hash algorithm Patch 02/05: Print more info to explain why a module build cache miss Patch 03/05: Fix the unsafe [self.Arch][self.Name] key usage in build cache Patch 04/05 Add the GenFds multi-thread support in build cache Patch 05/05 Improve the file saving and copying functions reliability in build cache
You can directly try this patch set in the branch:
https://github.com/shijunjing/edk2/tree/build_cache_improve_v6_3
V6:
In the patch 5, add error handling to skip hash calculation if find module cache already crashed
V5:
Fix the method name typo in Misc.py from EdkLogger.quite() to EdkLogger.quiet()
V4:
Change single global lock into two locks, which are cache_lock and file_lock, for better cache performance and IO reliability in windows
V3:
Add patch 5. To improve the autogen CopyFileOnChange() and SaveFileOnChange() functions reliability for build cache
V2:
Enhance the SaveHashChainFileToCache() function in ModuleAutoGen.py and not need to call f.close() in the "with open(xxx) as f:" block. The with block will close the file automatically
V1:
Initial patch set
Shi, Steven (5):
BaseTools: Improve the cache hit in the edk2 build cache
BaseTools: Print first cache missing file for build cachle
BaseTools: Change the [Arch][Name] module key in Build cache
BaseTools: Add GenFds multi-thread support in build cache
BaseTools: Improve the file saving and copying reliability
.../Source/Python/AutoGen/AutoGenWorker.py | 27 +-
BaseTools/Source/Python/AutoGen/CacheIR.py | 29 +
BaseTools/Source/Python/AutoGen/DataPipe.py | 6 +
BaseTools/Source/Python/AutoGen/GenC.py | 0
BaseTools/Source/Python/AutoGen/GenMake.py | 233 +++---
.../Source/Python/AutoGen/ModuleAutoGen.py | 791 ++++++++++++++++--
BaseTools/Source/Python/Common/GlobalData.py | 11 +
BaseTools/Source/Python/Common/Misc.py | 44 +-
BaseTools/Source/Python/build/build.py | 182 ++--
9 files changed, 1073 insertions(+), 250 deletions(-) mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/AutoGenWorker.py
create mode 100755 BaseTools/Source/Python/AutoGen/CacheIR.py
mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/DataPipe.py
mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/GenC.py
mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/GenMake.py
mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
mode change 100644 => 100755 BaseTools/Source/Python/Common/GlobalData.py
mode change 100644 => 100755 BaseTools/Source/Python/Common/Misc.py
mode change 100644 => 100755 BaseTools/Source/Python/build/build.py
--
2.17.1
next prev parent reply other threads:[~2019-08-16 4:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 14:26 [PATCH v6 0/5] Build cache enhancement Steven Shi
2019-08-15 14:26 ` [PATCH v6 1/5] BaseTools: Improve the cache hit in the edk2 build cache Steven Shi
2019-08-15 14:26 ` [PATCH v6 2/5] BaseTools: Print first cache missing file for build cachle Steven Shi
2019-08-15 14:26 ` [PATCH v6 3/5] BaseTools: Change the [Arch][Name] module key in Build cache Steven Shi
2019-08-15 14:26 ` [PATCH v6 4/5] BaseTools: Add GenFds multi-thread support in build cache Steven Shi
2019-08-15 14:26 ` [PATCH v6 5/5] BaseTools: Improve the file saving and copying reliability Steven Shi
2019-08-16 4:06 ` Bob Feng [this message]
[not found] ` <15BB4B8EC4DF18D7.23161@groups.io>
2019-08-20 6:12 ` [edk2-devel] [PATCH v6 0/5] Build cache enhancement Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D161524323@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox