From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: bob.c.feng@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 15 Aug 2019 21:06:11 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2019 21:06:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; d="scan'208";a="188699255" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 15 Aug 2019 21:06:11 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 21:06:10 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 21:06:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.80]) with mapi id 14.03.0439.000; Fri, 16 Aug 2019 12:06:07 +0800 From: "Bob Feng" To: "Shi, Steven" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Rodriguez, Christian" , "Johnson, Michael" , "lersek@redhat.com" , "leif.lindholm@linaro.org" , "afish@apple.com" , "Cetola, Stephano" , "Kinney, Michael D" Subject: Re: [PATCH v6 0/5] Build cache enhancement Thread-Topic: [PATCH v6 0/5] Build cache enhancement Thread-Index: AQHVU3V3D9G5O+hvo0SxajU16Dkza6b9KLhA Date: Fri, 16 Aug 2019 04:06:07 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D161524323@SHSMSX104.ccr.corp.intel.com> References: <20190815142621.7644-1-steven.shi@intel.com> In-Reply-To: <20190815142621.7644-1-steven.shi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For this patch set, Reviewed-by: Bob Feng -----Original Message----- From: Shi, Steven=20 Sent: Thursday, August 15, 2019 10:26 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ;= Rodriguez, Christian ; Johnson, Michael ; lersek@redhat.com; leif.lindholm@linaro.org; afis= h@apple.com; Cetola, Stephano ; Kinney, Michael = D ; Shi, Steven Subject: [PATCH v6 0/5] Build cache enhancement From: "Shi, Steven" This patch set is for the 201908 stable tag Enhance the edk2 build cache with below patches: Patch 01/05: Improve the cache hit rate through new cache checkpoint and ha= sh algorithm Patch 02/05: Print more info to explain why a module build cac= he miss Patch 03/05: Fix the unsafe [self.Arch][self.Name] key usage in bui= ld cache Patch 04/05 Add the GenFds multi-thread support in build cache Pa= tch 05/05 Improve the file saving and copying functions reliability in bui= ld cache You can directly try this patch set in the branch: https://github.com/shijunjing/edk2/tree/build_cache_improve_v6_3 V6: In the patch 5, add error handling to skip hash calculation if find module = cache already crashed V5: Fix the method name typo in Misc.py from EdkLogger.quite() to EdkLogger.qui= et() V4: Change single global lock into two locks, which are cache_lock and file_loc= k, for better cache performance and IO reliability in windows V3: Add patch 5. To improve the autogen CopyFileOnChange() and SaveFileOnChange= () functions reliability for build cache V2: Enhance the SaveHashChainFileToCache() function in ModuleAutoGen.py and not= need to call f.close() in the "with open(xxx) as f:" block. The with block= will close the file automatically V1: Initial patch set Shi, Steven (5): BaseTools: Improve the cache hit in the edk2 build cache BaseTools: Print first cache missing file for build cachle BaseTools: Change the [Arch][Name] module key in Build cache BaseTools: Add GenFds multi-thread support in build cache BaseTools: Improve the file saving and copying reliability .../Source/Python/AutoGen/AutoGenWorker.py | 27 +- BaseTools/Source/Python/AutoGen/CacheIR.py | 29 + BaseTools/Source/Python/AutoGen/DataPipe.py | 6 + BaseTools/Source/Python/AutoGen/GenC.py | 0 BaseTools/Source/Python/AutoGen/GenMake.py | 233 +++--- .../Source/Python/AutoGen/ModuleAutoGen.py | 791 ++++++++++++++++-- BaseTools/Source/Python/Common/GlobalData.py | 11 + BaseTools/Source/Python/Common/Misc.py | 44 +- BaseTools/Source/Python/build/build.py | 182 ++-- 9 files changed, 1073 insertions(+), 250 deletions(-) mode change 100644 = =3D> 100755 BaseTools/Source/Python/AutoGen/AutoGenWorker.py create mode 100755 BaseTools/Source/Python/AutoGen/CacheIR.py mode change 100644 =3D> 100755 BaseTools/Source/Python/AutoGen/DataPipe.py mode change 100644 =3D> 100755 BaseTools/Source/Python/AutoGen/GenC.py mode change 100644 =3D> 100755 BaseTools/Source/Python/AutoGen/GenMake.py mode change 100644 =3D> 100755 BaseTools/Source/Python/AutoGen/ModuleAutoG= en.py mode change 100644 =3D> 100755 BaseTools/Source/Python/Common/GlobalData.p= y mode change 100644 =3D> 100755 BaseTools/Source/Python/Common/Misc.py mode change 100644 =3D> 100755 BaseTools/Source/Python/build/build.py -- 2.17.1