From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: bob.c.feng@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Mon, 19 Aug 2019 23:12:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 23:12:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,407,1559545200"; d="scan'208";a="189761336" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 19 Aug 2019 23:12:47 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 19 Aug 2019 23:12:46 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 19 Aug 2019 23:12:46 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000; Tue, 20 Aug 2019 14:12:43 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "Feng, Bob C" , "Shi, Steven" CC: "Gao, Liming" , "Rodriguez, Christian" , "Johnson, Michael" , "lersek@redhat.com" , "leif.lindholm@linaro.org" , "afish@apple.com" , "Cetola, Stephano" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v6 0/5] Build cache enhancement Thread-Topic: [edk2-devel] [PATCH v6 0/5] Build cache enhancement Thread-Index: AQHVU3V3D9G5O+hvo0SxajU16Dkza6b9KLhAgAZr/SA= Date: Tue, 20 Aug 2019 06:12:43 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D161526293@SHSMSX104.ccr.corp.intel.com> References: <20190815142621.7644-1-steven.shi@intel.com> <15BB4B8EC4DF18D7.23161@groups.io> In-Reply-To: <15BB4B8EC4DF18D7.23161@groups.io> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed at 0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4 ... 94459080c118049ab= a927ec0444ba5b750b7d2c9=20 Thanks, Bob -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob = Feng Sent: Friday, August 16, 2019 12:06 PM To: Shi, Steven ; devel@edk2.groups.io Cc: Gao, Liming ; Rodriguez, Christian ; Johnson, Michael ; lersek@re= dhat.com; leif.lindholm@linaro.org; afish@apple.com; Cetola, Stephano ; Kinney, Michael D Subject: Re: [edk2-devel] [PATCH v6 0/5] Build cache enhancement For this patch set, Reviewed-by: Bob Feng -----Original Message----- From: Shi, Steven=20 Sent: Thursday, August 15, 2019 10:26 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C = ; Rodriguez, Christian ; Johnson, Michael ; lersek@redhat.com; leif.lindholm@linaro.org; afi= sh@apple.com; Cetola, Stephano ; Kinney, Michael= D ; Shi, Steven Subject: [PATCH v6 0/5] Build cache enhancement From: "Shi, Steven" This patch set is for the 201908 stable tag Enhance the edk2 build cache with below patches: Patch 01/05: Improve the cache hit rate through new cache checkpoint and h= ash algorithm Patch 02/05: Print more info to explain why a module build ca= che miss Patch 03/05: Fix the unsafe [self.Arch][self.Name] key usage in bu= ild cache Patch 04/05 Add the GenFds multi-thread support in build cache P= atch 05/05 Improve the file saving and copying functions reliability in bu= ild cache You can directly try this patch set in the branch: https://github.com/shijunjing/edk2/tree/build_cache_improve_v6_3 V6: In the patch 5, add error handling to skip hash calculation if find module= cache already crashed V5: Fix the method name typo in Misc.py from EdkLogger.quite() to EdkLogger.qu= iet() V4: Change single global lock into two locks, which are cache_lock and file_lo= ck, for better cache performance and IO reliability in windows V3: Add patch 5. To improve the autogen CopyFileOnChange() and SaveFileOnChang= e() functions reliability for build cache V2: Enhance the SaveHashChainFileToCache() function in ModuleAutoGen.py and no= t need to call f.close() in the "with open(xxx) as f:" block. The with bloc= k will close the file automatically V1: Initial patch set Shi, Steven (5): BaseTools: Improve the cache hit in the edk2 build cache BaseTools: Print first cache missing file for build cachle BaseTools: Change the [Arch][Name] module key in Build cache BaseTools: Add GenFds multi-thread support in build cache BaseTools: Improve the file saving and copying reliability .../Source/Python/AutoGen/AutoGenWorker.py | 27 +- BaseTools/Source/Python/AutoGen/CacheIR.py | 29 + BaseTools/Source/Python/AutoGen/DataPipe.py | 6 + BaseTools/Source/Python/AutoGen/GenC.py | 0 BaseTools/Source/Python/AutoGen/GenMake.py | 233 +++--- .../Source/Python/AutoGen/ModuleAutoGen.py | 791 ++++++++++++++++-- BaseTools/Source/Python/Common/GlobalData.py | 11 + BaseTools/Source/Python/Common/Misc.py | 44 +- BaseTools/Source/Python/build/build.py | 182 ++-- 9 files changed, 1073 insertions(+), 250 deletions(-) mode change 100644= =3D> 100755 BaseTools/Source/Python/AutoGen/AutoGenWorker.py create mode 100755 BaseTools/Source/Python/AutoGen/CacheIR.py mode change 100644 =3D> 100755 BaseTools/Source/Python/AutoGen/DataPipe.p= y mode change 100644 =3D> 100755 BaseTools/Source/Python/AutoGen/GenC.py mode change 100644 =3D> 100755 BaseTools/Source/Python/AutoGen/GenMake.py mode change 100644 =3D> 100755 BaseTools/Source/Python/AutoGen/ModuleAuto= Gen.py mode change 100644 =3D> 100755 BaseTools/Source/Python/Common/GlobalData.= py mode change 100644 =3D> 100755 BaseTools/Source/Python/Common/Misc.py mode change 100644 =3D> 100755 BaseTools/Source/Python/build/build.py -- 2.17.1