From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: bob.c.feng@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Mon, 19 Aug 2019 23:27:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 23:27:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,407,1559545200"; d="scan'208";a="179645337" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 19 Aug 2019 23:27:52 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 19 Aug 2019 23:27:52 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.112]) by shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000; Tue, 20 Aug 2019 14:27:50 +0800 From: "Bob Feng" To: "Gao, Liming" , "Fan, ZhijuX" , "devel@edk2.groups.io" Subject: Re: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile' Thread-Topic: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect variable name 'DataPile' Thread-Index: AdVW8Qlu7Qf20n4OR3yB8fyqgqcuCQACoxIAAAkRjOAAAB+j0A== Date: Tue, 20 Aug 2019 06:27:50 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D1615262E2@SHSMSX104.ccr.corp.intel.com> References: <08650203BA1BD64D8AD9B6D5D74A85D161525DD1@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D6C1C@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D6C1C@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed at 0970a80583a9a0595eb357f380e604b57136fa26 Thanks, Bob -----Original Message----- From: Gao, Liming=20 Sent: Tuesday, August 20, 2019 2:24 PM To: Feng, Bob C ; Fan, ZhijuX ;= devel@edk2.groups.io Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect var= iable name 'DataPile' Reviewed-by: Liming Gao >-----Original Message----- >From: Feng, Bob C >Sent: Tuesday, August 20, 2019 10:05 AM >To: Fan, ZhijuX ; devel@edk2.groups.io >Cc: Gao, Liming >Subject: RE: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect=20 >variable name 'DataPile' > >Reviewed-by: Bob Feng > >-----Original Message----- >From: Fan, ZhijuX >Sent: Tuesday, August 20, 2019 8:49 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C=20 > >Subject: [PATCH V3] [edk2-stable201908] BaseTools: Update incorrect=20 >variable name 'DataPile' > >BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2093 > >The PlatformAutoGen object has a DataPipe property but no DataPile=20 >property So change the variable name 'DataPile' to 'DataPipe' in=20 >BuildReport.py > >This patch is going to fix that issue. > >Cc: Liming Gao >Cc: Bob Feng >Signed-off-by: Zhiju.Fan >--- > BaseTools/Source/Python/build/BuildReport.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/BaseTools/Source/Python/build/BuildReport.py >b/BaseTools/Source/Python/build/BuildReport.py >index 9c12c01d2a..6b26f1c3b0 100644 >--- a/BaseTools/Source/Python/build/BuildReport.py >+++ b/BaseTools/Source/Python/build/BuildReport.py >@@ -2142,7 +2142,7 @@ class PlatformReport(object): > INFList =3D GlobalData.gFdfParser.Profile.InfDict= [Pa.Arch] > for InfName in INFList: > InfClass =3D PathClass(NormPath(InfName),=20 >Wa.WorkspaceDir, >Pa.Arch) >- Ma =3D ModuleAutoGen(Wa, InfClass, Pa.BuildTa= rget, >Pa.ToolChain, Pa.Arch, Wa.MetaFile,Pa.DataPile) >+ Ma =3D ModuleAutoGen(Wa, InfClass,=20 >+ Pa.BuildTarget, Pa.ToolChain, Pa.Arch, Wa.MetaFile, Pa.DataPipe) > if Ma is None: > continue > if Ma not in ModuleAutoGenList: >-- >2.14.1.windows.1