From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web12.794.1571621011379744555 for ; Sun, 20 Oct 2019 18:23:31 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2019 18:23:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,321,1566889200"; d="scan'208";a="348606596" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 20 Oct 2019 18:23:30 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 18:23:30 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 20 Oct 2019 18:23:29 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.166]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.96]) with mapi id 14.03.0439.000; Mon, 21 Oct 2019 09:23:28 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "vit9696@protonmail.com" Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3 Thread-Topic: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3 Thread-Index: AQHVhzDam4q55rLzcU6Gcgj64hTmg6dkTZuQ Date: Mon, 21 Oct 2019 01:23:27 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16154E781@SHSMSX104.ccr.corp.intel.com> References: <20191020102615.41961-1-vit9696@protonmail.com> <20191020102615.41961-2-vit9696@protonmail.com> In-Reply-To: <20191020102615.41961-2-vit9696@protonmail.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Bob Feng -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vital= y Cheptsov via Groups.Io Sent: Sunday, October 20, 2019 6:26 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaulte= ncoding with python 3 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2301 This interface was a originally a no-op in python 3, and now is fully remov= ed causing a build warning on macOS (Darwin). Signed-off-by: Vitaly Cheptsov > --- BaseTools/Source/Python/sitecustomize.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/sitecustomize.py b/BaseTools/Source/Py= thon/sitecustomize.py index 7dbbf8a232..50783e1b3a 100644 --- a/BaseTools/Source/Python/sitecustomize.py +++ b/BaseTools/Source/Python/sitecustomize.py @@ -7,7 +7,7 @@ import sys import locale =20 -if sys.platform =3D=3D "darwin": +if sys.platform =3D=3D "darwin" and sys.version_info[0] < 3: DefaultLocal =3D locale.getdefaultlocale()[1] if DefaultLocal is None: DefaultLocal =3D 'UTF8' -- 2.21.0 (Apple Git-122) -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#49253): https://edk2.groups.io/g/devel/message/49253 Mute This Topic: https://groups.io/mt/35942396/1768742 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.feng@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D