From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"vit9696@protonmail.com" <vit9696@protonmail.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3
Date: Wed, 23 Oct 2019 08:57:33 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D161550850@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191020102615.41961-2-vit9696@protonmail.com>
Pushed at 5c7006c9de4029afc508e2c43d78de12a0d19cfe
-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptsov via Groups.Io
Sent: Sunday, October 20, 2019 6:26 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2301
This interface was a originally a no-op in python 3, and now is fully removed causing a build warning on macOS (Darwin).
Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>>
---
BaseTools/Source/Python/sitecustomize.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Source/Python/sitecustomize.py b/BaseTools/Source/Python/sitecustomize.py
index 7dbbf8a232..50783e1b3a 100644
--- a/BaseTools/Source/Python/sitecustomize.py
+++ b/BaseTools/Source/Python/sitecustomize.py
@@ -7,7 +7,7 @@
import sys
import locale
-if sys.platform == "darwin":
+if sys.platform == "darwin" and sys.version_info[0] < 3:
DefaultLocal = locale.getdefaultlocale()[1]
if DefaultLocal is None:
DefaultLocal = 'UTF8'
--
2.21.0 (Apple Git-122)
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#49253): https://edk2.groups.io/g/devel/message/49253
Mute This Topic: https://groups.io/mt/35942396/1768742
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [bob.c.feng@intel.com]
-=-=-=-=-=-=
prev parent reply other threads:[~2019-10-23 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 10:26 [PATCH v1 0/1] Do not call sys.setdefaultencoding with python 3 Vitaly Cheptsov
2019-10-20 10:26 ` [PATCH v1 1/1] BaseTools: " Vitaly Cheptsov
2019-10-21 1:23 ` [edk2-devel] " Bob Feng
2019-10-23 8:57 ` Bob Feng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D161550850@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox