From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.8153.1573541549562393775 for ; Mon, 11 Nov 2019 22:52:29 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 22:52:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,295,1569308400"; d="scan'208";a="202607649" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga007.fm.intel.com with ESMTP; 11 Nov 2019 22:52:27 -0800 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 22:52:27 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 11 Nov 2019 22:52:26 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.248]) with mapi id 14.03.0439.000; Tue, 12 Nov 2019 14:52:25 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "Ni, Ray" CC: "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix build failure when using python38 Thread-Topic: [edk2-devel] [PATCH] BaseTools: Fix build failure when using python38 Thread-Index: AQHVmSEPdwd4Z9rNQk64ZJJ4SVWpuaeHGRIQ Date: Tue, 12 Nov 2019 06:52:24 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D161563082@SHSMSX104.ccr.corp.intel.com> References: <20191112061736.278692-1-ray.ni@intel.com> In-Reply-To: <20191112061736.278692-1-ray.ni@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This patch looks good. Reviewed-by: Bob C Feng -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, = Ray Sent: Tuesday, November 12, 2019 2:18 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [PATCH] BaseTools: Fix build failure when using pyth= on38 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2304 Signed-off-by: Ray Ni Cc: Bob C Feng Cc: Liming Gao --- BaseTools/Source/Python/build/build.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyt= hon/build/build.py index bcd832c525..6c8798ef93 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -2064,7 +2064,7 @@ class Build(): if Fdf.CurrentFdName and Fdf.CurrentFdName in Fdf.Profile.FdD= ict: FdDict =3D Fdf.Profile.FdDict[Fdf.CurrentFdName] for FdRegion in FdDict.RegionList: - if str(FdRegion.RegionType) is 'FILE' and self.Platfo= rm.VpdToolGuid in str(FdRegion.RegionDataList): + if str(FdRegion.RegionType) =3D=3D 'FILE' and self.Pl= atform.VpdToolGuid in str(FdRegion.RegionDataList): if int(FdRegion.Offset) % 8 !=3D 0: EdkLogger.error("build", FORMAT_INVALID, 'The= VPD Base Address %s must be 8-byte aligned.' % (FdRegion.Offset)) Wa.FdfProfile =3D Fdf.Profile --=20 2.21.0.windows.1