From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.20539.1574319906206266851 for ; Wed, 20 Nov 2019 23:05:06 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 23:05:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="259283723" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 20 Nov 2019 23:05:05 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 23:05:04 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 23:05:05 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 15:05:03 +0800 From: "Bob Feng" To: "Fan, ZhijuX" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [PATCH V2] BaseTools:fix regression issue for platform .map file Thread-Topic: [PATCH V2] BaseTools:fix regression issue for platform .map file Thread-Index: AdWgDwqWVsACakGySBmsVVoma+CTdwAKuOTg Date: Thu, 21 Nov 2019 07:05:02 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D161569419@SHSMSX104.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Bob Feng -----Original Message----- From: Fan, ZhijuX=20 Sent: Thursday, November 21, 2019 9:58 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V2] BaseTools:fix regression issue for platform .map file BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2363 The line of IMAGE=3D*** is missing in platform .map file.For example, in Ov= mf.map, there is no line of (IMAGE=3D ) under each of modules item. This is a regression issue. this patch is going to fix this issue Cc: Liming Gao Cc: Bob Feng Signed-off-by: Zhiju.Fan --- BaseTools/Source/Python/build/build.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Pyth= on/build/build.py index bcd832c525..07f1f21b5d 100755 --- a/BaseTools/Source/Python/build/build.py +++ b/BaseTools/Source/Python/build/build.py @@ -2267,6 +2267,10 @@ class Build(): self.CreateAsBuiltInf() if GlobalData.gBinCacheDest: self.UpdateBuildCache() + # + # Get Module List + # + ModuleList =3D {ma.Guid.upper(): ma for ma in=20 + self.BuildModules} self.BuildModules =3D [] self.MakeTime +=3D int(round((time.time() - MakeContiue))) # @@ -2285,10 +2289,6 @@ class Build(): # if (Arch =3D=3D 'IA32' or Arch =3D=3D 'ARM') and s= elf.LoadFixAddress !=3D 0xFFFFFFFFFFFFFFFF and self.LoadFixAddress >=3D 0x1= 00000000: EdkLogger.error("build", PARAMETER_INVALID, "F= IX_LOAD_TOP_MEMORY_ADDRESS can't be set to larger than or equal to 4G for t= he platorm with IA32 or ARM arch modules") - # - # Get Module List - # - ModuleList =3D {ma.Guid.upper():ma for ma in self.Buil= dModules} =20 # # Rebase module to the preferred memory address before= GenFds -- 2.14.1.windows.1