From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.4839.1574645870803073001 for ; Sun, 24 Nov 2019 17:37:51 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Nov 2019 17:37:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,239,1571727600"; d="scan'208";a="409458818" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 24 Nov 2019 17:37:49 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 24 Nov 2019 17:37:49 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 24 Nov 2019 17:37:49 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 24 Nov 2019 17:37:48 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Mon, 25 Nov 2019 09:37:47 +0800 From: "Bob Feng" To: Laszlo Ersek , "devel@edk2.groups.io" , "Fan, ZhijuX" CC: "Gao, Liming" , Leif Lindholm Subject: Re: [edk2-devel] [PATCH] BaseTools:fixed Build failed issue for Non-English OS Thread-Topic: [edk2-devel] [PATCH] BaseTools:fixed Build failed issue for Non-English OS Thread-Index: AdWflXp7a1q+YtFnRyKhCaD7MOH1+QAvAbYAAB+J4IAAEHOKAACHft5g Date: Mon, 25 Nov 2019 01:37:47 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16156B346@SHSMSX104.ccr.corp.intel.com> References: <95a79c71-2eb4-af97-a738-170a2668599d@redhat.com> <08650203BA1BD64D8AD9B6D5D74A85D16156A292@SHSMSX104.ccr.corp.intel.com> <58388e00-7bcd-7a58-cc74-6a32d5e9589c@redhat.com> In-Reply-To: <58388e00-7bcd-7a58-cc74-6a32d5e9589c@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Laszlo, ExecuteCommand() name is so generic but this function is only used for Stru= cture PCD. We may change that function name to eliminate the confusion. Thanks, Bob -----Original Message----- From: Laszlo Ersek [mailto:lersek@redhat.com]=20 Sent: Saturday, November 23, 2019 12:47 AM To: Feng, Bob C ; devel@edk2.groups.io; Fan, ZhijuX <= zhijux.fan@intel.com> Cc: Gao, Liming ; Leif Lindholm Subject: Re: [edk2-devel] [PATCH] BaseTools:fixed Build failed issue for No= n-English OS Hi Bob, On 11/22/19 07:39, Feng, Bob C wrote: > [Bob] The build failure was found on a platform which uses Structure Pcds= in dsc and the build machine is a Win10 with Korean language. > The present patch descripts the build failure case. > [Bob] I agree. "Non-English OS" is not precise. For this case, the build = failure is because the visual studio c compiler output message includes loc= alized string.=20 > [Bob] I think for this case build tool does not need to handle the non-as= cii characters so 'Ignore' will be enough. > [Bob] I agree to mention the present patch is to revert part of commit 8d= dec24dea74, drop "non-English OS" language, but keep "structure PCD". thanks for following up. I'm happy if you agree to mention commit 8ddec24dea74. Furthermore, I understand that Visual Studio can print localized strings. B= ut, there are two things that remain unclear: - Why are such messages tied to structure PCDs? Can Visual Studio *not* pri= nt the same kind of localized message in other cases? Like, what if you hav= e a (VOID*) PCD and assign an L"..." string to it, in the platform DSC? I mean I always encourage patch authors to include as many details about th= e failure scenario in the commit message as they feel comfortable about. Bu= t the current commit message suggests the issue is specific to structure PC= Ds *only*. That's the confusing part. - You mention "I think for this case build tool does not need to handle the= non-ascii characters so 'Ignore' will be enough." -- Sure, I guess for thi= s particular case, "Ignore" could be OK -- but the method that's being modi= fied bears the generic name "ExecuteCommand". What *else* is ExecuteCommand() used for? I'm not convinced that ignoring d= ecoding errors in the standard output / standard error of the subprocess is= acceptable in *all* cases. If there is no other use case for ExecuteCommand()'s standard output / stan= dard error than to print them to the edk2 build log, then I agree "ignore" = is tolerable. But I don't know if that's the only use case. If it is, it sh= ould be stated in the commit message. Thanks Laszlo