From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web09.761.1574667394608194411 for ; Sun, 24 Nov 2019 23:36:34 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Nov 2019 23:36:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,240,1571727600"; d="scan'208";a="198371318" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 24 Nov 2019 23:36:24 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 24 Nov 2019 23:36:23 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 24 Nov 2019 23:36:23 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.60]) with mapi id 14.03.0439.000; Mon, 25 Nov 2019 15:36:21 +0800 From: "Bob Feng" To: "devel@edk2.groups.io" , "lersek@redhat.com" , Leif Lindholm , "Gao, Liming" CC: "Kinney, Michael D" , "'afish@apple.com'" Subject: Re: [edk2-devel] Patch List for 201911 stable tag Thread-Topic: [edk2-devel] Patch List for 201911 stable tag Thread-Index: AdWes9zSqCOwyMXRRDqc08vU3NDaogACuPOAAAJ/j4AAOk7T0AAiFtWg//+0q4CAAHINgP/51oow Date: Mon, 25 Nov 2019 07:36:20 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16156B69D@SHSMSX104.ccr.corp.intel.com> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5437BA@SHSMSX104.ccr.corp.intel.com> <48a7f95e-1028-ea52-9980-da7af871cef2@redhat.com> <20191119190151.GE7323@bivouac.eciton.net> <15D8E68889A9A669.17632@groups.io> <4A89E2EF3DFEDB4C8BFDE51014F606A14E545983@SHSMSX104.ccr.corp.intel.com> <20191121103751.GL7323@bivouac.eciton.net> <93fe2f86-a235-3254-37ed-eb033a7ffba8@redhat.com> In-Reply-To: <93fe2f86-a235-3254-37ed-eb033a7ffba8@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Patch "fix regression issue for platform .map file" was pushed. More comments inline. Thanks, Bob -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Lasz= lo Ersek Sent: Friday, November 22, 2019 1:26 AM To: Leif Lindholm ; Gao, Liming Cc: devel@edk2.groups.io; Kinney, Michael D ; = 'afish@apple.com' Subject: Re: [edk2-devel] Patch List for 201911 stable tag On 11/21/19 11:37, Leif Lindholm wrote: > On Thu, Nov 21, 2019 at 08:57:12AM +0000, Gao, Liming wrote: >> Hi Stewards and all: >> New bugs are for 201911 stable tag. Can you give the comments for the= m? >> >> Bug List (those all have pass code review): >> https://edk2.groups.io/g/devel/message/50931 [PATCH] MdeModulePkg:=20 >> LzmaCustomDecompressLib.inf don't support EBC anymore >=20 > This can wait until after the stable tag *unless* that causes serious=20 > issues for CI. (And I don't consider non-zero build failures for EBC=20 > to be serious.) The fix only addresses building the component=20 > standalone as part of MdeModulePkg, so it affects no real platforms. I would have beem more permissive with this patch, but I'm OK with the abo= ve resolution too. >=20 > I have some comments with regards to the implementation as well, but=20 > I'll give those on the actual patch email. >=20 >> https://edk2.groups.io/g/devel/message/50990 [PATCH V1 1/1]=20 >> MdeModulePkg/Variable: Initialize local variable >=20 > Those two bugs are poster children for why long functions should be=20 > avoided. >=20 > OK for me to include in stable tag. Agreed. >=20 >> https://edk2.groups.io/g/devel/message/50989 [PATCH V2] BaseTools:fix= =20 >> regression issue for platform .map file >=20 > OK for me to include *if* the commit message (and bugzilla) are=20 > updated to clarify the issue. "is missing" is passive language, and=20 > hence fails to convey what is causing the problem. Does this mean that= =20 > the 'build' command fails to generate these lines? >=20 > Also, a comment on why this change (of moving this hunk 18 lines up)=20 > resolves the issue should be included. Agreed; please add a reminder to the commit message (even on push) about w= hat the specific (missing) lines in the map files are good for in the first= place. [Bob] The commit message was updated https://edk2.groups.io/g/devel/messag= e/51212 And the patch was pushed. >=20 >> https://edk2.groups.io/g/devel/message/50936 [PATCH] BaseTools:fixed=20 >> Build failed issue for Non-English OS >=20 > I agree that a fix for this bug must be included in the stable tag. > But both the BZ and the commit message need improving. > And seeing a fix that consists solely of adding "errors=3D'ignore'" > worries me somewhat. >=20 > Please explain *what* goes wrong when using Non-English OS (and which=20 > OS), as well as why "errors=3D'ignore'" does not cause further problems. I think this patch is plain wrong. I'll comment on it in its own thread. Thanks Laszlo