public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"jerecox@microsoft.com" <jerecox@microsoft.com>
Subject: Re: [edk2-devel] Seeking feedback: example of building OvmfPkg with Pytools
Date: Fri, 29 Nov 2019 02:50:36 +0000	[thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D16156DED1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <bb95f8fd-3ecb-a948-d558-c6d899422fe8@redhat.com>

Hi Jeremiah,

I have some questions for this change.
1. Will there be a PlatformBuild.py in any platform as your design? For example there will be a PlatformBuild.py in MdeModulePkg, EmulatorPkg and etc. And this PlatformBuild.py can be seen as a template?
2. The original build options can be set either from PlatformBuild.py CommonPlatform class or set from command line, is it right?
3. There is another build scripts edk2-platforms\Platform\Intel\build_bios.py for build Min-Platforms. Can PlatformBuild.py work together with it? 
4. Dose the pytools support clang on windows?
5. I tried this patch on my local machines, but build failed with pytools and your change. 
1) One windows machine only installed VS2015,  vswhere can't detect VS2015.
2) Another windows machine installed VS2015 and VS2017, vswhere can find VS2017, but build failed with the messages
    build.py...
INFO -  : error 7000: Failed to execute command
INFO -  Vc\bin\nmake.exe

3) I have a Ubuntu 18.04 machine, build failed at the step of "stuart_update -c OvmfPkg/PlatformBuild.py" with the error messages:
    File "/home/bobfeng/PythonVenv1/lib/python3.6/site-packages/edk2toolext/environment/extdeptypes/nuget_dependency.py", line 180, in fetch
    if self._fetch_from_cache(package_name):
  File "/home/bobfeng/PythonVenv1/lib/python3.6/site-packages/edk2toolext/environment/extdeptypes/nuget_dependency.py", line 113, in _fetch_from_cache
    if not os.path.isdir(NugetDependency.global_cache_path):
  File "/usr/lib/python3.6/genericpath.py", line 42, in isdir
    st = os.stat(s)

Thanks,
Bob

-----Original Message-----
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek
Sent: Wednesday, November 27, 2019 5:29 PM
To: devel@edk2.groups.io; jerecox@microsoft.com
Subject: Re: [edk2-devel] Seeking feedback: example of building OvmfPkg with Pytools

Hi Jeremiah,

On 11/27/19 01:03, Jeremiah Cox via Groups.Io wrote:
> All,
> I created an example of how to build OvmfPkg using the Pytools build environment ( https://github.com/tianocore/edk2-pytool-extensions ).
> It is available for your feedback on GitHub:
> https://github.com/out0xb2/edk2/pull/3/files
> 
> Looking for your thoughts on integrating this example into EDK2.

This patch set seems to target the edk2 repository, and at least in part OvmfPkg. Please submit the patch set to the list for review.

Thanks
Laszlo





  reply	other threads:[~2019-11-29  2:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  0:03 Seeking feedback: example of building OvmfPkg with Pytools Jeremiah Cox
2019-11-27  9:28 ` [edk2-devel] " Laszlo Ersek
2019-11-29  2:50   ` Bob Feng [this message]
2019-12-03  0:40     ` [EXTERNAL] " Jeremiah Cox
     [not found]       ` <MN2PR21MB12620D584417FD5F98564AE6D1420@MN2PR21MB1262.namprd21.prod.outlook.com>
2019-12-03  7:47         ` Bob Feng
     [not found]           ` <MN2PR21MB12622D6027E9F93768FA4D79D1420@MN2PR21MB1262.namprd21.prod.outlook.com>
2019-12-03 17:51             ` Jeremiah Cox
     [not found]               ` <MN2PR21MB12622C51F53677E34B8C214AD1420@MN2PR21MB1262.namprd21.prod.outlook.com>
2019-12-03 18:11                 ` Sean
2019-12-06  2:35                   ` Bob Feng
2019-12-06  4:39                     ` [edk2-devel] " Sean
2019-12-06  6:51                       ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D16156DED1@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox