public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"pierre.gondois@arm.com" <pierre.gondois@arm.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files
Date: Thu, 12 Dec 2019 09:14:17 +0000	[thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D161580924@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <18317.1576063428046438569@groups.io>

[-- Attachment #1: Type: text/plain, Size: 2690 bytes --]

Hi Pierre,

Currently, I don’t have good solution for this issue. I considered the solution that I mentioned before, I don’t think that is a good solution either. As you mentioned that to split one feature into 2 modules is not good, and now there is no way to describe the dependency of those two modules.

I think if we can describe the dependency between source files in INF file. For example,

[Sources.IA32]
  asl_source.asl
  c_source.c | asl_source.asl

The build tool will generate the dependency that says c_source.c depend on the output of asl_source.asl in Makefile?

What do you think?

Would you submit a BZ to track this issue?

Thanks,
Bob

From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of PierreGondois
Sent: Wednesday, December 11, 2019 7:24 PM
To: PierreGondois <pierre.gondois@arm.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

Hello Bob and Liming,
I am coming back to you after re-reading Bob's answer:
> I meet another problem related to .asl file. In one of platforms build process, there is a step which need to compile a .asl file a .h file firstly and that .h file will be included by a module’s source code.
> That step cannot be handled in edk2 build since the compilation command use different build option, so it’s done in a pre-build script. I want to make edk2 build be able to handle such case. So together with your case,  I think we may need a solution that can do:
> 1.       Create a module which contains the .asl file and the build option to compile that .asl file.
> 2.       Find a way to describe the dependency relation between the module contains .asl and the corresponding module contains .c file

I split my module into one module containing the .asl file, and a second module containing .c source files. However I could not find a way to describe a dependency between the two modules (as suggested in the second step).
This part of Bob's answer makes me think it's not possible using current edk2 build system:
> That step cannot be handled in edk2 build since the compilation command use different build option, so it’s done in a pre-build script.

I will have to reproduce the solution to multiple folders and for multiple platforms. Using a pre-build script would not be a scalable solution.
I would need to create a dependency between file extensions (or between modules which are edk2 library classes) using the build system.
Would you have an idea of how to do it, or if this is currently not possible and this implies modification in the build system, is there a way I could help?

Regards,
Pierre


[-- Attachment #2: Type: text/html, Size: 7909 bytes --]

  reply	other threads:[~2019-12-12  9:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 13:50 [PATCH v1 1/1] BaseTools: Build ASL files before C files PierreGondois
2019-10-30 13:52 ` [edk2-devel] " PierreGondois
2019-10-31  0:41 ` Liming Gao
2019-10-31 11:12   ` PierreGondois
2019-11-04  7:49     ` Bob Feng
2019-11-04 10:32       ` PierreGondois
2019-11-12 13:33       ` PierreGondois
2019-11-13  1:15         ` Liming Gao
2019-11-13  1:40         ` Bob Feng
2019-11-15 16:27           ` PierreGondois
2019-12-04 17:32             ` PierreGondois
2019-12-11 11:23               ` PierreGondois
2019-12-12  9:14                 ` Bob Feng [this message]
2019-12-16  0:33                   ` PierreGondois
2019-12-17 11:41                     ` Bob Feng
2019-12-18 10:43                       ` PierreGondois
2019-12-18 17:50 ` Ard Biesheuvel
2019-12-19 11:18   ` PierreGondois
2019-12-19 16:58     ` Ard Biesheuvel
2019-12-19 18:15       ` Sami Mujawar
2019-12-23 16:09         ` Ard Biesheuvel
2019-12-24 16:47           ` PierreGondois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D161580924@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox