From: "Bob Feng" <bob.c.feng@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
"anthony.perard@citrix.com" <anthony.perard@citrix.com>
Cc: "Gao, Liming" <liming.gao@intel.com>,
"Shi, Steven" <steven.shi@intel.com>
Subject: Re: [edk2-devel] [Patch 1/4 V6] BaseTools: Add build option for dependency file generation
Date: Tue, 17 Dec 2019 00:25:26 +0000 [thread overview]
Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D1615833A3@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9E4D127@ORSMSX113.amr.corp.intel.com>
I'll create patch to fix this issue.
Thanks,
Bob
-----Original Message-----
From: Kinney, Michael D
Sent: Tuesday, December 17, 2019 7:30 AM
To: devel@edk2.groups.io; anthony.perard@citrix.com; Feng, Bob C <bob.c.feng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Gao, Liming <liming.gao@intel.com>; Shi, Steven <steven.shi@intel.com>
Subject: RE: [edk2-devel] [Patch 1/4 V6] BaseTools: Add build option for dependency file generation
I recommend you use the ASCII ' character.
We want all source code files to be ASCII and we will be updating CI checkers to enforce this. Only UNI string files are allowed to use UTF-8 characters.
Mike
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Anthony
> PERARD
> Sent: Monday, December 16, 2019 6:14 AM
> To: devel@edk2.groups.io; Feng, Bob C
> <bob.c.feng@intel.com>
> Cc: Gao, Liming <liming.gao@intel.com>; Shi, Steven
> <steven.shi@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [Patch 1/4 V6] BaseTools: Add build option
> for dependency file generation
>
> On Fri, Dec 06, 2019 at 11:26:55PM +0800, Bob Feng
> wrote:
> > BaseTools/Conf/tools_def.template | 181
> ++++++++++++++++--------------
>
> Hi Bob,
>
> That patch introduces the first two UTF-8 characters (the quote ’ ) in
> an otherwise all-ascii file. And that prevent our CI from building
> OVMF.
> Part of the error log:
>
> Running edk2 build for OvmfPkgX64
> build.py...
> : error 0001: File open failure
> /home/osstest/build.144860.build-
> amd64/xen/tools/firmware/ovmf-dir-
> remote/Conf/tools_def.txt
> Traceback (most recent call last):
> File "/home/osstest/build.144860.build-
> amd64/xen/tools/firmware/ovmf-dir-
> remote/BaseTools/Source/Python/Common/ToolDefClassObjec
> t.py", line 117, in IncludeToolDefFile
> FileContent = F.readlines()
> File "/usr/lib/python3.5/encodings/ascii.py",
> line 26, in decode
> return codecs.ascii_decode(input, self.errors)[0]
> UnicodeDecodeError: 'ascii' codec can't decode byte
> 0xe2 in position 2289: ordinal not in range(128)
>
> Full build log can be found here, with ovmf build near the bottom:
> http://logs.test-
> lab.xenproject.org/osstest/logs/144860/build-
> amd64/6.ts-xen-build.log
>
> Should we replaces the two offending quotes by proper ascii quotes? Or
> should we fix IncludeToolDefFile to always use UTF-8 decoding? Or
> both?
>
> Thanks,
>
> --
> Anthony PERARD
>
>
next prev parent reply other threads:[~2019-12-17 0:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 15:26 [Patch 0/4 V6] Enhance Incremental Build Bob Feng
2019-12-06 15:26 ` [Patch 1/4 V6] BaseTools: Add build option for dependency file generation Bob Feng
2019-12-16 14:13 ` [edk2-devel] " Anthony PERARD
2019-12-16 23:30 ` Michael D Kinney
2019-12-17 0:25 ` Bob Feng [this message]
2019-12-18 2:31 ` Bob Feng
2019-12-06 15:26 ` [Patch 2/4 V6] BaseTools: Generate dependent files for ASL and ASM files Bob Feng
2019-12-06 15:26 ` [Patch 3/4 V6] BaseTools: Update build_rule.txt to generate dependent files Bob Feng
2019-12-06 15:26 ` [Patch 4/4 V6] BaseTools: Enhance Basetool for incremental build Bob Feng
2019-12-08 23:35 ` [edk2-devel] [Patch 0/4 V6] Enhance Incremental Build Liming Gao
2019-12-09 5:44 ` Bob Feng
2019-12-10 1:40 ` Bob Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08650203BA1BD64D8AD9B6D5D74A85D1615833A3@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox