From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.7321.1576649336596909735 for ; Tue, 17 Dec 2019 22:08:56 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: bob.c.feng@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 22:08:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,328,1571727600"; d="scan'208";a="415721475" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 17 Dec 2019 22:08:56 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 22:08:56 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 22:08:55 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.46]) with mapi id 14.03.0439.000; Wed, 18 Dec 2019 14:08:54 +0800 From: "Bob Feng" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Gao, Liming" , Leif Lindholm Subject: Re: [edk2-devel] [PATCH] BaseTools/Scripts: Add sendemail.transferEncoding to SetupGit.py Thread-Topic: [edk2-devel] [PATCH] BaseTools/Scripts: Add sendemail.transferEncoding to SetupGit.py Thread-Index: AQHVrGEr3fv/rHRdhUSiZoFmN8urhae/RehwgAA0VuA= Date: Wed, 18 Dec 2019 06:08:54 +0000 Message-ID: <08650203BA1BD64D8AD9B6D5D74A85D1615843E3@SHSMSX104.ccr.corp.intel.com> References: <15DDDAE6FE3C410D.8264@groups.io> <02A34F284D1DA44BB705E61F7180EF0AB5C64C6F@ORSMSX114.amr.corp.intel.com> In-Reply-To: <02A34F284D1DA44BB705E61F7180EF0AB5C64C6F@ORSMSX114.amr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: bob.c.feng@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Nate, This patch is good to me. Reviewed-by: Bob Feng Thanks, Bob -----Original Message----- From: Desimone, Nathaniel L=20 Sent: Wednesday, December 18, 2019 11:01 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Leif Lindholm Subject: RE: [edk2-devel] [PATCH] BaseTools/Scripts: Add sendemail.transfe= rEncoding to SetupGit.py Any chance I could get a code review on this? Thanks, Nate -----Original Message----- From: devel@edk2.groups.io On Behalf Of Nate DeSimo= ne Sent: Friday, December 6, 2019 10:15 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming = ; Leif Lindholm Subject: [edk2-devel] [PATCH] BaseTools/Scripts: Add sendemail.transferEnc= oding to SetupGit.py If git finds a '\r' character in the message, then it converts the entire = message content into Quoted-Printable encoding. It appears that when groups= .io converts the QP encoding back to text format, the '\r' characters someh= ow become '\n'. To workaround this, the SetupGit.py script will now explici= tly set the sendemail.transferEncoding git config option to '8bit' Cc: Bob Feng Cc: Liming Gao Cc: Leif Lindholm Signed-off-by: Nate DeSimone --- BaseTools/Scripts/SetupGit.py | 38 ++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/BaseTools/Scripts/SetupGit.py b/BaseTools/Scripts/SetupGit.py= index 3d39d3b35f..514f1c4d42 100644 --- a/BaseTools/Scripts/SetupGit.py +++ b/BaseTools/Scripts/SetupGit.py @@ -2,6 +2,7 @@ # Set up the git configuration for contributing to TianoCore projects #= # Copyright (c) 2019, Linaro Ltd. All rights reserved.
+# Copyright (c) 2019, Intel Corporation. All rights reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -53,29 +54,30 @@ MI= N_GIT_VERSION =3D (1, 9, 0) =20 # Set of options to be set identically for all repositories OPTIONS =3D = [ - {'section': 'am', 'option': 'keepcr', 'value': True}= , - {'section': 'am', 'option': 'signoff', 'value': True}= , - {'section': 'cherry-pick', 'option': 'signoff', 'value': True}= , - {'section': 'color', 'option': 'diff', 'value': True}= , - {'section': 'color', 'option': 'grep', 'value': 'auto= '}, - {'section': 'commit', 'option': 'signoff', 'value': True}= , - {'section': 'core', 'option': 'abbrev', 'value': 12}, + {'section': 'am', 'option': 'keepcr', 'value': Tr= ue}, + {'section': 'am', 'option': 'signoff', 'value': Tr= ue}, + {'section': 'cherry-pick', 'option': 'signoff', 'value': Tr= ue}, + {'section': 'color', 'option': 'diff', 'value': Tr= ue}, + {'section': 'color', 'option': 'grep', 'value': 'a= uto'}, + {'section': 'commit', 'option': 'signoff', 'value': Tr= ue}, + {'section': 'core', 'option': 'abbrev', 'value': 12= }, {'section': 'core', 'option': 'attributesFile', 'value': os.path.join(CONFDIR, 'gitattributes').replace('\\', '/')}, - {'section': 'core', 'option': 'whitespace', 'value': 'cr-a= t-eol'}, - {'section': 'diff', 'option': 'algorithm', 'value': 'pati= ence'}, + {'section': 'core', 'option': 'whitespace', 'value': 'c= r-at-eol'}, + {'section': 'diff', 'option': 'algorithm', 'value': 'p= atience'}, {'section': 'diff', 'option': 'orderFile', 'value': os.path.join(CONFDIR, 'diff.order').replace('\\', '/')}, - {'section': 'diff', 'option': 'renames', 'value': 'copi= es'}, - {'section': 'diff', 'option': 'statGraphWidth', 'value': '20'}= , - {'section': 'diff "ini"', 'option': 'xfuncname', + {'section': 'diff', 'option': 'renames', 'value': 'c= opies'}, + {'section': 'diff', 'option': 'statGraphWidth', 'value': '2= 0'}, + {'section': 'diff "ini"', 'option': 'xfuncname', 'value': '^\\\\[[A-Za-z0-9_., ]+]'}, - {'section': 'format', 'option': 'coverLetter', 'value': True}= , - {'section': 'format', 'option': 'numbered', 'value': True}= , - {'section': 'format', 'option': 'signoff', 'value': False= }, - {'section': 'notes', 'option': 'rewriteRef', 'value': 'refs= /notes/commits'}, - {'section': 'sendemail', 'option': 'chainreplyto', 'value': False= }, - {'section': 'sendemail', 'option': 'thread', 'value': True}= , + {'section': 'format', 'option': 'coverLetter', 'value': Tr= ue}, + {'section': 'format', 'option': 'numbered', 'value': Tr= ue}, + {'section': 'format', 'option': 'signoff', 'value': Fa= lse}, + {'section': 'notes', 'option': 'rewriteRef', 'value': 'r= efs/notes/commits'}, + {'section': 'sendemail', 'option': 'chainreplyto', 'value': Fa= lse}, + {'section': 'sendemail', 'option': 'thread', 'value': Tr= ue}, + {'section': 'sendemail', 'option': 'transferEncoding', 'value': '8= bit'}, ] =20 =20 -- 2.24.0.windows.2