From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id ABF91AC1744 for ; Wed, 29 May 2024 18:18:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=7WPLBfljF+WuRnGWCFjay0529N9nfz1w9Qkmwb8s/Rk=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717006735; v=1; b=ZBNweo1obkMxBXoAJ5Dkt3kr6c0eh0QNun4Pv5kJyKKLW9oxsOpYIjEKF+YtGDzwFOrNxEL7 8Lt0mfE7o7Op8w0iexgwNq0R3VQ6BIxbywYfoyqS5kuAaHKsrZVZED8PUKWaMEabYTCxsLEclQj LQbBU29+AzXnHF/EtG0CgnGiUeIHq6ToBn66L7NjXDD9SBlTS950vxYe6ynlgf2E5Nx0YTm/lnG l/gO6X2GjTvinGdah8FkLHnbR4gBGHpTSI/7GWGc7uFIdXFWShfTa7A1K9LO1gfqYSWOSskpuWT EOWcV0sxku+VFyOabuR8x7D2d49KF3aaNG7r/z1XoIUFQ== X-Received: by 127.0.0.2 with SMTP id KVABYY7687511xcaJYsVUNFA; Wed, 29 May 2024 11:18:54 -0700 X-Received: from wfout7-smtp.messagingengine.com (wfout7-smtp.messagingengine.com [64.147.123.150]) by mx.groups.io with SMTP id smtpd.web10.23078.1717006733482293334 for ; Wed, 29 May 2024 11:18:53 -0700 X-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfout.west.internal (Postfix) with ESMTP id 74E891C000A0; Wed, 29 May 2024 14:18:52 -0400 (EDT) X-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 29 May 2024 14:18:52 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekuddguddvvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeejhefgtdeludeitefffeevteduhfeiffdtieeuleelgfevuddthffhudeg feelheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 May 2024 14:18:50 -0400 (EDT) Message-ID: <086790e8-a850-426f-86b1-73f54feebc1b@bsdio.com> Date: Wed, 29 May 2024 12:18:49 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] GitHub PR Code Review process now active To: devel@edk2.groups.io, michael.d.kinney@intel.com, "kraxel@redhat.com" , "Kubacki, Michael" References: From: "Rebecca Cran" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 29 May 2024 11:18:53 -0700 Resent-From: rebecca@bsdio.com Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 42ERHhhygzg24zAGDpZCfFuIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=ZBNweo1o; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 5/29/2024 12:09 PM, Michael D Kinney via groups.io wrote: > Hi Gerd, > > We can clarify the Wiki. A Maintainer has to be involved in every > code review. The first action a Maintainer does is verify that the > code change should be considered at all or rejected. Then add > maintainers for the ones that look like good submissions. > > I agree that this may add a bit of delay. You are welcome to add > a comment with @ tags to the maintainers and reviewers so > they know to look at it and do the assignments. If you like that > idea we can add that to the Wiki as well. > > Since PRs can be also opened by outside contributors that have > limited access, maintainers have to be involved in reviewing newly > submitted PRs. "Then add maintainers for the ones that look like good submissions." Surely in order for the maintainers to know the PR should be looked at=20 in the first place they need to already be added? --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119359): https://edk2.groups.io/g/devel/message/119359 Mute This Topic: https://groups.io/mt/106355103/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-