From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web10.2135.1626168661074038045 for ; Tue, 13 Jul 2021 02:31:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=c2XxdCPH; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=08282ce170=daniel.schaefer@hpe.com) Received: from pps.filterd (m0148664.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16D99Y7P006646; Tue, 13 Jul 2021 09:31:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=F9KDZN2UNGLnsZ7qPwXR0Aw89fj3lv0spioUJCOcbqw=; b=c2XxdCPH7SJOL/i6FObVrUt0OdacXbqg37Q/1omuhrreToLm8vtKSjD1lHRw+dUiimEk WjD0e5KdOC2bkIysvR15Oan5uyQdUoZj1xaIrA720rLnSWzaTgMkxp4Z+YdSwxsSajpC VbjdIB0nTU4NkyHIPkdeCMZx2nvH0efVrV1g+rCqmuwSQKfu98ZNEeIVS2Ya/YfXBhsn GKQomeAERIOceE9AdpROkc+Y6ICNub5cNq/JXhqKeBZzaZrI0zQJlo4iwbk2R+i9IVfu HRLB4uJvs1d/d+/qjc7GIDSFVb0yxLTeVz3LcwbCoY1GCP3ztNHlgjZTvmro40K8MbTT mA== Received: from g4t3425.houston.hpe.com (g4t3425.houston.hpe.com [15.241.140.78]) by mx0b-002e3701.pphosted.com with ESMTP id 39rmevhd1d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 13 Jul 2021 09:30:59 +0000 Received: from G4W9121.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.21.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g4t3425.houston.hpe.com (Postfix) with ESMTPS id 4D2998D; Tue, 13 Jul 2021 09:30:59 +0000 (UTC) Received: from G9W8456.americas.hpqcorp.net (2002:10d8:a15f::10d8:a15f) by G4W9121.americas.hpqcorp.net (2002:10d2:1510::10d2:1510) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 13 Jul 2021 09:30:59 +0000 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (15.241.52.11) by G9W8456.americas.hpqcorp.net (16.216.161.95) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Tue, 13 Jul 2021 09:30:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S1/Vy8iw9gfzL4TWY5Tc8vkoIYBU8l7PRyHw1l6wA0wETbcpey2H1wUDQGKgsBPATmoDByC3myDzSIZXSV1mV+HM0hxIGRwhwbjS6vGt7krBUxb/PzWpaiXwzZAfgkaZ69pi0eJ0llqe2yabRgtcwkr46niemZCpCNFC6RE7JUMR+gpxzX+Ie7gmbh+8OSzD+C7+h7uZOztiRwjKy/3Os6WCtrN8Ze9HbSlIa4NWMPsCmi3EACQQWVqeHWCHzVSKH7Numg4rO2LBcV2+CscmIMZmnFWy552g8KTxeDHQKH8TWBGhgFYMI9qYu5OXvn1whgbS459vDtjXs6iZ9tibtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kyVtOY3xKDI0L1UYJddDgzooPFMUJ1yoYzOzLpDVAQw=; b=b6p7IU66lTuhcwqtz7OejJFv4ucpyCp5OeJZp38/1HfbtHSqoyoKU1KtgqhA2+ZHkXxohQOdbVF7/TRUNRXGUCueiwS//rODyh+ixmzcUwtzEX71M55Ubf8warmnowolOhQQZIKQSj2jNFtvSaFQ116WAO/He4p8Q3A3LuL6oLWXmPruAupAY2O/tTyAphzViOzi2B4Qk2eqW9kkBoP7yA0jXKpcjaWX/Oqh/INVrzy+o3FNIRbjSq1wmfkfCHRsUiWGBu3FgZMBlvw550pZr15w28t/2AUb7IRi2CShU4MDLAT5oHe9AuxoiR/XJk4NhALc9FaQfepzzJ6IMXgC5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) by DF4PR8401MB0812.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Tue, 13 Jul 2021 09:30:57 +0000 Received: from DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c804:b24:831b:272a]) by DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM ([fe80::c804:b24:831b:272a%5]) with mapi id 15.20.4308.027; Tue, 13 Jul 2021 09:30:57 +0000 Subject: Re: [edk2-devel] [PATCH v1 1/1] RamDiskDxe: Initialize list head before registering RAM disk protocol To: "Wu, Hao A" , "devel@edk2.groups.io" CC: Trammell Hudson , "Wang, Jian J" , "Ni, Ray" , "Gao, Zhichao" References: <20210713010931.445739-1-daniel.schaefer@hpe.com> <20210713010931.445739-2-daniel.schaefer@hpe.com> From: "Daniel Schaefer" Message-ID: <087ace9a-06e5-86a4-c20f-b141e6444b27@hpe.com> Date: Tue, 13 Jul 2021 17:30:52 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 In-Reply-To: X-ClientProxiedBy: SN4PR0801CA0005.namprd08.prod.outlook.com (2603:10b6:803:29::15) To DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760d::23) X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.42.127] (123.193.59.220) by SN4PR0801CA0005.namprd08.prod.outlook.com (2603:10b6:803:29::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.19 via Frontend Transport; Tue, 13 Jul 2021 09:30:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: efdba575-0fa6-4e4e-e4a1-08d945e0eb73 X-MS-TrafficTypeDiagnostic: DF4PR8401MB0812: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2803; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2pgxlmmW6R8S0LiQu2o63Gq8Oz5trjhIUY1JcNSxaJZWu+3Q/HMTTEbQIOxUn6TR6CwyMTNZEVwoxUBKi/yyCXV8IhodeQr6OHlLZtgTOmeylAFnwX0yXFY4o3WaEwv2F1TG0nzbif1sMZhjk6UK513o6WI8I/1LAbpPJ+nFM4LADg/1zxMzwCN9JjBRyPzhp8JvrGTIORiMvnYeQFLNKjnWzCTg231x5079EtjIFtxDAsgTfw1qpqW6wuEKDVQnoFpAhQAM/8XAcvlZxOiu9YRd+BcfzVpr6P7q0NuziPtTtWQBOaDmyP62nAwt8EIzzWy61RpnpqkzpYdkIBuNnIC50G0zvo3oG4V7tOZqYSaDJ4J5yZuBMwwA6CWR6dU/rGqGVQkOrORP2w0CBv7kpOWfyAnoPXQ0H7f9hzO1IBMUhZMEZ6PJxXX6l/SnWj4cckr0IoW8nW2XKraizmV2tUInbOUDpU33M1Z6tp9GnniWbGOLqg3DqdTzR0Nm/GVXSMxdRRoRlWoaka6eG2uBfbGt0GBbpcD1fmDutYLq0GZrULqliIYrKIeZWhV2OVhJMkuuua6DSCvgq1c7vHy6ZKDfcMVyuXgpYKCFCXi63LmAqsigx1GuuEUooTg78NQ2u0PIAPZYSy/aHBOz4olhUfX/nK1DgygKsun/v2IkNTLPh0n8/cmT+K9FAF8EOSnsd9wq1Eu8zfYpHAXTwk4T3itDkOkY6Bip7u3mOeuT1ECjWWfL6u5KJOGg0sm65MtLqGxuaoICSct96M290kiNtczSVB3PxEkyQJfVMgvyPifVNXyjua2Or+V+9UVXsHh0ek8Fvauc1W2BzMGQ3CuOUwUiQrEa1E1xSyuMTu8TWMQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(39860400002)(376002)(396003)(346002)(136003)(366004)(8936002)(31686004)(31696002)(110136005)(53546011)(44832011)(966005)(186003)(956004)(4326008)(8676002)(26005)(316002)(6666004)(2616005)(86362001)(66946007)(54906003)(36756003)(478600001)(66556008)(5660300002)(2906002)(66476007)(6486002)(83380400001)(38100700002)(16576012)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amRKeTVrbThZNFpjdjVKVXpCalNSRGRQVFM1RHhUbnRTejg3d1J4aWdHNWJO?= =?utf-8?B?TE1WWUlHUHRzY1gwbUNoclFlTThKWFg5SnE2blFseHJReC9jOVMrZWZKUVdB?= =?utf-8?B?RGg5eFJsZFdBMnF0NW1yNWdleGFwcldjSW9ldkNoeFFWNU9XWCtaQkhMaEIy?= =?utf-8?B?VWdHUmhuQzlvaXNrNDl1Q210U3M3TjBTZ2lpbWJkYTRMWVp4d28wS1pUbzZs?= =?utf-8?B?cVE0VTZUR2pnWkhFL0Y5M1dlbGNxRnlhaEFyeDM3VUMxQlliUmZlUklod0x5?= =?utf-8?B?SWNyQ0dXaDlUbGI0dHBMOS9rcHhOWlpwOTJrZEltYjhGNWRvUXVJeUlueGs1?= =?utf-8?B?QnJJdnVrUW9Ickk0YW5sazNKNmdaZDRlUnovL0RYZVgvZUV0cUZBUk5KOGRj?= =?utf-8?B?YVA1UWNobnNhWlpkNXo5ekI4QTVCTmN3R083TFhqa3VwbDVhQW92VU5mT1hx?= =?utf-8?B?VFQrZlNKVGpFNVJDUHNSTm1KRStpcjR1aUpSUk14ek9VR040Z0FKVjMxVVVN?= =?utf-8?B?enJBdkY2Vm1Obmw3VGR0eDdyM0ZYd2ZUbWpEb2Y2a0wzR2hEZEdUUnJkd21s?= =?utf-8?B?UjkvU0ZlUzYxSlFiSkV4S2hZOFEvcVJHWGJBcUdJOFZhYTJmb1BNcnVkajZu?= =?utf-8?B?d3RHc0FxamxKd3FWUFprUFJXVlpRMzduRHNFWHFzcDJWWDdrMWpVSFB3Z3Rq?= =?utf-8?B?QThQYnhrQkFGWE9ZdWw2WGoydUJBVHAxdlpLMkJHdnYwbjlMUVQvNU5TaW9k?= =?utf-8?B?bmRIdENZdWVRai9UN0MzVXFYcFFtUHlHcVQ2NWRhelg1VE80TC9TTzFXaVhx?= =?utf-8?B?YzFSVlZNOWM1OS8zYUhHOExyQ2ZpSjVCbXV3TmVMZzE1Nzloc3gxTkF1RjFi?= =?utf-8?B?MHpMNHZUdjJadC9vOEpOeTY2RkZZdW5HTGZFaUxaUE50R2k3RWtqZ3VtQ0Zo?= =?utf-8?B?Z1Jpam9saUZqYnhOUXRkRnFMT3dQOVF6VmtXQ3o2L0llaEoxbWh6R0U5ZjUy?= =?utf-8?B?SXdOelM5NWpMaHhlK3YvZlFaNUM3K0Rlb0JYWFF5MFF1WlJYV3UzMnh6dHRJ?= =?utf-8?B?YzhLZmJsWEU5akl3VDdOTzZ1c3dmK1dKWnlzNkVadGJwL0swOHdPc3MzNklu?= =?utf-8?B?dUh4dk0xUmpIYUh3bFNMTjIrdUwyYUs0MTdrVjl2QU5RMU5aRlJDQ0E2T2tZ?= =?utf-8?B?alMrdkhWMGtKQ2RHYTFxazZ3c29ZbUM4b2RWUWxUM04yMzk3V2F1Ym5VS01E?= =?utf-8?B?NHNneEgzelE5TzZPckQ5aWRsZ3huZkN1bi81aFJSNEszdjd6NmhvSDVocXZl?= =?utf-8?B?VmZIWFhQMW9YWXBoaHc5bnROQnVRQlNld3RPbUQraUEwRFZQL0FNQWxvUlF0?= =?utf-8?B?NVFVVUhrakp5YzFCSDZTWnF5eDhKdlBOV3N2dkJTUmx0YS9kd0gyWDhEb3JN?= =?utf-8?B?a2dJdkw4dm43dksvZm1DNzVIQWloNEhCb0hPQmllMHpiZlNzcWNla2JFVlAv?= =?utf-8?B?WHVnV3Ruc2F1UkxMMkxmaUZCWnlsRkY1WEFheVRlb3htM0JUUWhxRE5kNHI2?= =?utf-8?B?TnZOaHhDbmFqTjk3WUt6dUZzRGpDZFhtclFhUDR6WlNLNlVCUVh4VmYvR2F1?= =?utf-8?B?aEtMQ1hoWDF4cGY4Y2hNNG4yQng4MVNFKzUzSnMvNWp3ZWdKY0VBZEtxQzZE?= =?utf-8?B?b0RNbmtQZExlalAxOWVOOWcrUWIvM21qeGIycDBlcnB1ZVpPTGNiMy9Hb2FZ?= =?utf-8?Q?aI/LZV9leMMMJdWIobNiGMFxUW0LAJnH1Sb6UOd?= X-MS-Exchange-CrossTenant-Network-Message-Id: efdba575-0fa6-4e4e-e4a1-08d945e0eb73 X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0444.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2021 09:30:57.6266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p/nCCTB+Qg4iMjDs9VdN/u+WTAT1K6oP7Iex4V1TSk5x1BIb5TIvwSLAduxpiTrUGE/gzgD0uiMj3jgLDFS9Pg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB0812 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: eKII2u3iu-jCib8xi4kIjm4yaP0v__OT X-Proofpoint-GUID: eKII2u3iu-jCib8xi4kIjm4yaP0v__OT X-Proofpoint-UnRewURL: 3 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.790 definitions=2021-07-13_03:2021-07-13,2021-07-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 clxscore=1015 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107130058 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 7/13/21 11:44 AM, Wu, Hao A wrote: >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Daniel >> Schaefer >> Sent: Tuesday, July 13, 2021 9:10 AM >> To: devel@edk2.groups.io >> Cc: Trammell Hudson ; Daniel Schaefer >> ; Wang, Jian J ; Wu, >> Hao A ; Ni, Ray ; Gao, Zhichao >> >> Subject: [edk2-devel] [PATCH v1 1/1] RamDiskDxe: Initialize list head before >> registering RAM disk protocol >> >> From: Trammell Hudson >> >> This patch initializes the linked list RegisteredRamDisks in >> RamDiskDxeEntryPoint before the registration of gEfiRamDiskProtocolGuid >> with InstallMultipleProtocolInterfaces, allowing ramdisks to be created via a >> callback installed with RegisterProtocolNotify as soon as the protocol is >> registered. >> >> Without this, calling RamDisk->Register() in the callback causes a crash: >> >> ASSERT [RamDiskDxe] MdePkg/Library/BaseLib/LinkedList.c(75): List- >>> ForwardLink != ((void *) 0) >> >> Signed-off-by: Trammell Hudson >> Cc: Daniel Schaefer >> Cc: Jian J Wang >> Cc: Hao A Wu >> Cc: Ray Ni >> Cc: Zhichao Gao > > > Thanks a lot for the fix. > Reviewed-by: Hao A Wu > > I will modify the subject a little bit when merging: > MdeModulePkg/RamDiskDxe: Init list head before registering RamDisk protocol Sure, that's good. Thanks! > > Best Regards, > Hao Wu > > >> >> --- >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 11 ++++++- >> ---- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c >> b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c >> index fcbf4f117dc6..13e2aed87cef 100644 >> --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c >> +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c >> @@ -154,6 +154,12 @@ RamDiskDxeEntryPoint ( >> goto ErrorExit; >> } >> >> + // >> + // Initialize the list of registered RAM disks maintained by the >> + driver // before installing the protocol // InitializeListHead >> + (&RegisteredRamDisks); >> + >> // >> // Install the EFI_RAM_DISK_PROTOCOL and RAM disk private data onto a >> // new handle >> @@ -170,11 +176,6 @@ RamDiskDxeEntryPoint ( >> goto ErrorExit; >> } >> >> - // >> - // Initialize the list of registered RAM disks maintained by the driver >> - // >> - InitializeListHead (&RegisteredRamDisks); >> - >> Status = EfiCreateEventReadyToBootEx ( >> TPL_CALLBACK, >> RamDiskAcpiCheck, >> -- >> 2.31.1 >> >> >> >> >> >