From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 492DF209831F3 for ; Mon, 16 Jul 2018 04:01:11 -0700 (PDT) Received: by mail-it0-x241.google.com with SMTP id s7-v6so20206830itb.4 for ; Mon, 16 Jul 2018 04:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KmnAriPe7sCg0ycirVQ3TBKu7GZa0e8jsKLGHz9ddeQ=; b=G/03vcTLry4ZBJBDRHeUkNxGACEcbe4mC7Oivv7tByR0TMCv3B1VNYSxOWkMTnF6dY z3d/xtc3pz/rmsEYMdaA7i9WEBOQrGlJ0oYkuoQzo6jhMu1h2S68+yiUolaJu1c19T6w UcnnNJH+DDN11bo0aYFmGQymeijBUVaUu+lGo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=KmnAriPe7sCg0ycirVQ3TBKu7GZa0e8jsKLGHz9ddeQ=; b=BZqsSxcmcYuN/A9ysGTKSgLcUgtIl4Sizr0hgp8DioPRnfUNvBmZnfiIULyej7Gh5q mcKNix6BpK+LvyTTsuNu2ffjdHAXAhrJebZXfNz4vkPRB3jUloY9RniNsj3z8YUNEKGg IjI7+wXypiCo4dhxyCdl/i0eujoXWZosJqBhXu8XmCs4UYb6H8pEUodnYv/lk/lZVYSj eVaXmX1pFKZu6gyY28VbsdLt3omIH75+vWAVi64VL0YLMJjSt0VV3lsDPoo5psALI7qn 4cAGbx/C+1WQt39Nqj1XQQZb0Pu1sT188FL7ut404ZXJUFNOh0xlcJB4EbN/958/WQhm LfjQ== X-Gm-Message-State: AOUpUlE2+9Ktaa9JGxM9uhvHQa4z3O7T77Jc2MK0vWLJCyWKjbqGY1Ys 9vk0xz64JThz/IobJ9uQBrlzFhpLTJ8= X-Google-Smtp-Source: AAOMgpcD26eAsMBS4Zx6G3mapQO/mzqO5/by7Y8bquvr5CNGg+M/9gf5b3NowjeCNfRfteUCd+dxXg== X-Received: by 2002:a02:597:: with SMTP id 23-v6mr13692747jal.112.1531738870729; Mon, 16 Jul 2018 04:01:10 -0700 (PDT) Received: from [100.69.6.139] (111-241-220-234.dynamic-ip.hinet.net. [111.241.220.234]) by smtp.gmail.com with ESMTPSA id w191-v6sm4522456ita.33.2018.07.16.04.01.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jul 2018 04:01:10 -0700 (PDT) Mime-Version: 1.0 (1.0) From: Ard Biesheuvel X-Mailer: iPhone Mail (15F79) In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BD7A370@SHSMSX104.ccr.corp.intel.com> Date: Mon, 16 Jul 2018 19:01:07 +0800 Cc: "edk2-devel@lists.01.org" , Leif Lindholm Message-Id: <088283C9-1EE9-433D-AAB1-7FB7054F5A87@linaro.org> References: <20180704015057.35908-1-ruiyu.ni@intel.com> <20180704015057.35908-7-ruiyu.ni@intel.com> <734D49CCEBEEF84792F5B80ED585239D5BD7A370@SHSMSX104.ccr.corp.intel.com> To: "Ni, Ruiyu" Subject: Re: [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 11:01:12 -0000 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit > On 16 Jul 2018, at 17:07, Ni, Ruiyu wrote: > > Can someone give a r-b for this patch? > Is Ack-by enough for a check-in? Hi Ray, Please go ahead and merge this patch with my ack. Ard. > >> -----Original Message----- >> From: Ard Biesheuvel >> Sent: Wednesday, July 11, 2018 10:21 PM >> To: Ni, Ruiyu >> Cc: edk2-devel@lists.01.org; Leif Lindholm >> Subject: Re: [PATCH v4 6/9] ArmPkg/PlatformBDS: Implement >> PlatformBootManagerUnableToBoot >> >>> On 4 July 2018 at 03:50, Ruiyu Ni wrote: >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Ruiyu Ni >>> Cc: Leif Lindholm >>> Cc: Ard Biesheuvel >> >> Acked-by: Ard Biesheuvel >> >>> --- >>> ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 18 >>> +++++++++++++++++- >>> 1 file changed, 17 insertions(+), 1 deletion(-) >>> >>> diff --git a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >>> b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >>> index 079f1552d5..f9c71d430c 100644 >>> --- a/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >>> +++ b/ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c >>> @@ -3,7 +3,7 @@ >>> >>> Copyright (C) 2015-2016, Red Hat, Inc. >>> Copyright (c) 2014, ARM Ltd. All rights reserved.
>>> - Copyright (c) 2004 - 2016, Intel Corporation. All rights >>> reserved.
>>> + Copyright (c) 2004 - 2018, Intel Corporation. All rights >>> + reserved.
>>> Copyright (c) 2016, Linaro Ltd. All rights reserved.
>>> >>> This program and the accompanying materials are licensed and made >>> available @@ -766,3 +766,19 @@ PlatformBootManagerWaitCallback ( >>> Print (L"."); >>> } >>> } >>> + >>> +/** >>> + The function is called when no boot option could be launched, >>> + including platform recovery options and options pointing to >>> +applications >>> + built into firmware volumes. >>> + >>> + If this function returns, BDS attempts to enter an infinite loop. >>> +**/ >>> +VOID >>> +EFIAPI >>> +PlatformBootManagerUnableToBoot ( >>> + VOID >>> + ) >>> +{ >>> + return; >>> +} >>> -- >>> 2.16.1.windows.1 >>>