From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 3D02D78044E for ; Tue, 9 Jan 2024 08:27:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dj2MjEyzhNuwYHs/XCS9bJ6/HwWbuOYYYoCi9JZAv64=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704788874; v=1; b=u186IQjcx94ZiZEksMbzoBlNtW82vCMcI1y3GHzKLR1onY0gNoiA21ZvZI1skX0LD4Droe5t pyLvUE6G7414L1HiDDrRcuRv8GuooPaXQjA1nNyBPCdmkHPfx0/5g3SbxzdDhJBCLRJn/rQ7Y28 8N0wHSkGaggXUhr/p31zjgXg= X-Received: by 127.0.0.2 with SMTP id 01oBYY7687511xE51VvG1EWc; Tue, 09 Jan 2024 00:27:54 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.12401.1704788874153718734 for ; Tue, 09 Jan 2024 00:27:54 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-WBjKdYPON92-lQrYdkjqew-1; Tue, 09 Jan 2024 03:27:49 -0500 X-MC-Unique: WBjKdYPON92-lQrYdkjqew-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73D4429AA394; Tue, 9 Jan 2024 08:27:48 +0000 (UTC) X-Received: from [10.39.193.97] (unknown [10.39.193.97]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29D172166B33; Tue, 9 Jan 2024 08:27:47 +0000 (UTC) Message-ID: <088d737b-e186-3bd5-31ed-ace1b0f9b675@redhat.com> Date: Tue, 9 Jan 2024 09:27:45 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v4 1/3] OvmfPkg/RiscVVirt: use gEfiAuthenticatedVariableGuid unconditionally To: Gerd Hoffmann , devel@edk2.groups.io Cc: oliver@redhat.com, Jiewen Yao , Ard Biesheuvel , Sunil V L , Andrei Warkentin References: <20240108192123.42359-1-kraxel@redhat.com> <20240108192123.42359-2-kraxel@redhat.com> From: "Laszlo Ersek" In-Reply-To: <20240108192123.42359-2-kraxel@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0DALhouRSY88pI7aIABeL1srx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=u186IQjc; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/8/24 20:21, Gerd Hoffmann wrote: > ArmVirt and OVMF are doing the same. > > See commit d92eaabefbe0 ("OvmfPkg: simplify VARIABLE_STORE_HEADER > generation") for details. > > Suggested-by: László Érsek > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/RiscVVirt/VarStore.fdf.inc | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/OvmfPkg/RiscVVirt/VarStore.fdf.inc b/OvmfPkg/RiscVVirt/VarStore.fdf.inc > index aba32315cc37..6679c246b3ea 100644 > --- a/OvmfPkg/RiscVVirt/VarStore.fdf.inc > +++ b/OvmfPkg/RiscVVirt/VarStore.fdf.inc > @@ -36,19 +36,12 @@ > # Blockmap[1]: End > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > ## This is the VARIABLE_STORE_HEADER > -!if $(SECURE_BOOT_ENABLE) == TRUE > + # It is compatible with SECURE_BOOT_ENABLE == FALSE as well. > # Signature: gEfiAuthenticatedVariableGuid = > # { 0xaaf32c78, 0x947b, 0x439a, > # { 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92 }} > 0x78, 0x2c, 0xf3, 0xaa, 0x7b, 0x94, 0x9a, 0x43, > 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92, > -!else > - # Signature: gEfiVariableGuid = > - # { 0xddcf3616, 0x3275, 0x4164, > - # { 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d }} > - 0x16, 0x36, 0xcf, 0xdd, 0x75, 0x32, 0x64, 0x41, > - 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d, > -!endif > # Size: 0x40000 (gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariableSize) - > # 0x48 (size of EFI_FIRMWARE_VOLUME_HEADER) = 0x3FFB8 > # This can speed up the Variable Dispatch a bit. Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113431): https://edk2.groups.io/g/devel/message/113431 Mute This Topic: https://groups.io/mt/103605055/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-