From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.743.1587384926917094490 for ; Mon, 20 Apr 2020 05:15:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Z7FEiZD4; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587384926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wcHTWs+pW5rCBPFRBhjzvO205s5Hh1NL/3vAok8lw9M=; b=Z7FEiZD4DJohBL8PEa1yaY1r2D0GoJdbAAn15CQxgA4/O/46atD9b/YIT3YfTHiFIZ7rVM h0BOqRKSN7Wh0YOSNBaMwVw7uqlwbyDHieRreKY7U+uj9NBzrSoc3yIonisNM/WUlOaw8B 4hvgbtXq1+DV5osdpnVyuIP9t7wFOps= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-86-Rt1z18aONZ69-naLJZNg6A-1; Mon, 20 Apr 2020 08:15:17 -0400 X-MC-Unique: Rt1z18aONZ69-naLJZNg6A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7B6BA801F74; Mon, 20 Apr 2020 12:15:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-228.ams2.redhat.com [10.36.114.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 53098A1898; Mon, 20 Apr 2020 12:15:13 +0000 (UTC) Subject: Re: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: PcdAcpiExposedTableVersions default for Arm64 platforms To: Dandan Bi Cc: devel@edk2.groups.io, samer.el-haj-mahmoud@arm.com, Jian J Wang , Hao A Wu , Liming Gao , Leif Lindholm , Ard Biesheuvel , nd , "samer@elhajmahmoud.com" References: <20200410152925.6119-1-samer@elhajmahmoud.com> <20200410152925.6119-2-samer@elhajmahmoud.com> From: "Laszlo Ersek" Message-ID: <08951bf6-9efc-dc7c-ab2c-2c1ccda756a2@redhat.com> Date: Mon, 20 Apr 2020 14:15:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Dandan, On 04/18/20 17:14, Samer El-Haj-Mahmoud wrote: > Jian, Hao, > > Can you please push this simple patch? It has been reviewed a while ago and ready to be committed. should we consider your R-b on the first patch sufficient for pushing? You are marked as "R" for "MdeModulePkg: ACPI modules", but technically speaking, "MdeModulePkg.dec" needs an ACK from either Jian or Hao. Content-wise, your approval looks sufficient, but I don't want to assume. Please confirm. Thank Laszlo >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Samer El- >> Haj-Mahmoud via groups.io >> Sent: Friday, April 10, 2020 11:29 AM >> To: devel@edk2.groups.io >> Cc: Dandan Bi ; Liming Gao ; >> Jian J Wang ; Hao A Wu ; Leif >> Lindholm ; Ard Biesheuvel >> Subject: [edk2-devel] [edk2][PATCH v2 1/2] MdeModulePkg: >> PcdAcpiExposedTableVersions default for Arm64 platforms >> >> Set the default value of PcdAcpiExposedTableVersions for Aarch64 platforms to >> 0x20. Previously, the default was set to 0x3E for all platforms. The new value >> removes ACPI 1.0b compatability, which forces the use of XSDT 64-bit pointer, >> as required by Arm SBBR specification. >> This also resolves an error reported by acpiview command, as seen on the RPi >> (see https://github.com/pftf/RPi4/issues/25). >> >> Cc: Dandan Bi >> Cc: Liming Gao >> Cc: Jian J Wang >> Cc: Hao A Wu >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> >> Signed-off-by: Samer El-Haj-Mahmoud >> Reviewed-by: Ard Biesheuvel >> Reviewed-by: Dandan Bi >> --- >> MdeModulePkg/MdeModulePkg.dec | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/MdeModulePkg/MdeModulePkg.dec >> b/MdeModulePkg/MdeModulePkg.dec index 497574cb0870..fac16f262cf8 >> 100644 >> --- a/MdeModulePkg/MdeModulePkg.dec >> +++ b/MdeModulePkg/MdeModulePkg.dec >> @@ -1548,6 +1548,9 @@ >> # @Prompt Console Output Row of Text Setup >> >> gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow|25|UINT32|0x40000 >> 00e >> >> +[PcdsFixedAtBuild.AARCH64, PcdsPatchableInModule.AARCH64] >> + >> +gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiExposedTableVersions|0x20|UINT >> 32| >> +0x0001004c >> + >> [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >> ## UART clock frequency is for the baud rate configuration. >> # @Prompt Serial Port Clock Rate. >> -- >> 2.17.1 >> >> >> > > > >