From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4864:20::444; helo=mail-wr1-x444.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D55AD208AE2DD for ; Thu, 14 Feb 2019 16:09:56 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id l5so7390485wrw.6 for ; Thu, 14 Feb 2019 16:09:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=from:subject:to:references:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=7vSiRAVQoGJ/xBKkqKgAdfnMEPML2HhkPPUtvFXdj8s=; b=prq0PEAyR+OXtJjtZCnDkvkjb+zPIM5JVFZg3dTgBP2j7+jBQxFS/Qkwsn176rcIkN QnlcmNhfAYbmK9j+Qx4JX87D+2Gd0Ee4fFgxlB5YzS3SK44WE9JtTp+7StOUeWeamGhC WfngM1W1Y6RHvYCsZe6tNf1O6GmOlbjmw2lpuc9v3Ov/zCK5ld+Dia+eRY3mwU2IA1Fs Ypkzmw7N7g8isAjMZExNAZCworoM02ozdDNQQ/s31OPyhB0fE3QnDi0JAWmLoVMo+UhC l8/e/MoWjgpbhnSZ8Y15sM5ypD340UzxxzFyDa09+6+46XFSkh7FfCEJCEww48LO+7W2 uWjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7vSiRAVQoGJ/xBKkqKgAdfnMEPML2HhkPPUtvFXdj8s=; b=m6mGSc2xGjq+fBHPk5LHVjG6VPF1y2IHOhRqg6j98g+0QbIXDLoiT/+TgSc25Gr+il E2as8kFrF6ckpH3tkZRCLWTTshjhNiwZ0wdDHeG7p4d1J//CYzX1LfVUH/pDsWtHX+nj dTR38UjmYFekd1lP5NekU1GCy9Eabc20558BoLSrnZfp2Bn1StyA/4qAQQ/wxRBmg9+H guAR/dhsnXRaA90KTQA/kpvj0aPBxt7r9BGmawyM4IHQlLp9klEKg/xKHpnoQ6L5xR6C sAwi7FYBKNoKhcS9pCXCSX1DBrevzqf7Cw+IB2L7mrcWsNPyOlMSmTeC7+L4zCtt/LIc AsjQ== X-Gm-Message-State: AHQUAuZcShHsTVGiP5XYIIZC9Ia/eBJUhsIM6lAQmpM9pWQHba055UEa 9cvjcgubnCuSp/V0uouf0xLrM6SKK9g= X-Google-Smtp-Source: AHgI3IamznEOKT536QLRp6aS6X1MVC/07T2CIyOix7+YuM4kX8E5d4P+i/jK0G5Ow3kN0CSK7agH+w== X-Received: by 2002:a5d:5285:: with SMTP id c5mr4372996wrv.167.1550189393905; Thu, 14 Feb 2019 16:09:53 -0800 (PST) Received: from [192.168.0.10] (gge44-1-78-198-200-53.fbx.proxad.net. [78.198.200.53]) by smtp.googlemail.com with ESMTPSA id g10sm7747120wrq.81.2019.02.14.16.09.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 16:09:53 -0800 (PST) From: Pete Batard To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , edk2-devel@lists.01.org References: <20190204124736.124-1-pete@akeo.ie> <20190204124736.124-2-pete@akeo.ie> <7d4d118b-a91b-6b45-44e4-41a04bd516d1@redhat.com> Message-ID: <08a473b6-49dd-3a0f-12f6-cd6e8f4a8fa9@akeo.ie> Date: Fri, 15 Feb 2019 01:09:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <7d4d118b-a91b-6b45-44e4-41a04bd516d1@redhat.com> Subject: Re: [PATCH 1/1] EmbeddedPkg/Library: Add VirtualRealTimeClockLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 X-List-Received-Date: Fri, 15 Feb 2019 00:09:57 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Hi Philippe, Thanks fort reviewing this patch, and apologies for the late reply. On 2019-02-05 20:57, Philippe Mathieu-Daudé wrote: > Hi Pete, > > On 2/4/19 1:47 PM, Pete Batard wrote: >> This is designed to be used on platforms where a a real RTC is not >> available and relies on an RtcEpochSeconds variable having been set or, >> if that is not the case, falls back to using the epoch embedded at >> compilation time. >> >> Note that, in order to keep things simple for the setting of the >> compilation time variable, only GCC environments with UNIX-like shells >> and where a 'date' command is available are meant to be supported for >> now. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Pete Batard >> --- >> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 400 ++++++++++++++++++++ >> EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf | 43 +++ >> 2 files changed, 443 insertions(+) >> >> diff --git a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c >> new file mode 100644 >> index 000000000000..4c354730d02b >> --- /dev/null >> +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c >> @@ -0,0 +1,400 @@ >> +/** @file >> + * >> + * Implement virtual EFI RealTimeClock runtime services. >> + * >> + * Coypright (c) 2019, Pete Batard >> + * Copyright (c) 2018, Andrei Warkentin >> + * Copyright (c) 2011-2014, ARM Ltd. All rights reserved. >> + * Copyright (c) 2008-2010, Apple Inc. All rights reserved. >> + * Copyright (c) Microsoft Corporation. All rights reserved. >> + * >> + * This program and the accompanying materials >> + * are licensed and made available under the terms and conditions of the BSD License >> + * which accompanies this distribution. The full text of the license may be found at >> + * http://opensource.org/licenses/bsd-license.php >> + * >> + * THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> + * WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> + * >> + * Based on ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.inf >> + * >> + **/ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +STATIC CONST CHAR16 mEpochVariableName[] = L"RtcEpochSeconds"; >> +STATIC CONST CHAR16 mTimeZoneVariableName[] = L"RtcTimeZone"; >> +STATIC CONST CHAR16 mDaylightVariableName[] = L"RtcDaylight"; >> + >> +/** >> + Returns the current time and date information, and the time-keeping capabilities >> + of the virtual RTC. >> + >> + @param Time A pointer to storage to receive a snapshot of the current time. >> + @param Capabilities An optional pointer to a buffer to receive the real time clock >> + device's capabilities. >> + >> + @retval EFI_SUCCESS The operation completed successfully. >> + @retval EFI_INVALID_PARAMETER Time is NULL. >> + @retval EFI_DEVICE_ERROR The time could not be retrieved due to hardware error. >> + >> +**/ >> +EFI_STATUS >> +EFIAPI >> +LibGetTime ( >> + OUT EFI_TIME *Time, >> + OUT EFI_TIME_CAPABILITIES *Capabilities >> + ) >> +{ >> + EFI_STATUS Status; >> + UINT32 EpochSeconds; >> + INT16 TimeZone; >> + UINT8 Daylight; >> + UINT64 Freq; >> + UINT64 Counter; >> + UINT64 Remainder; >> + UINTN ElapsedSeconds; >> + UINTN Size; >> + >> + if (Time == NULL) { >> + return EFI_INVALID_PARAMETER; >> + } >> + >> + // Get the counter frequency >> + Freq = GetPerformanceCounterProperties (NULL, NULL); >> + if (Freq == 0) { >> + return EFI_DEVICE_ERROR; >> + } >> + >> + // Get the epoch time from non-volatile storage >> + Size = sizeof (UINTN); >> + ElapsedSeconds = 0; >> + Status = EfiGetVariable ( >> + (CHAR16 *)mEpochVariableName, >> + &gEfiCallerIdGuid, >> + NULL, >> + &Size, >> + (VOID *)&ElapsedSeconds >> + ); >> + // Fall back to compilation-time epoch if not set >> + if (EFI_ERROR (Status)) { >> + ASSERT(Status != EFI_INVALID_PARAMETER); >> + ASSERT(Status != EFI_BUFFER_TOO_SMALL); >> + // >> + // The following is intended to produce a compilation error on build >> + // environments where BUILD_EPOCH can not be set from inline shell. >> + // If you are attempting to use this library on such an environment, please >> + // contact the edk2 mailing list, so we can try to add support for it. >> + // > > What about: > > #ifndef BUILD_EPOCH > #define BUILD_EPOCH 1549396000 /* As of this commit */ > #endif Well, the plan is to see what we can actually do for platforms that can't define BUILD_EPOCH to the actual compilation time through shell invocation. Rather than assume that we won't be able to do anything for those, and therefore default to an epoch that would have a very large offset even when the user went the trouble of recompiling the firmware, I'd rather we get a better idea of the environments this might apply to, and see if there's anything that could be achieved there. Of course, if there are other people here that support your suggestion, I don't have much of an objection to fall back to a static BUILD_EPOCH instead. >> + ElapsedSeconds = BUILD_EPOCH; >> + DEBUG (( >> + DEBUG_INFO, >> + "LibGetTime: %s non volatile variable was not found - Using compilation time epoch.\n", >> + mEpochVariableName >> + )); >> + } >> + Counter = GetPerformanceCounter (); >> + ElapsedSeconds += DivU64x64Remainder (Counter, Freq, &Remainder); >> + >> + // Get the current time zone information from non-volatile storage >> + Size = sizeof (TimeZone); >> + Status = EfiGetVariable ( >> + (CHAR16 *)mTimeZoneVariableName, >> + &gEfiCallerIdGuid, >> + NULL, >> + &Size, >> + (VOID *)&TimeZone >> + ); >> + >> + if (EFI_ERROR (Status)) { >> + ASSERT(Status != EFI_INVALID_PARAMETER); >> + ASSERT(Status != EFI_BUFFER_TOO_SMALL); >> + >> + if (Status != EFI_NOT_FOUND) { >> + return Status; >> + } >> + >> + // The time zone variable does not exist in non-volatile storage, so create it. >> + Time->TimeZone = EFI_UNSPECIFIED_TIMEZONE; >> + // Store it >> + Status = EfiSetVariable ( >> + (CHAR16 *)mTimeZoneVariableName, >> + &gEfiCallerIdGuid, >> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, >> + Size, >> + (VOID *)&(Time->TimeZone) >> + ); >> + if (EFI_ERROR (Status)) { >> + DEBUG (( >> + DEBUG_ERROR, >> + "LibGetTime: Failed to save %s variable to non-volatile storage, Status = %r\n", >> + mTimeZoneVariableName, >> + Status >> + )); >> + return Status; >> + } >> + } else { >> + // Got the time zone >> + Time->TimeZone = TimeZone; >> + >> + // Check TimeZone bounds: -1440 to 1440 or 2047 > > Since you use SEC_PER_HOUR, why not add MIN_PER_DAY? Mostly because I copy/pasted this part of the code straight from ArmPlatformPkg/Library/PL031RealTimeClockLib/ and they don't use that there. Likewise, if you or someone else feel this is an important change to have, I don't mind sending a v2, though it may be a week or two before I'm in a position to do that. Regards, /Pete >> + if (((Time->TimeZone < -1440) || (Time->TimeZone > 1440)) >> + && (Time->TimeZone != EFI_UNSPECIFIED_TIMEZONE)) { >> + Time->TimeZone = EFI_UNSPECIFIED_TIMEZONE; >> + } >> + >> + // Adjust for the correct time zone >> + if (Time->TimeZone != EFI_UNSPECIFIED_TIMEZONE) { >> + EpochSeconds += Time->TimeZone * SEC_PER_MIN; >> + } >> + } >> + >> + // Get the current daylight information from non-volatile storage >> + Size = sizeof (Daylight); >> + Status = EfiGetVariable ( >> + (CHAR16 *)mDaylightVariableName, >> + &gEfiCallerIdGuid, >> + NULL, >> + &Size, >> + (VOID *)&Daylight >> + ); >> + >> + if (EFI_ERROR (Status)) { >> + ASSERT(Status != EFI_INVALID_PARAMETER); >> + ASSERT(Status != EFI_BUFFER_TOO_SMALL); >> + >> + if (Status != EFI_NOT_FOUND) { >> + return Status; >> + } >> + >> + // The daylight variable does not exist in non-volatile storage, so create it. >> + Time->Daylight = 0; >> + // Store it >> + Status = EfiSetVariable ( >> + (CHAR16 *)mDaylightVariableName, >> + &gEfiCallerIdGuid, >> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, >> + Size, >> + (VOID *)&(Time->Daylight) >> + ); >> + if (EFI_ERROR (Status)) { >> + DEBUG (( >> + DEBUG_ERROR, >> + "LibGetTime: Failed to save %s variable to non-volatile storage, Status = %r\n", >> + mDaylightVariableName, >> + Status >> + )); >> + return Status; >> + } >> + } else { >> + // Got the daylight information >> + Time->Daylight = Daylight; >> + >> + // Adjust for the correct period >> + if ((Time->Daylight & EFI_TIME_IN_DAYLIGHT) == EFI_TIME_IN_DAYLIGHT) { >> + // Convert to adjusted time, i.e. spring forwards one hour >> + EpochSeconds += SEC_PER_HOUR; >> + } >> + } >> + >> + EpochToEfiTime (ElapsedSeconds, Time); >> + >> + // Because we use the performance counter, we can fill the Nanosecond attribute >> + // provided that the remainder doesn't overflow 64-bit during multiplication. >> + if (Remainder <= 18446744073U) { >> + Time->Nanosecond = MultU64x64 (Remainder, 1000000000U) / Freq; >> + } else { >> + DEBUG ((DEBUG_WARN, "LibGetTime: Nanosecond value not set (64-bit overflow).\n")); >> + } >> + >> + if (Capabilities) { >> + Capabilities->Accuracy = 0; >> + Capabilities->Resolution = Freq; >> + Capabilities->SetsToZero = FALSE; >> + } >> + >> + return EFI_SUCCESS; >> +} >> + >> +/** >> + Sets the current local time and date information. >> + >> + @param Time A pointer to the current time. >> + >> + @retval EFI_SUCCESS The operation completed successfully. >> + @retval EFI_INVALID_PARAMETER A time field is out of range. >> + @retval EFI_DEVICE_ERROR The time could not be set due due to hardware error. >> + >> +**/ >> +EFI_STATUS >> +EFIAPI >> +LibSetTime ( >> + IN EFI_TIME *Time >> + ) >> +{ >> + EFI_STATUS Status; >> + UINTN EpochSeconds; >> + >> + if (!IsTimeValid (Time)) { >> + return EFI_INVALID_PARAMETER; >> + } >> + >> + EpochSeconds = EfiTimeToEpoch (Time); >> + >> + // Adjust for the correct time zone, i.e. convert to UTC time zone >> + if (Time->TimeZone != EFI_UNSPECIFIED_TIMEZONE) { >> + EpochSeconds -= Time->TimeZone * SEC_PER_MIN; >> + } >> + >> + // Adjust for the correct period >> + if ((Time->Daylight & EFI_TIME_IN_DAYLIGHT) == EFI_TIME_IN_DAYLIGHT) { >> + // Convert to un-adjusted time, i.e. fall back one hour >> + EpochSeconds -= SEC_PER_HOUR; >> + } >> + >> + // Save the current time zone information into non-volatile storage >> + Status = EfiSetVariable ( >> + (CHAR16 *)mTimeZoneVariableName, >> + &gEfiCallerIdGuid, >> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, >> + sizeof (Time->TimeZone), >> + (VOID *)&(Time->TimeZone) >> + ); >> + if (EFI_ERROR (Status)) { >> + DEBUG (( >> + DEBUG_ERROR, >> + "LibSetTime: Failed to save %s variable to non-volatile storage, Status = %r\n", >> + mTimeZoneVariableName, >> + Status >> + )); >> + return Status; >> + } >> + >> + // Save the current daylight information into non-volatile storage >> + Status = EfiSetVariable ( >> + (CHAR16 *)mDaylightVariableName, >> + &gEfiCallerIdGuid, >> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, >> + sizeof(Time->Daylight), >> + (VOID *)&(Time->Daylight) >> + ); >> + if (EFI_ERROR (Status)) { >> + DEBUG (( >> + DEBUG_ERROR, >> + "LibSetTime: Failed to save %s variable to non-volatile storage, Status = %r\n", >> + mDaylightVariableName, >> + Status >> + )); >> + return Status; >> + } >> + >> + Status = EfiSetVariable ( >> + (CHAR16 *)mEpochVariableName, >> + &gEfiCallerIdGuid, >> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, >> + sizeof (EpochSeconds), >> + &EpochSeconds >> + ); >> + if (EFI_ERROR (Status)) { >> + DEBUG (( >> + DEBUG_ERROR, >> + "LibSetTime: Failed to save %s variable to non-volatile storage, Status = %r\n", >> + mDaylightVariableName, >> + Status >> + )); >> + return Status; >> + } >> + >> + return EFI_SUCCESS; >> +} >> + >> +/** >> + Returns the current wakeup alarm clock setting. >> + >> + @param Enabled Indicates if the alarm is currently enabled or disabled. >> + @param Pending Indicates if the alarm signal is pending and requires acknowledgement. >> + @param Time The current alarm setting. >> + >> + @retval EFI_SUCCESS The alarm settings were returned. >> + @retval EFI_INVALID_PARAMETER Any parameter is NULL. >> + @retval EFI_DEVICE_ERROR The wakeup time could not be retrieved due to a hardware error. >> + >> +**/ >> +EFI_STATUS >> +EFIAPI >> +LibGetWakeupTime ( >> + OUT BOOLEAN *Enabled, >> + OUT BOOLEAN *Pending, >> + OUT EFI_TIME *Time >> + ) >> +{ >> + return EFI_UNSUPPORTED; >> +} >> + >> +/** >> + Sets the system wakeup alarm clock time. >> + >> + @param Enabled Enable or disable the wakeup alarm. >> + @param Time If Enable is TRUE, the time to set the wakeup alarm for. >> + >> + @retval EFI_SUCCESS If Enable is TRUE, then the wakeup alarm was enabled. If >> + Enable is FALSE, then the wakeup alarm was disabled. >> + @retval EFI_INVALID_PARAMETER A time field is out of range. >> + @retval EFI_DEVICE_ERROR The wakeup time could not be set due to a hardware error. >> + @retval EFI_UNSUPPORTED A wakeup timer is not supported on this platform. >> + >> +**/ >> +EFI_STATUS >> +EFIAPI >> +LibSetWakeupTime ( >> + IN BOOLEAN Enabled, >> + OUT EFI_TIME *Time >> + ) >> +{ >> + return EFI_UNSUPPORTED; >> +} >> + >> +/** >> + This is the declaration of an EFI image entry point. This can be the entry point to an application >> + written to this specification, an EFI boot service driver, or an EFI runtime driver. >> + >> + @param ImageHandle Handle that identifies the loaded image. >> + @param SystemTable System Table for this image. >> + >> + @retval EFI_SUCCESS The operation completed successfully. >> + >> +**/ >> +EFI_STATUS >> +EFIAPI >> +LibRtcInitialize ( >> + IN EFI_HANDLE ImageHandle, >> + IN EFI_SYSTEM_TABLE *SystemTable >> + ) >> +{ >> + return EFI_SUCCESS; >> +} >> + >> +/** >> + Fixup internal data so that EFI can be call in virtual mode. >> + Call the passed in Child Notify event and convert any pointers in >> + lib to virtual mode. >> + >> + @param[in] Event The Event that is being processed >> + @param[in] Context Event Context >> +**/ >> +VOID >> +EFIAPI >> +LibRtcVirtualNotifyEvent ( >> + IN EFI_EVENT Event, >> + IN VOID *Context >> + ) >> +{ >> + return; >> +} >> diff --git a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf >> new file mode 100644 >> index 000000000000..ed69faad4205 >> --- /dev/null >> +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.inf >> @@ -0,0 +1,43 @@ >> +#/** @file >> +# >> +# Implement virtual EFI RealTimeClock runtime services. >> +# >> +# Copyright (c) 2019, Pete Batard >> +# Copyright (c) 2018, Andrei Warkentin >> +# Copyright (c) Microsoft Corporation. All rights reserved. >> +# >> +# This program and the accompanying materials >> +# are licensed and made available under the terms and conditions of the BSD License >> +# which accompanies this distribution. The full text of the license may be found at >> +# http://opensource.org/licenses/bsd-license.php >> +# >> +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, >> +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. >> +# >> +#**/ >> + >> +[Defines] >> + INF_VERSION = 0x0001001A >> + BASE_NAME = VirtualRealTimeClockLib >> + FILE_GUID = 1E27D461-78F3-4F7D-B1C2-F72384F13A6E >> + MODULE_TYPE = BASE >> + VERSION_STRING = 1.0 >> + LIBRARY_CLASS = RealTimeClockLib >> + >> +[Sources.common] >> + VirtualRealTimeClockLib.c >> + >> +[Packages] >> + MdePkg/MdePkg.dec >> + EmbeddedPkg/EmbeddedPkg.dec >> + >> +[LibraryClasses] >> + IoLib >> + DebugLib >> + TimerLib >> + TimeBaseLib >> + UefiRuntimeLib >> + >> +# Current usage of this library expects GCC in a UNIX-like shell environment with the date command >> +[BuildOptions] >> + GCC:*_*_*_CC_FLAGS = -DBUILD_EPOCH=`date +%s` >>