From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1E54B7803E4 for ; Wed, 11 Oct 2023 12:51:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Z0nbKdWmydesw30aIzZyM9+NRBwE2uaUXJg7B7XSPms=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697028677; v=1; b=UaNrU/7DzqalnqdzR8/qfpbDubpbp0YS5X2gPRHiFWG4CzWaXIhV74IdUkAxVhuVu93MVkIv gPt8qPUHWBY+lCyLBkt1q7SEDPkb7srPU56Fjmdcfb6DOP5WrcRupoq5rh68bgcYTCSzlmKGofZ a+5gdxdyEhamTEx+xVUHAYkg= X-Received: by 127.0.0.2 with SMTP id YVYFYY7687511xNDDZ1oLnkS; Wed, 11 Oct 2023 05:51:17 -0700 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.15658.1697028676620130389 for ; Wed, 11 Oct 2023 05:51:17 -0700 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E427C106F; Wed, 11 Oct 2023 05:51:56 -0700 (PDT) X-Received: from [192.168.1.13] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8AC7B3F5A1; Wed, 11 Oct 2023 05:51:15 -0700 (PDT) Message-ID: <08a562db-c244-47af-b516-17e56b2106ab@arm.com> Date: Wed, 11 Oct 2023 14:51:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 2/2] DynamicTablesPkg/TableHelperLib: Enhance error handling To: Jeshua Smith , "devel@edk2.groups.io" Cc: "Sami.Mujawar@arm.com" References: <3883194c96ec01f32932c484d0a9f64abbad3f46.1696608794.git.jeshuas@nvidia.com> From: "PierreGondois" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: c3TkUICYOAqIvUxe4JzOuEwRx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="UaNrU/7D"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io SGkgSmVzaHVhLA0KDQpPbiAxMC8xMC8yMyAxNzo0MSwgSmVzaHVhIFNtaXRoIHdyb3RlOg0KPiAj MyBpcyBub3QgY3VycmVudGx5IHVzZWQgYnkgYW55IHB1Ymxpc2hlZCBjb2RlLiBJdCBpcyBhIGRl dmVsb3BtZW50IGFpZCwgd2hpY2ggdGhlIE9iamVjdFBhcnNlciBpdHNlbGYgc2VlbXMgdG8gYmUu DQo+IA0KPiBIZXJlJ3Mgd2h5IEkgYWRkZWQgaXQuIFNldmVyYWwgcGVvcGxlIG9uIG91ciB0ZWFt IGhhdmUgKG5vdCB5ZXQgdXBzdHJlYW1lZCkgY2hhbmdlcyB0aGF0IHJlc3VsdGVkIGluIGFkZGl0 aW9uYWwgT2JqZWN0SURzIGJlaW5nIGFkZGVkIHRvIHRoZSBPYmplY3RJRCBlbnVtcywgYnV0IHdp dGhvdXQgY29ycmVzcG9uZGluZyBwYXJzZXJzIGJlaW5nIGFkZGVkIHRvIHRoZSBPYmplY3RQYXJz ZXIuIER1bXBpbmcgb2YgdGhlIG9iamVjdHMgd2l0aCB0aGUgT2JqZWN0UGFyc2VyIHdhc24ndCBl bmFibGVkIGJ5IGRlZmF1bHQsIHNvIHRoaXMgd2Fzbid0IGRldGVjdGVkIGJ5IHRoZW0uIFdpdGhv dXQgIzEgdGhlIE9iamVjdFBhcnNlciBjb2RlIGRvZXMgb3V0IG9mIGJvdW5kcyBhcnJheSBhY2Nl c3Nlcywgc29tZXRpbWVzIGxlYWRpbmcgdG8gY3Jhc2hlcy4gIzEgd2lsbCBub3cgZGV0ZWN0IGFu ZCByZXBvcnQgdGhhdCBwcm9ibGVtLiBXaGVuIEkgZW5hYmxlZCBkdW1waW5nIG9mIG9iamVjdHMg dG8gZGVidWcgbXkgbmV3IGNvZGUsIEkgaGl0IHRoaXMgYnVnIGxlYWRpbmcgbWUgdG8gd3JpdGUg IzEuIEZvciBtZSB0byB3b3JrIGFyb3VuZCB0aGUgaXNzdWUgb2YgbWlzc2luZyBwYXJzZXJzIGlu IG9yZGVyIHRvIGJlIGFibGUgdG8gY29udGludWUgZGVidWcgd2l0aCBteSB3b3JrLCB0aGUgImVh c3kiIHNvbHV0aW9uIHdhcyBmb3IgbWUgdG8gdGVtcG9yYXJpbHkgYWRkIHRoZSBuZXcgT2JqZWN0 SURzIHRvIHRoZSBwYXJzZXIgbGlzdCB3aXRoIE5VTEwgcGFyc2VycyBhbmQgdGhlbiBpbmZvcm0g dGhlIHJlc3BvbnNpYmxlIHBhcnRpZXMgdGhhdCB0aGV5IG5lZWQgdG8gZ28gYW5kIGFkZCBwYXJz ZXJzIGZvciB0aGVpciBuZXcgT2JqZWN0SURzLiBEb2luZyB0aGlzIHJlcXVpcmVkICMzIChzdXBw b3J0IGZvciBOVUxMIHBhcnNlcnMpIHRvIGJlIGFkZGVkLiBJZGVhbGx5IGFueSBjb2RlIHRoYXQg aXMgdXBzdHJlYW1lZCBiYWNrIHRvIEVES0lJIHdpbGwgaGF2ZSBub24tTlVMTCBwYXJzZXJzIGF0 IHRoZSBwb2ludCBpdCBpcyBzZW50IHVwc3RyZWFtLCBidXQgYWxsb3dpbmcgaW4tZGV2ZWxvcG1l bnQgY2hhbmdlcyB0byB0ZW1wb3JhcmlseSB1c2UgTlVMTCBwYXJzZXJzIGlzIGhlbHBmdWwuDQo+ IA0KPiBIb3BlZnVsbHkgdGhhdCBjbGFyaWZpZXMgdGhpbmdzLg0KDQpUaGFua3MgZm9yIHRoZSBk ZXRhaWxlZCBleHBsYW5hdGlvbiwNClJldmlld2VkLWJ5OiBQaWVycmUgR29uZG9pcyA8cGllcnJl LmdvbmRvaXNAYXJtLmNvbT4NCg0KPiANCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g RnJvbTogUGllcnJlIEdvbmRvaXMgPHBpZXJyZS5nb25kb2lzQGFybS5jb20+DQo+IFNlbnQ6IFR1 ZXNkYXksIE9jdG9iZXIgMTAsIDIwMjMgNDoxNCBBTQ0KPiBUbzogSmVzaHVhIFNtaXRoIDxqZXNo dWFzQG52aWRpYS5jb20+OyBkZXZlbEBlZGsyLmdyb3Vwcy5pbw0KPiBDYzogU2FtaS5NdWphd2Fy QGFybS5jb20NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAyLzJdIER5bmFtaWNUYWJsZXNQa2cvVGFi bGVIZWxwZXJMaWI6IEVuaGFuY2UgZXJyb3IgaGFuZGxpbmcNCj4gDQo+IEV4dGVybmFsIGVtYWls OiBVc2UgY2F1dGlvbiBvcGVuaW5nIGxpbmtzIG9yIGF0dGFjaG1lbnRzDQo+IA0KPiANCj4gSGVs bG8gSmVzaHVhLA0KPiANCj4gT24gMTAvNi8yMyAxODoyOCwgSmVzaHVhIFNtaXRoIHdyb3RlOg0K Pj4gVGhpcyBwYXRjaCBlbmhhbmNlcyBlcnJvciBoYW5kbGluZyBhbmQgcmVwb3J0aW5nIGluIHRo ZSBDTSBPYmplY3RQYXJzZXIuDQo+PiBTcGVjaWZpY2FsbHk6DQo+PiAxLiBPYmplY3RJRHMgdXNl ZCBhcyBhcnJheSBpbmRleGVzIGFyZSBjaGVja2VkIGZvciBiZWluZyBvdXQgb2YgYm91bmRzLA0K Pj4gICAgICBhbmQgaWYgc28gYW4gZXJyb3IgbWVzc2FnZSBpcyBwcmludGVkIGJlZm9yZSB0aGUg YXNzZXJ0Lg0KPj4gMi4gQW4gZXJyb3IgbWVzc2FnZSBpcyBwcmludGVkIGZvciB1bnN1cHBvcnRl ZCBOYW1lU3BhY2VJRHMuDQo+PiAzLiBBZGRzIHN1cHBvcnQgZm9yIHVuaW1wbGVtZW50ZWQgcGFy c2VycyBieSBhbGxvd2luZyBJRHMgdG8gbGlzdCBhDQo+PiAgICAgIE5VTEwgcGFyc2VyLCByZXN1 bHRpbmcgaW4gYW4gdW5pbXBsZW1lbnRlZCBtZXNzYWdlIGJlaW5nIHByaW50ZWQuDQo+IA0KPiBJ IGFtIG5vdCBzdXJlIEkgc2VlIGluIHdoaWNoIGNvbnRleHQgMy4gd291bGQgYmUgdXNlZC9uZWNl c3NhcnkuIElzIGl0IHBvc3NpYmxlIHRvIGRldGFpbCA/DQo+IA0KPiAoQ29kZS13aXNlIGV2ZXJ5 dGhpbmcgbG9va3MgZ29vZCB0byBtZSkNCj4gDQo+IFJlZ2FyZHMsDQo+IFBpZXJyZQ0KPiANCj4g DQo+Pg0KPj4gU2lnbmVkLW9mZi1ieTogSmVzaHVhIFNtaXRoIDxqZXNodWFzQG52aWRpYS5jb20+ DQo+PiAtLS0NCj4+ICAgIC4uLi9Db25maWd1cmF0aW9uTWFuYWdlck9iamVjdFBhcnNlci5jICAg ICAgICB8IDQ3ICsrKysrKysrKysrKystLS0tLS0NCj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAzMyBp bnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkNCj4+DQo+PiBkaWZmIC0tZ2l0DQo+PiBhL0R5 bmFtaWNUYWJsZXNQa2cvTGlicmFyeS9Db21tb24vVGFibGVIZWxwZXJMaWIvQ29uZmlndXJhdGlv bk1hbmFnZXJPDQo+PiBiamVjdFBhcnNlci5jDQo+PiBiL0R5bmFtaWNUYWJsZXNQa2cvTGlicmFy eS9Db21tb24vVGFibGVIZWxwZXJMaWIvQ29uZmlndXJhdGlvbk1hbmFnZXJPDQo+PiBiamVjdFBh cnNlci5jDQo+PiBpbmRleCA5MmRmMWVmZWU4Li4yMmI4ZmRiOTA2IDEwMDY0NA0KPj4gLS0tDQo+ PiBhL0R5bmFtaWNUYWJsZXNQa2cvTGlicmFyeS9Db21tb24vVGFibGVIZWxwZXJMaWIvQ29uZmln dXJhdGlvbk1hbmFnZXJPDQo+PiBiamVjdFBhcnNlci5jDQo+PiArKysgYi9EeW5hbWljVGFibGVz UGtnL0xpYnJhcnkvQ29tbW9uL1RhYmxlSGVscGVyTGliL0NvbmZpZ3VyYXRpb25NYW5hDQo+PiAr KysgZ2VyT2JqZWN0UGFyc2VyLmMNCj4+IEBAIC03OTUsNiArNzk1LDcgQEAgU1RBVElDIENPTlNU IENNX09CSl9QQVJTRVJfQVJSQVkgIFN0ZE5hbWVzcGFjZU9iamVjdFBhcnNlcltdID0gew0KPj4g ICAgICAgIEFSUkFZX1NJWkUgKFN0ZE9iakFjcGlUYWJsZUluZm9QYXJzZXIpIH0sDQo+PiAgICAg IHsgIkVTdGRPYmpTbWJpb3NUYWJsZUxpc3QiLCBTdGRPYmpTbWJpb3NUYWJsZUluZm9QYXJzZXIs DQo+PiAgICAgICAgQVJSQVlfU0laRSAoU3RkT2JqU21iaW9zVGFibGVJbmZvUGFyc2VyKSB9LA0K Pj4gKyAgeyAiRVN0ZE9iak1heCIsICAgICAgICAgICAgIE5VTEwsICAgICAgICAgICAgICAgICAg ICAgICAwfQ0KPj4gICAgfTsNCj4+DQo+PiAgICAvKiogUHJpbnQgc3RyaW5nIGRhdGEuDQo+PiBA QCAtMTA2Niw2ICsxMDY3LDEyIEBAIFBhcnNlQ21PYmpEZXNjICgNCj4+ICAgICAgICAgICAgcmV0 dXJuOw0KPj4gICAgICAgICAgfQ0KPj4NCj4+ICsgICAgICBpZiAoT2JqSWQgPj0gQVJSQVlfU0la RSAoU3RkTmFtZXNwYWNlT2JqZWN0UGFyc2VyKSkgew0KPj4gKyAgICAgICAgREVCVUcgKChERUJV R19FUlJPUiwgIk9iaklkIDB4JXggaXMgbWlzc2luZyBmcm9tIHRoZSBTdGROYW1lc3BhY2VPYmpl Y3RQYXJzZXIgYXJyYXlcbiIsIE9iaklkKSk7DQo+PiArICAgICAgICBBU1NFUlQgKDApOw0KPj4g KyAgICAgICAgcmV0dXJuOw0KPj4gKyAgICAgIH0NCj4+ICsNCj4+ICAgICAgICAgIFBhcnNlckFy cmF5ID0gJlN0ZE5hbWVzcGFjZU9iamVjdFBhcnNlcltPYmpJZF07DQo+PiAgICAgICAgICBicmVh azsNCj4+ICAgICAgICBjYXNlIEVPYmpOYW1lU3BhY2VBcm06DQo+PiBAQCAtMTA3NCwxMCArMTA4 MSwxNyBAQCBQYXJzZUNtT2JqRGVzYyAoDQo+PiAgICAgICAgICAgIHJldHVybjsNCj4+ICAgICAg ICAgIH0NCj4+DQo+PiArICAgICAgaWYgKE9iaklkID49IEFSUkFZX1NJWkUgKEFybU5hbWVzcGFj ZU9iamVjdFBhcnNlcikpIHsNCj4+ICsgICAgICAgIERFQlVHICgoREVCVUdfRVJST1IsICJPYmpJ ZCAweCV4IGlzIG1pc3NpbmcgZnJvbSB0aGUgQXJtTmFtZXNwYWNlT2JqZWN0UGFyc2VyIGFycmF5 XG4iLCBPYmpJZCkpOw0KPj4gKyAgICAgICAgQVNTRVJUICgwKTsNCj4+ICsgICAgICAgIHJldHVy bjsNCj4+ICsgICAgICB9DQo+PiArDQo+PiAgICAgICAgICBQYXJzZXJBcnJheSA9ICZBcm1OYW1l c3BhY2VPYmplY3RQYXJzZXJbT2JqSWRdOw0KPj4gICAgICAgICAgYnJlYWs7DQo+PiAgICAgICAg ZGVmYXVsdDoNCj4+ICAgICAgICAgIC8vIE5vdCBzdXBwb3J0ZWQNCj4+ICsgICAgICBERUJVRyAo KERFQlVHX0VSUk9SLCAiTmFtZVNwYWNlSWQgMHgleCwgT2JqSWQgMHgleCBpcyBub3QNCj4+ICsg c3VwcG9ydGVkIGJ5IHRoZSBwYXJzZXJcbiIsIE5hbWVTcGFjZUlkLCBPYmpJZCkpOw0KPj4gICAg ICAgICAgQVNTRVJUICgwKTsNCj4+ICAgICAgICAgIHJldHVybjsNCj4+ICAgICAgfSAvLyBzd2l0 Y2gNCj4+IEBAIC0xMDk1LDIxICsxMTA5LDI2IEBAIFBhcnNlQ21PYmpEZXNjICgNCj4+ICAgICAg ICAgIE9iakluZGV4ICsgMSwNCj4+ICAgICAgICAgIE9iamVjdENvdW50DQo+PiAgICAgICAgICAp KTsNCj4+IC0gICAgUHJpbnRDbU9iakRlc2MgKA0KPj4gLSAgICAgIChWT0lEICopKChVSU5UTilD bU9iakRlc2MtPkRhdGEgKyBPZmZzZXQpLA0KPj4gLSAgICAgIFBhcnNlckFycmF5LT5QYXJzZXIs DQo+PiAtICAgICAgUGFyc2VyQXJyYXktPkl0ZW1Db3VudCwNCj4+IC0gICAgICAmUmVtYWluaW5n U2l6ZSwNCj4+IC0gICAgICAxDQo+PiAtICAgICAgKTsNCj4+IC0gICAgaWYgKChSZW1haW5pbmdT aXplID4gQ21PYmpEZXNjLT5TaXplKSB8fA0KPj4gLSAgICAgICAgKFJlbWFpbmluZ1NpemUgPCAw KSkNCj4+IC0gICAgew0KPj4gLSAgICAgIEFTU0VSVCAoMCk7DQo+PiAtICAgICAgcmV0dXJuOw0K Pj4gLSAgICB9DQo+PiArICAgIGlmIChQYXJzZXJBcnJheS0+UGFyc2VyID09IE5VTEwpIHsNCj4+ ICsgICAgICBERUJVRyAoKERFQlVHX0VSUk9SLCAiUGFyc2VyIG5vdCBpbXBsZW1lbnRlZFxuIikp Ow0KPj4gKyAgICAgIFJlbWFpbmluZ1NpemUgPSAwOw0KPj4gKyAgICB9IGVsc2Ugew0KPj4gKyAg ICAgIFByaW50Q21PYmpEZXNjICgNCj4+ICsgICAgICAgIChWT0lEICopKChVSU5UTilDbU9iakRl c2MtPkRhdGEgKyBPZmZzZXQpLA0KPj4gKyAgICAgICAgUGFyc2VyQXJyYXktPlBhcnNlciwNCj4+ ICsgICAgICAgIFBhcnNlckFycmF5LT5JdGVtQ291bnQsDQo+PiArICAgICAgICAmUmVtYWluaW5n U2l6ZSwNCj4+ICsgICAgICAgIDENCj4+ICsgICAgICAgICk7DQo+PiArICAgICAgaWYgKChSZW1h aW5pbmdTaXplID4gQ21PYmpEZXNjLT5TaXplKSB8fA0KPj4gKyAgICAgICAgICAoUmVtYWluaW5n U2l6ZSA8IDApKQ0KPj4gKyAgICAgIHsNCj4+ICsgICAgICAgIEFTU0VSVCAoMCk7DQo+PiArICAg ICAgICByZXR1cm47DQo+PiArICAgICAgfQ0KPj4NCj4+IC0gICAgT2Zmc2V0ID0gQ21PYmpEZXNj LT5TaXplIC0gUmVtYWluaW5nU2l6ZTsNCj4+ICsgICAgICBPZmZzZXQgPSBDbU9iakRlc2MtPlNp emUgLSBSZW1haW5pbmdTaXplOw0KPj4gKyAgICB9DQo+PiAgICAgIH0gLy8gZm9yDQo+Pg0KPj4g ICAgICBBU1NFUlQgKFJlbWFpbmluZ1NpemUgPT0gMCk7DQoNCgotPS09LT0tPS09LT0tPS09LT0t PS09LQpHcm91cHMuaW8gTGlua3M6IFlvdSByZWNlaXZlIGFsbCBtZXNzYWdlcyBzZW50IHRvIHRo aXMgZ3JvdXAuClZpZXcvUmVwbHkgT25saW5lICgjMTA5NTI0KTogaHR0cHM6Ly9lZGsyLmdyb3Vw cy5pby9nL2RldmVsL21lc3NhZ2UvMTA5NTI0Ck11dGUgVGhpcyBUb3BpYzogaHR0cHM6Ly9ncm91 cHMuaW8vbXQvMTAxODAxMzg1Lzc2ODYxNzYKR3JvdXAgT3duZXI6IGRldmVsK293bmVyQGVkazIu Z3JvdXBzLmlvClVuc3Vic2NyaWJlOiBodHRwczovL2VkazIuZ3JvdXBzLmlvL2cvZGV2ZWwvdW5z dWIgW3JlYmVjY2FAb3BlbmZ3LmlvXQotPS09LT0tPS09LT0tPS09LT0tPS09LQoKDQo=