Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg: Add QemuFwCfgLibNull

["Laszlo Ersek" <lersek@redhat.com>]

On 05/04/20 13:45, Philippe Mathieu-Daudé wrote:
> On 5/4/20 1:09 AM, Rebecca Cran wrote:
>> Add a null implementation library for QemuFwCfgLib, in order to
>> support building PciHostBridgeLib for bhyve.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>> I think I've addressed all previous review feedback this time.
>>
>>   .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf |  30 +++
>>   OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c  | 209 ++++++++++++++++++
>>   2 files changed, 239 insertions(+)
>>   create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf
>>   create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c
> 
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

github.com pull request: https://github.com/tianocore/edk2/pull/578

commit: 245bdd2cb94beef807ff12263b6060d6fdb40c9a

Thanks,
Laszlo