From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.1701.1588698207728956876 for ; Tue, 05 May 2020 10:03:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=REh73w3A; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588698206; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hWu0qfWR7cpaoDhWZmTk+cK3EBa7+eXCX8gz0tnRrO0=; b=REh73w3AMVfWQ9tdKDJpHjlMn+xcjykjL0kgOom7EIBKIEhFwUcgv3rk/lO1cTI/lNz6P8 iW2jbzK+GSBuCyWYN5PDgf5VfPqQZjWCIEGOipyfdyQYxeQuRytWhisbGKviXzz3IxXOl7 JiF50HPWZl9FrxDII7uDWwL+xGI1Ceg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-TMZNQxXbPKaAHmWCDQ-Trg-1; Tue, 05 May 2020 13:03:06 -0400 X-MC-Unique: TMZNQxXbPKaAHmWCDQ-Trg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C529C100A8E8; Tue, 5 May 2020 17:03:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-134.ams2.redhat.com [10.36.114.134]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8A7A763F90; Tue, 5 May 2020 17:03:03 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v3 1/1] OvmfPkg: Add QemuFwCfgLibNull To: devel@edk2.groups.io, philmd@redhat.com, Rebecca Cran Cc: Jordan Justen , Ard Biesheuvel References: <20200503230910.26783-1-rebecca@bsdio.com> <6ae108da-a543-58d0-6b3c-3be6f07ce22f@redhat.com> From: "Laszlo Ersek" Message-ID: <08b9fca7-9811-1b8e-4e1f-06ed290e04f7@redhat.com> Date: Tue, 5 May 2020 19:03:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6ae108da-a543-58d0-6b3c-3be6f07ce22f@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 05/04/20 13:45, Philippe Mathieu-Daud=C3=A9 wrote: > On 5/4/20 1:09 AM, Rebecca Cran wrote: >> Add a null implementation library for QemuFwCfgLib, in order to >> support building PciHostBridgeLib for bhyve. >> >> Signed-off-by: Rebecca Cran >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Philippe Mathieu-Daud=C3=A9 >> --- >> I think I've addressed all previous review feedback this time. >> >> =C2=A0 .../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf |=C2=A0 30 +++ >> =C2=A0 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c=C2=A0 | 209 ++++++++= ++++++++++ >> =C2=A0 2 files changed, 239 insertions(+) >> =C2=A0 create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.= inf >> =C2=A0 create mode 100644 OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNull.c >=20 > Reviewed-by: Philippe Mathieu-Daude Reviewed-by: Laszlo Ersek github.com pull request: https://github.com/tianocore/edk2/pull/578 commit: 245bdd2cb94beef807ff12263b6060d6fdb40c9a Thanks, Laszlo