From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A9A1A81C65 for ; Wed, 23 Nov 2016 06:55:15 -0800 (PST) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1C3A04E34E; Wed, 23 Nov 2016 14:55:15 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-97.phx2.redhat.com [10.3.116.97]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uANEtCDr025841; Wed, 23 Nov 2016 09:55:13 -0500 To: Konrad Rzeszutek Wilk , edk2-devel@ml01.01.org References: <9faa1698-7471-3f47-e552-8da23c0f0195@redhat.com> <20161123023643.7106-1-konrad@kernel.org> <20161123023643.7106-2-konrad@kernel.org> Cc: xen-devel@lists.xenproject.org From: Laszlo Ersek Message-ID: <08c65777-c4e2-148a-f7a4-408b46aafdcd@redhat.com> Date: Wed, 23 Nov 2016 15:55:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.0 MIME-Version: 1.0 In-Reply-To: <20161123023643.7106-2-konrad@kernel.org> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 23 Nov 2016 14:55:15 +0000 (UTC) Subject: Re: [PATCH v2] OvmfPkg/build.sh: Make GCC5 the default toolchain, catch GCC43 and earlier X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Nov 2016 14:55:15 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/23/16 03:36, Konrad Rzeszutek Wilk wrote: > From Laszlo: > " change the catch-all (*) to GCC5, from GCC44 > - remove the (5.*.*) pattern from GCC49 > - add a branch (with multiple patterns if necessary) for gcc-4.3 and > earlier to exit with an error message / failure (those compiler > versions are unsupported)" > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Konrad Rzeszutek Wilk > --- > v1: First submission > v2: Redo it per Laszlo suggestion. > > OvmfPkg/build.sh | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh > index eb5eb73..cab7c70 100755 > --- a/OvmfPkg/build.sh > +++ b/OvmfPkg/build.sh > @@ -83,6 +83,13 @@ case `uname` in > Linux*) > gcc_version=$(gcc -v 2>&1 | tail -1 | awk '{print $3}') > case $gcc_version in > + 4.1.[0-0].*|4.2.*|4.3.*) * The [0-0] bracketed expression will work as expected, but it's somewhat unusual :) Is it intentional? * If it's a typo, are you okay if I replace it with a plain 0 on commit? * Also, IIRC, Olaf considered pre-4.0 gcc releases as well (rejecting them of course), which is sort of meant as part of "gcc-4.3 and earlier". But, given your extensive testing with old distros (thanks for that!), I think it's safe to ignore pre-4.0 gcc releases altogether. Reviewed-by: Laszlo Ersek Thanks! Laszlo > + echo OvmfPkg requires GCC4.4 or later > + exit 1 > + ;; > + 4.4.*) > + TARGET_TOOLS=GCC44 > + ;; > 4.5.*) > TARGET_TOOLS=GCC45 > ;; > @@ -95,11 +102,11 @@ case `uname` in > 4.8.*) > TARGET_TOOLS=GCC48 > ;; > - 4.9.*|4.1[0-9].*|5.*.*) > + 4.9.*) > TARGET_TOOLS=GCC49 > ;; > *) > - TARGET_TOOLS=GCC44 > + TARGET_TOOLS=GCC5 > ;; > esac > esac >