From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2DCB821190734 for ; Thu, 15 Nov 2018 03:56:42 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 953C63082A23; Thu, 15 Nov 2018 11:56:41 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-130.rdu2.redhat.com [10.10.120.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2DBAF6148E; Thu, 15 Nov 2018 11:56:36 +0000 (UTC) From: Laszlo Ersek To: yuchenlin@synology.com Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , edk2-devel@lists.01.org, phil@philjordan.eu, jordan.l.justen@intel.com, anthony.perard@citrix.com References: <20181102032402.19686-1-yuchenlin@synology.com> Message-ID: <08cd6273-5c10-5251-8d50-a193298f82c8@redhat.com> Date: Thu, 15 Nov 2018 12:56:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Thu, 15 Nov 2018 11:56:41 +0000 (UTC) Subject: Re: [PATCH v2 0/5] OvmfPkg: simply use the Bochs interface for vmsvga X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 11:56:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11/12/18 16:40, Laszlo Ersek wrote: > On 11/12/18 15:16, Philippe Mathieu-Daudé wrote: >> On 2/11/18 4:23, yuchenlin@synology.com wrote: >>> From: yuchenlin >>> >>> In this series, replace the original vmsvga driver to Bochs >>> interface. >>> >>> Simply revert vmsvga driver implementation. After it, use Bochs >>> interface for initializing vmsvga. >>> >>> Because of the PCI BARs difference between std vga and vmsvga. >>> We can not simply recognize the "QEMU VMWare SVGA" as the >>> QEMU_VIDEO_BOCHS_MMIO variant. >>> >>> BAR  |    std vga     |  vmsvga >>> --------------------------------- >>> 0    |   Framebuffer  | I/O space >>> 1    |   Reserved     | Framebuffer >>> 2    |   MMIO         | FIFO >>> >>> To overcome this problem, we remain variant QEMU_VIDEO_VMWARE_SVGA, >>> and use it for: >>> >>> (1) Get framebuffer from correct PCI BAR >>> (2) Prevent using BAR2 for MMIO >>> >>> We have tested on qemu before and after commit 104bd1dc70 and all >>> worked. >>> >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: yuchenlin >>> >>> Changelog: >>> v1 -> v2 >>> * use 'else' clause (Thanks Philippe). >>> * add more comment in revert patches (Thanks Philippe). >>> * reorder the revert patches, we should revert the last commit first. >>> * use correct framebuffer to ClearScreen. >>> * revert VMWare svga definitions. >>> >>> yuchenlin (5): >>>    Revert "OvmfPkg/QemuVideoDxe: list "UnalignedIoInternal.h" in the INF >>>      file" >>>    Revert "OvmfPkg/QemuVideoDxe: VMWare SVGA device support" >>>    Revert "OvmfPkg/QemuVideoDxe: Helper functions for unaligned port >>>      I/O." >>>    Revert "OvmfPkg: VMWare SVGA display device register definitions" >>>    OvmfPkg: simply use the Bochs interface for vmsvga >> >> FWIW Patches 1-4: >> Reviewed-by: Philippe Mathieu-Daudé I could apply the first 4 patches now (commit 85588389222a has been tagged as "edk2-stable201811"); however, I'd prefer to push all 5 in one go: >> Patch 5 (not yet merged) is still on my TODO because I want to run >> detailed testing. > > Thanks for that too. :) Please remember to use the v3 posting for that: > > [edk2] [PATCH v3] OvmfPkg: simply use the Bochs interface for vmsvga > > (msgid: <20181107034713.24907-1-yuchenlin@synology.com>) with Phil's upcoming feedback attached to the last -- 5th -- patch too. Thanks Laszlo