From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 08 Aug 2019 13:06:41 -0700
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 3505D30A00C9;
	Thu,  8 Aug 2019 20:06:41 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-122.ams2.redhat.com [10.36.117.122])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 28FB810002BA;
	Thu,  8 Aug 2019 20:06:39 +0000 (UTC)
Subject: Re: [edk2-devel] [Patch v6 1/9] OvmfPkg/PlatformPei: Change referenced MSR name.
To: devel@edk2.groups.io, eric.dong@intel.com
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190808062500.26996-1-eric.dong@intel.com>
 <20190808062500.26996-2-eric.dong@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <08dea7b0-0f57-cb65-5e26-d79a0276a3ca@redhat.com>
Date: Thu, 8 Aug 2019 22:06:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190808062500.26996-2-eric.dong@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Thu, 08 Aug 2019 20:06:41 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 08/08/19 08:24, Dong, Eric wrote:
> Change referenced MSR name to avoid later build failure.
> 
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  OvmfPkg/PlatformPei/FeatureControl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/OvmfPkg/PlatformPei/FeatureControl.c b/OvmfPkg/PlatformPei/FeatureControl.c
> index 837da2119a..1a9d75022f 100644
> --- a/OvmfPkg/PlatformPei/FeatureControl.c
> +++ b/OvmfPkg/PlatformPei/FeatureControl.c
> @@ -11,7 +11,7 @@
>  #include <Library/PeiServicesLib.h>
>  #include <Library/QemuFwCfgLib.h>
>  #include <Ppi/MpServices.h>
> -#include <Register/Msr/Core2Msr.h>
> +#include <Register/ArchitecturalMsr.h>
>  
>  #include "Platform.h"
>  
> @@ -37,7 +37,7 @@ WriteFeatureControl (
>    IN OUT VOID *WorkSpace
>    )
>  {
> -  AsmWriteMsr64 (MSR_CORE2_FEATURE_CONTROL, mFeatureControlValue);
> +  AsmWriteMsr64 (MSR_IA32_FEATURE_CONTROL, mFeatureControlValue);
>  }
>  
>  /**
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>