From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web12.7520.1620991677893444905 for ; Fri, 14 May 2021 04:27:58 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gV4ZDFJm; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620991677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=snZptMMSA37wVlBTegaI4ALZFYCZYNWV8w870bgBk8o=; b=gV4ZDFJm+g/nV357iyxcKfrX8C4k8QbgADuBdoMXreSdNUge+6u/+5xP5ZZND/ftWAuHOe w7wLF5i4TgxKI8s+cjpgHYxw/NQpga9FgDT8PgeK10bZLj9ctZNrdWDXYf4YflE4YF4WXE ILmuA1mMwPERRbkXQslupCiiHoZgbMU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-wI5GbpAFOLSSv6_sfd2HwA-1; Fri, 14 May 2021 07:27:54 -0400 X-MC-Unique: wI5GbpAFOLSSv6_sfd2HwA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDA12107ACCA; Fri, 14 May 2021 11:27:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-190.ams2.redhat.com [10.36.112.190]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 404BE19C59; Fri, 14 May 2021 11:27:51 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array To: devel@edk2.groups.io, thomas.lendacky@amd.com Cc: Brijesh Singh , Allen Wynn , Eric Dong , Ray Ni , Rahul Kumar References: <40e55bf6563ed8ea4962a1219efbe1ab77a56cc4.1620919615.git.thomas.lendacky@amd.com> From: "Laszlo Ersek" Message-ID: <08f09c7a-f2c8-769d-c2e7-531044d9059c@redhat.com> Date: Fri, 14 May 2021 13:27:49 +0200 MIME-Version: 1.0 In-Reply-To: <40e55bf6563ed8ea4962a1219efbe1ab77a56cc4.1620919615.git.thomas.lendacky@amd.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/13/21 17:26, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3373 > > An update to expand the mExceptionNameStr array failed to add a comma > after original last entry, therefore causing the #CP name to have extra > incorrect characters and the remaining entries to be indexed incorrectly > (off by 1). > > Add a comma after the "#CP" entry to resolve this issue. > > Fixes: 5277540e37e88a1a69f9517c4ad895051b4b3ed3 > Cc: Allen Wynn > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Tom Lendacky > --- > UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c > index c9003b10e552..49d0041e2ff3 100644 > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c > @@ -44,7 +44,7 @@ CONST CHAR8 *mExceptionNameStr[] = { > "#MC - Machine-Check", > "#XM - SIMD floating-point", > "#VE - Virtualization", > - "#CP - Control Protection" > + "#CP - Control Protection", > "Reserved", > "Reserved", > "Reserved", > Merged as commit 32928415e36b, via . Thanks, Laszlo