* [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array
@ 2021-05-13 15:26 Lendacky, Thomas
2021-05-14 11:04 ` [edk2-devel] " Laszlo Ersek
2021-05-14 11:27 ` Laszlo Ersek
0 siblings, 2 replies; 3+ messages in thread
From: Lendacky, Thomas @ 2021-05-13 15:26 UTC (permalink / raw)
To: devel
Cc: Brijesh Singh, Allen Wynn, Eric Dong, Ray Ni, Laszlo Ersek,
Rahul Kumar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3373
An update to expand the mExceptionNameStr array failed to add a comma
after original last entry, therefore causing the #CP name to have extra
incorrect characters and the remaining entries to be indexed incorrectly
(off by 1).
Add a comma after the "#CP" entry to resolve this issue.
Fixes: 5277540e37e88a1a69f9517c4ad895051b4b3ed3
Cc: Allen Wynn <Allen_Wynn@Dell.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---
UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
index c9003b10e552..49d0041e2ff3 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
@@ -44,7 +44,7 @@ CONST CHAR8 *mExceptionNameStr[] = {
"#MC - Machine-Check",
"#XM - SIMD floating-point",
"#VE - Virtualization",
- "#CP - Control Protection"
+ "#CP - Control Protection",
"Reserved",
"Reserved",
"Reserved",
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array
2021-05-13 15:26 [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array Lendacky, Thomas
@ 2021-05-14 11:04 ` Laszlo Ersek
2021-05-14 11:27 ` Laszlo Ersek
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2021-05-14 11:04 UTC (permalink / raw)
To: devel, thomas.lendacky
Cc: Brijesh Singh, Allen Wynn, Eric Dong, Ray Ni, Rahul Kumar
On 05/13/21 17:26, Lendacky, Thomas wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3373
>
> An update to expand the mExceptionNameStr array failed to add a comma
> after original last entry, therefore causing the #CP name to have extra
> incorrect characters and the remaining entries to be indexed incorrectly
> (off by 1).
>
> Add a comma after the "#CP" entry to resolve this issue.
>
> Fixes: 5277540e37e88a1a69f9517c4ad895051b4b3ed3
> Cc: Allen Wynn <Allen_Wynn@Dell.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> index c9003b10e552..49d0041e2ff3 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> @@ -44,7 +44,7 @@ CONST CHAR8 *mExceptionNameStr[] = {
> "#MC - Machine-Check",
> "#XM - SIMD floating-point",
> "#VE - Virtualization",
> - "#CP - Control Protection"
> + "#CP - Control Protection",
> "Reserved",
> "Reserved",
> "Reserved",
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array
2021-05-13 15:26 [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array Lendacky, Thomas
2021-05-14 11:04 ` [edk2-devel] " Laszlo Ersek
@ 2021-05-14 11:27 ` Laszlo Ersek
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2021-05-14 11:27 UTC (permalink / raw)
To: devel, thomas.lendacky
Cc: Brijesh Singh, Allen Wynn, Eric Dong, Ray Ni, Rahul Kumar
On 05/13/21 17:26, Lendacky, Thomas wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3373
>
> An update to expand the mExceptionNameStr array failed to add a comma
> after original last entry, therefore causing the #CP name to have extra
> incorrect characters and the remaining entries to be indexed incorrectly
> (off by 1).
>
> Add a comma after the "#CP" entry to resolve this issue.
>
> Fixes: 5277540e37e88a1a69f9517c4ad895051b4b3ed3
> Cc: Allen Wynn <Allen_Wynn@Dell.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> index c9003b10e552..49d0041e2ff3 100644
> --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.c
> @@ -44,7 +44,7 @@ CONST CHAR8 *mExceptionNameStr[] = {
> "#MC - Machine-Check",
> "#XM - SIMD floating-point",
> "#VE - Virtualization",
> - "#CP - Control Protection"
> + "#CP - Control Protection",
> "Reserved",
> "Reserved",
> "Reserved",
>
Merged as commit 32928415e36b, via
<https://github.com/tianocore/edk2/pull/1644>.
Thanks,
Laszlo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-14 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-13 15:26 [PATCH] UefiCpuPkg/CpuExceptionHandler: Add missing comma to exception name array Lendacky, Thomas
2021-05-14 11:04 ` [edk2-devel] " Laszlo Ersek
2021-05-14 11:27 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox