From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=67.231.154.164; helo=dispatch1-us1.ppe-hosted.com; envelope-from=tpilar@solarflare.com; receiver=edk2-devel@lists.01.org Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 23C8F211B6C1A for ; Wed, 23 Jan 2019 08:27:09 -0800 (PST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 9443DB00056; Wed, 23 Jan 2019 16:27:08 +0000 (UTC) Received: from tp-desktop.uk.solarflarecom.com (10.17.20.51) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 23 Jan 2019 08:27:05 -0800 To: Laszlo Ersek CC: "edk2-devel@lists.01.org" References: <6029fb15-3820-0f05-f02a-577e99592bbc@solarflare.com> <32137552-e2b0-4392-17c7-dedaa1f05244@redhat.com> From: "Tomas Pilar (tpilar)" Message-ID: <09017041-d418-1186-9942-dfa70d82c4d6@solarflare.com> Date: Wed, 23 Jan 2019 16:27:03 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <32137552-e2b0-4392-17c7-dedaa1f05244@redhat.com> X-Originating-IP: [10.17.20.51] X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24384.005 X-TM-AS-Result: No-5.364700-4.000000-10 X-TMASE-MatchedRID: nVQUmLJJeyY4HKI/yaqRm7CvlllU7Dl1lnrMq7Sriu3JYIv7y0tu9gdG qbjrNQ4RGJHE/NlKoGTXZEBzupvbPA/mRvSsqYV7MN+B8zdlz9EhmbYg1ZcOnkuCjz4ggdtwIL+ j00cxUVqMERMH9KPeg6TyrujjaTKe2HzzjwqZ3wLpnOP6QxEGtn0tCKdnhB58vqq8s2MNhPCZMP CnTMzfOiq2rl3dzGQ1l3+bAt/YFVTgaiXl6Lq1GFHoHLwRd48JGHt5PLivhjSSyQrCMaroxrAUy Ug9ogFt X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.364700-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24384.005 X-MDID: 1548260829-xQUthAqlp2jH Subject: Re: Network Stack Budgeting X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 X-List-Received-Date: Wed, 23 Jan 2019 16:27:10 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US > The set of devices connected during BDS is platform policy. It is not > the "network stack" that calls Snp.Start(), but the platform BDS code > that calls gBS->ConnectController() on the device, possibly without a > good reason (e.g. without the device being present in a UEFI boot > option). The network stack only "reacts" to that connection request. Indeed, but even if a SNP handle is present as a boot option in a boot manager, surely the Snp.Start() should be deferred until the user actually chooses to boot from that handle. A workaround that we have in the legacy implementation doesn't start the underlying hardware datapath until the platform tries to send the first packet (since PXE boot is always initiated by the client) but that is a horrible hack that should not be necessary. The distinction between Snp.Initialize() and Snp.Start() is there exactly for that reason, no? In other words, ConnectController() should not immediately result in Snp.Start() being called. Cheers, Tom