From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.8451.1591885255681123473 for ; Thu, 11 Jun 2020 07:20:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZVE9yxaW; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591885254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hRoEiZ8Fjs63u/VCD3XToJhXO6UMF/Rq2yM9vO4Dw7I=; b=ZVE9yxaWsJVUtVDsAeggy6w2i1JZ7kHFgaEnSAs15fIs8gQlXNFGmfIYUce7GFj97L4S4m eG03EIH3qzp4Jr2PYyybqTSDBSyDb4VIh0C1+fxYBaf9DQ/A2m83amHyN/lpZJ6fkhGgk0 SDXK/Klri0ptcyQTw6kSjYtIh2yhUaw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-ALRcd9oYNriPjWQ9mjuVPw-1; Thu, 11 Jun 2020 10:20:37 -0400 X-MC-Unique: ALRcd9oYNriPjWQ9mjuVPw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB29B835B40; Thu, 11 Jun 2020 14:20:35 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-21.ams2.redhat.com [10.36.114.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id 43D6578914; Thu, 11 Jun 2020 14:20:33 +0000 (UTC) Subject: Re: [PATCH v9 09/46] OvmfPkg: Prepare OvmfPkg to use the VmgExitLib library To: Tom Lendacky , devel@edk2.groups.io Cc: Brijesh Singh , Ard Biesheuvel , Eric Dong , Jordan Justen , Liming Gao , Michael D Kinney , Ray Ni , Anthony Perard , Julien Grall References: <63aae4b9cc75486a3d4e60d5872172a02ea0aaed.1591363657.git.thomas.lendacky@amd.com> <3d3e5cd0-af7b-a100-a7d1-5278b98213f1@amd.com> From: "Laszlo Ersek" Message-ID: <090a0edd-645d-416c-fa3b-365528993d4d@redhat.com> Date: Thu, 11 Jun 2020 16:20:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <3d3e5cd0-af7b-a100-a7d1-5278b98213f1@amd.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 06/10/20 16:15, Tom Lendacky wrote: > On 6/10/20 7:08 AM, Laszlo Ersek wrote: >> Hi Tom, >> >> On 06/05/20 15:27, Tom Lendacky wrote: >>> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cae12d2d0f5c94ee905c708d80d3711e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637273877466672474&sdata=SNfXYJYwNPKmYyWq5xNrIY7PWSbBZkLNWIQ%2B2vtJk3c%3D&reserved=0 >>> >>> Various CpuExceptionHandlerLib libraries will updated to use the new >>> VmgExitLib library. To prevent any build breakage, update the OvmfPkg >>> DSC files that use a form of the CpuExceptionHandlerLib library to >>> include the VmgExitLib library. >>> >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Cc: Anthony Perard >>> Cc: Julien Grall >>> Reviewed-by: Laszlo Ersek >>> Signed-off-by: Tom Lendacky >>> --- >>> OvmfPkg/OvmfPkgIa32.dsc | 1 + >>> OvmfPkg/OvmfPkgIa32X64.dsc | 1 + >>> OvmfPkg/OvmfPkgX64.dsc | 1 + >>> OvmfPkg/OvmfXen.dsc | 1 + >>> 4 files changed, 4 insertions(+) >> >> not a code comment, but a process comment. >> >> I'm comparing this v9 series against v8, with git-range-diff. For the comparison, I'm using your "sev-es-v16" branch (v8 on the list) versus "sev-es-v17" (v9 on the list -- this series). >> >> For this patch, git-range-diff tells me: >> >> 9: 557f9c473fe6 ! 9: 63aae4b9cc75 OvmfPkg: Prepare OvmfPkg to use the VmgExitLib library >> @@ -11,7 +11,9 @@ >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> - Cc: Ard Biesheuvel >> + Cc: Ard Biesheuvel >> + Cc: Anthony Perard >> + Cc: Julien Grall >> Reviewed-by: Laszlo Ersek >> Signed-off-by: Tom Lendacky >> >> meaning that you updated the CC list from v8 to v9. >> >> That's OK, in itself. >> >> However, if I look at the actual v8 message on-list: >> >> https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmid.mail-archive.com%2F2fd73ece7e6cfc0212b31646f4ea4bae6f6d51a8.1589925074.git.thomas.lendacky%40amd.com&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cae12d2d0f5c94ee905c708d80d3711e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637273877466672474&sdata=qb6rUyivqq0kPKYUtGeTgcvlNUe8B8h7vKmeOZLvjK4%3D&reserved=0 >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fedk2.groups.io%2Fg%2Fdevel%2Fmessage%2F59865&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cae12d2d0f5c94ee905c708d80d3711e6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637273877466672474&sdata=mmZt3%2Fdc37OKtNaDoYGysZTut35BfKih0u3w2FrcFeI%3D&reserved=0 >> >> that shows that the v8 posting *already* included the longer CC list. >> >> The one explanation I can find for this is that you posted a different series with subject prefix "v8" than the one pushed as branch "sev-es-v16". Is that correct? > > Looks like I made some final changes to the CC lists after re-running the > get maintainers script and forgot to push that to github. Also missing > from github is the final patch with the change to the maintainers list. > > Code-wise, though, everything is identical. Good to know, thanks! > >> >> Please do not introduce any changes between the pushed and the posted versions. They must be *completely identical*. > > A miss on my end to do the final push to github before sending out the > patches. I can do a force push for the sev-es-v16 branch to match what was > submitted if that will help you (of course you'll have to reset your > branch if I do that), your call. Since the branch reference has been posted publicly, I would not recommend a force-push. I'm of the opinion that it's fine to force-push a branch multiple times in preparation for posting the series, but once it's been posted, the branch becomes (conceptually) read-only. (Plus, I've reached the end of the v9 series in the review.) Thanks! Laszlo