public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Brian J. Johnson" <brian.johnson@hpe.com>
To: devel@edk2.groups.io, lersek@redhat.com,
	Tom Lendacky <thomas.lendacky@amd.com>
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
	Rahul Kumar <rahul1.kumar@intel.com>,
	Brijesh Singh <brijesh.singh@amd.com>,
	Garrett Kirkendall <garrett.kirkendall@amd.com>
Subject: Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure
Date: Fri, 25 Sep 2020 11:09:58 -0500	[thread overview]
Message-ID: <091b5170-a56c-b1f8-0afe-86444df43e49@hpe.com> (raw)
In-Reply-To: <b59cdf21-2205-3df3-d246-e97b6c88f677@redhat.com>

On 9/24/20 1:22 AM, Laszlo Ersek wrote:
> - I don't remember if it's required that the APIC ID space be densely
> populated. For example, if we have a topology with 7 possible (=
> maximum) logical CPUs, I'm unsure if a spec forbids any of those CPUs
> from having APIC ID 7. That could cause a problem in
> MpInitLibSevEsAPReset(), I assume.

FWIW, there are many bare metal processors with non-contiguous APIC IDs. 
  Intel puts the socket ID in the upper bits of the APIC ID.  So if the 
socket doesn't have a power-of-two number of cores, there is always a 
gap.  Plus, the BSP doesn't always have APIC ID 0 -- it depends on which 
physical cores passed the manufacturing tests for that particular part. 
That has broken various kernels, BIOSes, and other software at times. 
So it's best not to make assumptions.

I don't know if that applies to VMs, though.  The standards may be 
different (if there are any standards at all in that area.)

-- 
Brian J. Johnson
Enterprise X86 Lab

Hewlett Packard Enterprise


  parent reply	other threads:[~2020-09-25 16:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 18:04 [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure Lendacky, Thomas
2020-09-24  6:22 ` Laszlo Ersek
2020-09-24 13:30   ` Lendacky, Thomas
2020-09-24 15:03     ` Laszlo Ersek
2020-10-02 16:42       ` Lendacky, Thomas
2020-10-19 15:02         ` Lendacky, Thomas
2020-10-19 21:51           ` Laszlo Ersek
2020-09-25 16:09   ` Brian J. Johnson [this message]
2020-09-25 16:52     ` [edk2-devel] " Lendacky, Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=091b5170-a56c-b1f8-0afe-86444df43e49@hpe.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox