From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 14 Aug 2019 08:30:24 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 132C48E597;
	Wed, 14 Aug 2019 15:30:24 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-158.ams2.redhat.com [10.36.116.158])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 360A78B171;
	Wed, 14 Aug 2019 15:30:23 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] MdePkg: Add STATIC_ASSERT macro
To: "vit9696@protonmail.com" <vit9696@protonmail.com>
References: <-7J-ox4uCTbcsET7h6qAoF8YW8JKIRBPlwK3qb9XdjOtKeSyj11dLzvgBSbPMsAw_lz4656nVS4owNAkaQ2GNOw-FeihwAY75H7kULLh4r0=@protonmail.com>
 <1044ab43-3a1c-bd03-c06c-471708ddb324@redhat.com>
 <45B1F80A-14DF-4300-BE67-FE408398DDEE@protonmail.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <092e84c1-b966-7fa3-f202-fb813172e840@redhat.com>
Date: Wed, 14 Aug 2019 17:30:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <45B1F80A-14DF-4300-BE67-FE408398DDEE@protonmail.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 14 Aug 2019 15:30:24 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

(adding back the list)

On 08/13/19 16:30, vit9696@protonmail.com wrote:
> Laszlo,
> 
> GCC implemented _Static_assert in 4.6. See its official wiki for C11 compatibility documentation:
> 
> https://gcc.gnu.org/wiki/C11Status

Awesome news!

Once this is upstreamed, we should go through all the ASSERT()s in the
code, and replace those that are compile-time checkable with
STATIC_ASSERT(). I know that I've added quite a few ASSERT()s that I
wished would be checked at build time.

Of course, I'll probably never have time for that. :/

Thanks
Laszlo