From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 37A24D801DE for ; Sat, 4 May 2024 00:57:21 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=k/b7tCQ9jqLlhtuNSR54A9ucy6O9ARRwO90897uWiRk=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714784239; v=1; b=z+V7/ICR74DBG0Xr2ZKr0iV6PkoJzle2U6l4glfJIVgq4ygMNeUZsBdGu0uxiHC3R2I19tK2 Zxm2uBXuELq0VqyKYIooLlZiXaKYLRi1Ar50tG3vdCA+TMCbhbyEFKdqSILAtcMHTNa7JQaEwS0 bUK57wcPEFYB8lMdISrjynXyHb0HGIt1EiPCIYCj+OdvtWMP8FFg0PtlJKV5ENwXRZLJ+mZ5uiZ Qa5NqkgHiOP50ytdH8/8pO1eA8Ew9lcw2KazQ9jREkRj5N8VM+phL0TOD6KjV+Q6ZEbj2LltPlQ QU6+JilNS4hzSMrt2tMyyygalXxTroyM9OSrb4PBelRtw== X-Received: by 127.0.0.2 with SMTP id iYDyYY7687511xfrTJvr4FcH; Fri, 03 May 2024 17:57:19 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.5184.1714784238959783431 for ; Fri, 03 May 2024 17:57:19 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.15]) by linux.microsoft.com (Postfix) with ESMTPSA id 1DE3E207DBD8; Fri, 3 May 2024 17:57:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1DE3E207DBD8 Message-ID: <093489b7-67c1-4315-8929-8f7b5f0c16b0@linux.microsoft.com> Date: Fri, 3 May 2024 17:57:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: devel@edk2.groups.io, michael.d.kinney@intel.com, Pedro Falcato Cc: "rfc@edk2.groups.io" , Leif Lindholm , "Andrew Fish (afish@apple.com)" References: From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 03 May 2024 17:57:19 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: l21Efw5RlVWcZ0NwV32PXTgvx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="z+V7/ICR"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none) On 5/3/2024 4:38 PM, Michael D Kinney wrote: >=20 >=20 >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Friday, May 3, 2024 1:13 PM >> To: Pedro Falcato >> Cc: rfc@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm >> ; Andrew Fish (afish@apple.com) ; >> Kinney, Michael D >> Subject: RE: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code >> Review from email to GitHub Pull Requests on 5-24-2024 >> >> >> >>> -----Original Message----- >>> From: Pedro Falcato >>> Sent: Friday, May 3, 2024 10:39 AM >>> To: Kinney, Michael D >>> Cc: rfc@edk2.groups.io; devel@edk2.groups.io; Leif Lindholm >>> ; Andrew Fish (afish@apple.com) >>> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore Code >>> Review from email to GitHub Pull Requests on 5-24-2024 >>> >>> On Thu, May 2, 2024 at 7:17=E2=80=AFPM Kinney, Michael D >>> wrote: >>>> >>>> >>>> >>>>> -----Original Message----- >>>>> From: rfc@edk2.groups.io On Behalf Of Pedro >>> Falcato >>>>> Sent: Thursday, May 2, 2024 10:51 AM >>>>> To: devel@edk2.groups.io; Kinney, Michael D >>> >>>>> Cc: rfc@edk2.groups.io; Leif Lindholm ; Andrew >>> Fish >>>>> (afish@apple.com) >>>>> Subject: Re: [edk2-rfc] [edk2-devel] Proposal to switch TianoCore >>> Code >>>>> Review from email to GitHub Pull Requests on 5-24-2024 >>>>> >>>>> On Wed, May 1, 2024 at 6:44=E2=80=AFPM Michael D Kinney via groups.io >>>>> wrote: >>> >>>>>> * All contributors, maintainers, and reviewers must have GitHub >>> IDs. >>>>>> * The commit message would no longer require Cc:, Reviewed-by:, >>> Acked- >>>>> by: >>>>>> or Tested-by: tags. The only required tag would be Signed- >> off- >>> by. >>>>> >>>>> I'd just like to note that losing the CC:, Reviewed-by:, etc is a >>> big >>>>> loss. Gerrit auto-adds Rb's, github PR's do not (I'd guess there's >> a >>>>> way to pull that off with github actions, but I haven't looked). >>> It'll >>>>> be a mess if I have to go through online GH PR backlogs just to >> find >>>>> who to CC/add-to-review. It kills the decentralized bit off of git >>> too >>>>> :) >>>>> >>>> >>>> Can you provide more details on the impact of the loss? >>> >>> In my view, commits should be fairly self-describing. What changes, >>> why, are obvious, but who looked at it, who reviewed it, who was cc'd >>> but didn't respond, who tested are also pretty important. Git is >>> supposed to be decentralized, let's not forget. If we ever migrate >>> from GH, if GH ever goes down, if the links ever go down, you'll never >>> be able to know who looked at it. If you're looking at an EDK2 commit >>> deep into an Intel-internal fork, you won't know what "PR #478" is >>> (heck, rebase-and-merge doesn't reference PRs either). >>> >>> Side-note: How are we supposed to find the PR for a given commit? >>> Searching doesn't seem to work well. For instance, I picked a random >>> non-trivial commit out of the current open PRs: >>> MdeModulePkg/Bus/Spi/SpiBus: Adding SpiBus Drivers. >>> >> https://github.com/tianocore/edk2/pulls?q=3Dis%3Apr+is%3Aopen+MdeModuleP= kg >>> %2FBus%2FSpi%2FSpiBus%3A+Adding+SpiBus+Drivers >>> has no matches? >> >> If you have the sha of the commit, you can search in GitHub >> >> For example, I selected a commit at random from recent edk2 commit >> history: >> >> https://github.com/tianocore/edk2/commit/032830e96841f2a752e364378c >> 3428ac5d2f59d1 >> >> Goto the "Pull Requests" tab for the repo and in the "Filters" search >> box enter >> >> is:pr is:merged >> >> In this example: >> >> is:pr is:merged 032830e96841f2a752e364378c3428ac5d2f59d1 >> >> This returns a single hit on PR #5560 >> >> https://github.com/tianocore/edk2/pull/5560 >> >> There is also a 'gh' command line utility that can be used to write >> small scripts to collect this information >=20 > Here is the equivalent query and output using 'gh' CLI command: >=20 > gh pr list --repo tianocore/edk2 --state merged --search 032830e9684= 1f2a752e364378c3428ac5d2f59d1 >=20 > Showing 1 of 1 pull request in tianocore/edk2 that matches your sear= ch >=20 > ID TITLE BRANCH CREATED AT > #5560 Loongcpu niruiyu:loongcpu about 17 days ago I didn't see this explicitly mentioned but the easiest way to get to the=20 PR if you already have a commit hash/URL like=20 https://github.com/tianocore/edk2/commit/032830e is to click the PR link=20 next to the branch name at the bottom of the commit message. In that commit you'll see: "master (#5560)" Where "#5560" is the PR number and the link to the PR. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118566): https://edk2.groups.io/g/devel/message/118566 Mute This Topic: https://groups.io/mt/105873467/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-