public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>, Andrew Fish <afish@apple.com>
Subject: Re: [Patch V3 7/8] edk2: Move License.txt file to root
Date: Tue, 25 Jul 2017 12:06:35 +0200	[thread overview]
Message-ID: <09368faf-a3f9-ab73-00e7-0fe3d5868320@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5A7D5DCFC@ORSMSX113.amr.corp.intel.com>

On 07/21/17 01:39, Kinney, Michael D wrote:
> Jordan,
> 
> Thanks for the review.
> 
> I think the multiple license topic may need more discussion.
> Is the file organization you recommend documented somewhere?
> Do you have a link?  If a project uses a git submodule, is 
> the license from the submodule added to the parent project?
> 
> For example, see OpenSSL email from earlier today:
> 
>   https://lists.01.org/pipermail/edk2-devel/2017-July/012471.html
> 
> The edk2-non-osi repository is another example where we have
> license files next to the  content to which the license applies.
> 
> My goal is to update edk2 to use the same consistent style when
> multiple licenses are in use.
> 
> I can drop the OvmfPkg changes for this series and we can continue
> this discussion and also wait to hear from Laszlo on this topic.

Personally I would prefer the smallest amount of license files scattered
around OvmfPkg specifically and the tree generally.

What does QEMU do?

http://git.qemu.org/?p=qemu.git;a=blob;f=LICENSE
http://git.qemu.org/?p=qemu.git;a=blob;f=disas/libvixl/LICENCE
http://git.qemu.org/?p=qemu.git;a=blob;f=tcg/LICENSE

I guess the idea is that the project root license defines the default
license, and lists all known exceptions by pathname pattern. Plus, those
subdirs contain their own license files. Finally, all files come with a
license banner (matching the most specific license file towards the
project root). Git submodules are not taken into account in the project
root license.

I think this is too complex. I don't feel strongly about this either
way, but my preference would be (again) the lowest number of license
files one has to look at. So perhaps one root license file with a
default license, and pathname patterns that cumulatively cover all of
the exceptions. Or one license file per package, with a default license
for the package, plus pathname patterns, where the patterns cumulatively
cover all of the exceptions within the package.

Hm... Looks like this is already what "OvmfPkg/License.txt" does?

Thanks
Laszlo


  reply	other threads:[~2017-07-25 10:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-20  5:44 [Patch V3 0/8] Update to Tiano Contribution Agreement 1.1 Michael D Kinney
2017-07-20  5:44 ` [Patch V3 1/8] BaseTools/PatchCheck: Support " Michael D Kinney
2017-07-20 22:57   ` Jordan Justen
2017-07-20  5:44 ` [Patch V3 2/8] edk2: Move TianoCore Contribution Agreement to root Michael D Kinney
2017-07-20  5:44 ` [Patch V3 3/8] edk2: Remove commit message details from Contributions.txt Michael D Kinney
2017-07-21 21:16   ` Jordan Justen
2017-07-21 22:14     ` Leif Lindholm
2017-07-24 18:13       ` Kinney, Michael D
2017-07-24 19:33         ` Jordan Justen
2017-07-24 20:01           ` Kinney, Michael D
2017-07-24 20:46             ` Jordan Justen
2017-07-20  5:44 ` [Patch V3 4/8] edk2: Update to TianoCore Contribution Agreement 1.1 Michael D Kinney
2017-07-20  5:44 ` [Patch V3 5/8] edk2: Reformat " Michael D Kinney
2017-07-20  5:44 ` [Patch V3 6/8] edk2/OvmfPkg: Add MIT license files Michael D Kinney
2017-07-20  5:44 ` [Patch V3 7/8] edk2: Move License.txt file to root Michael D Kinney
2017-07-20  6:35   ` Jordan Justen
2017-07-20 15:09     ` Kinney, Michael D
2017-07-20 22:53       ` Jordan Justen
2017-07-20 23:39         ` Kinney, Michael D
2017-07-25 10:06           ` Laszlo Ersek [this message]
2017-07-20  5:44 ` [Patch V3 8/8] edk2: Add Readme.md to root of edk2 repository Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09368faf-a3f9-ab73-00e7-0fe3d5868320@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox