From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1B2EB941AA9 for ; Wed, 18 Oct 2023 12:11:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=BUAVIDuhEHbpRZVjNfe32hL99/jOYvud4cQskOFMaxk=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697631097; v=1; b=qEAVfLvD3iV+VzN4+YDgcOugHxS2w7U0ysq3LoU01ZrDMbC9c35oda1rqS7DsSFBDpR/Wlhp bqOCU7Fp75Z2WmJCLHB8mH3Li+aVXYQy2ze98VLk2xayHHAa/qvXo7vLsl0cPK/qOo6fNkT8PgJ Nl3uTGL7g0QhhZShLaQvE9EM= X-Received: by 127.0.0.2 with SMTP id 5RmnYY7687511xlRXaGBae1p; Wed, 18 Oct 2023 05:11:37 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.280145.1697631096906111925 for ; Wed, 18 Oct 2023 05:11:37 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-567-JuWlwwgjP8uCmh4UaBCypg-1; Wed, 18 Oct 2023 08:11:21 -0400 X-MC-Unique: JuWlwwgjP8uCmh4UaBCypg-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 36A5F89177C; Wed, 18 Oct 2023 12:11:20 +0000 (UTC) X-Received: from [10.39.192.202] (unknown [10.39.192.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CADD61C060AE; Wed, 18 Oct 2023 12:11:18 +0000 (UTC) Message-ID: <093ea77b-ae2a-8ffb-5646-9c1ddea87575@redhat.com> Date: Wed, 18 Oct 2023 14:11:17 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH edk2-platforms v5 7/7] Sophgo/SG2042Pkg: Add platform readme and document. To: =?UTF-8?B?6JSh6Zuo5pm0?= Cc: devel@edk2.groups.io, USER0FISH , sunilvl@ventanamicro.com, Leif Lindholm , Michael D Kinney , Inochi Amaoto , Ard Biesheuvel References: <022a1dd866233cd1d2ae518f91720487f7569b34.1697120122.git.caiyuqing_hz@outlook.com> <67438e36.2d9.18b428542db.Coremail.caiyuqing_hz@163.com> From: "Laszlo Ersek" In-Reply-To: <67438e36.2d9.18b428542db.Coremail.caiyuqing_hz@163.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vwU0q67qMHxb4n8avtUB56eMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=qEAVfLvD; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/18/23 13:21, 蔡雨晴 wrote: > Hi Laszlo, > > Thank you for your comments. I will commit a new patch to add the > maintainers to the "Maintainers.txt" file in the root directory of the > edk2-platforms project. > > Please let us know if you have more suggestions. I do have one, but it's not specifically for this patch set, but for all future edk2(-platforms) patches you may post -- please add "--stat=1000 --stat-graph-width=20" to your git-format-patch command line. Edk2(-platforms) use(s) long pathnames, and so the cumulative diffstat tends to be truncated, and on the left side at that. That fact makes it hard to see the extent of a patchset. If you add these options, then the cumulative diffstat is going to be just as wide as it needs to be -- no truncation, and no needless padding. The "BaseTools/Scripts/SetupGit.py" utility creates a git-format-patch alias called "fp" that includes these options. BTW I could help Ard out by pushing this patch set (well, v4, with the Maintainers.txt fix), I'm just not clear when a patch set counts as "sufficiently reviewed" for edk2-platforms. Laszlo > > Thanks, > Yuqing Cai > > > > > > At 2023-10-18 17:47:04, "Laszlo Ersek" wrote: >>On 10/13/23 05:03, caiyuqing_hz@163.com wrote: >>> diff --git a/Platform/Sophgo/Maintainers.md b/Platform/Sophgo/Maintainers.md >>> new file mode 100644 >>> index 000000000000..4cb32c359a31 >>> --- /dev/null >>> +++ b/Platform/Sophgo/Maintainers.md >>> @@ -0,0 +1,105 @@ >>> +##Project Name: EDK2 Sophgo SG2042 >>> + >>> +##Maintainers: >>> +1. dahogn - dahogn@hotmail.com >>> +2. caiyuqing379 - >>> +3. meng-cz - mengcz1126@gmail.com >>> +4. USER0FISH - >>> + >> >>This "Platform/Sophgo/Maintainers.md" file / format is useless with >>edk2's "BaseTools/Scripts/GetMaintainer.py" utility. For that utility to >>work, you need to add the maintainers to the "Maintainers.txt" file in >>the edk2-platforms project root dir (... as well). >> >>Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109740): https://edk2.groups.io/g/devel/message/109740 Mute This Topic: https://groups.io/mt/101944473/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-