Re: [edk2-devel] [PATCH 1/1] Platform/ARM/JunoPkg: Don't setup PCIe root bridge for Juno-r0

["PierreGondois" <pierre.gondois@arm.com>]

On 4/14/23 00:04, Rebecca Cran wrote:
> On 4/13/23 07:14, PierreGondois wrote:
> 
>> diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
>> index 0755dc155616..583efd0efb16 100644
>> --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
>> +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c
>> @@ -69,6 +69,13 @@ HWPciRbInit (
>>      UINTN                   TranslationTable;
>>      EFI_CPU_IO2_PROTOCOL    *CpuIo;
>>      EFI_STATUS              Status;
>> +  UINT32                  JunoRevision;
>> +
>> +  GetJunoRevision (JunoRevision);
>> +  DEBUG ((DEBUG_ERROR, "Juno rev=%d\n", JunoRevision));
> 
> Should that be DEBUG_INFO? Or is it DEBUG_ERROR because of the value of
> PcdDebugPrintErrorLevel which doesn't include INFO messages?
> 
> I was just wondering a few days ago whether it should be 0x8000004F
> instead of 0x8000000F?
> 

The DEBUG message is not necessary, I will remove it.
PcdDebugPrintErrorLevel effectively doesn't include INFO messages,
I assume this is ok not to have them even in the DEBUG build.

Regards,
Pierre