From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.3518.1681456364720363537 for ; Fri, 14 Apr 2023 00:12:44 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 215232F4; Fri, 14 Apr 2023 00:13:28 -0700 (PDT) Received: from [192.168.1.12] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3531C3F6C4; Fri, 14 Apr 2023 00:12:42 -0700 (PDT) Message-ID: <096ed77c-b39a-5277-d403-48944ba57fc4@arm.com> Date: Fri, 14 Apr 2023 09:12:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [PATCH 1/1] Platform/ARM/JunoPkg: Don't setup PCIe root bridge for Juno-r0 To: Rebecca Cran , devel@edk2.groups.io Cc: Thomas Abraham , Ard Biesheuvel , Sami Mujawar , Fabien Ficheau References: <20230413131448.70329-1-Pierre.Gondois@arm.com> <658b65fd-ea8b-bb91-c72a-5c0642623887@bsdio.com> From: "PierreGondois" In-Reply-To: <658b65fd-ea8b-bb91-c72a-5c0642623887@bsdio.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/14/23 00:04, Rebecca Cran wrote: > On 4/13/23 07:14, PierreGondois wrote: > >> diff --git a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c >> index 0755dc155616..583efd0efb16 100644 >> --- a/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c >> +++ b/Platform/ARM/JunoPkg/Library/JunoPciHostBridgeLib/XPressRich3.c >> @@ -69,6 +69,13 @@ HWPciRbInit ( >> UINTN TranslationTable; >> EFI_CPU_IO2_PROTOCOL *CpuIo; >> EFI_STATUS Status; >> + UINT32 JunoRevision; >> + >> + GetJunoRevision (JunoRevision); >> + DEBUG ((DEBUG_ERROR, "Juno rev=%d\n", JunoRevision)); > > Should that be DEBUG_INFO? Or is it DEBUG_ERROR because of the value of > PcdDebugPrintErrorLevel which doesn't include INFO messages? > > I was just wondering a few days ago whether it should be 0x8000004F > instead of 0x8000000F? > The DEBUG message is not necessary, I will remove it. PcdDebugPrintErrorLevel effectively doesn't include INFO messages, I assume this is ok not to have them even in the DEBUG build. Regards, Pierre