From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by mx.groups.io with SMTP id smtpd.web12.32425.1617468483624499629 for ; Sat, 03 Apr 2021 09:48:03 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=ElAcof3m; spf=pass (domain: akeo.ie, ip: 209.85.128.47, mailfrom: pete@akeo.ie) Received: by mail-wm1-f47.google.com with SMTP id w203-20020a1c49d40000b029010c706d0642so6096362wma.0 for ; Sat, 03 Apr 2021 09:48:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=TL7XOAapKCRmAs7C7Wo4inEfhNMnSe2Tup21RWzVW2E=; b=ElAcof3mPAtqo97o+NzWil3gMgHvq1qq1G3sarToiLD2HBrn3JSu772Z/TATk1MtHJ tLgViSLPGGw8Px6pChfS9nTUdJYvQEL/fqfDARRUdQUrdC7K7N/sRxbDngO34zDviAox ymbqfR9BlWQbrk884ZHk5N96bxbKFTpuIHnuq0Aa3yfNdRwHCjzJ2Ky/YKwyF7uRthlN dWDqyxAJjRDHEkNP2O3xyEzs9BYVBKfUJKPCKejr4KRnx/6RiEHUFZMAVgbJlljc0fjL 4EeoFDnzR+Il4ka3/2+ZOFtg/k1ZbBvKHdYs5yxOO7O8Wb2A9J+JNWlaHGkXNLgvrRU3 U5Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TL7XOAapKCRmAs7C7Wo4inEfhNMnSe2Tup21RWzVW2E=; b=P/dfbpBW67CdNy/LECQH8mLD8THjrI6Fh41kgvQN172T3IjanKRjcvg5aHvUF/xjAf YUnKXFSfrB757+YrpNKNtoIWfZEjWMKmiUUegmxQ2MA0gdNYFgWsojX/02YModT5D/e+ Fb2jnGQshMAxzzMD0ag7z4W5O09eNhYaM/kSP/Q8J0K5ELCJ/V+OYMqTu1qNsGWOl4g7 ELyQj52x9O4rnSoN3t+o7sOsR1PzE+NN539TVs8tZOsuVFih91FOkXb30FSDpXHi/AIy ZZU4rwi+KMJmKF4NlG8PBM/URsnYSkb8KeRxlBjVfUVueUOmTv44ZIqg/ph9A+CWBkYX r77w== X-Gm-Message-State: AOAM531sQGjBZnPzaJgUtYqcLSSvTMJxi+XhqOYJ4P7d7oIy++CrZXGw takGwVux8OnxXJu5YwoY7d4t+A== X-Google-Smtp-Source: ABdhPJyRhl+gpA6ogA8Z5qlZpi5SyrXE4x5ON1t+vQO6Skj8/6jreWutDIkFxdk8CJpsTZq7tIRhdw== X-Received: by 2002:a7b:cb89:: with SMTP id m9mr17751188wmi.27.1617468482214; Sat, 03 Apr 2021 09:48:02 -0700 (PDT) Return-Path: Received: from [10.0.0.122] ([84.203.60.64]) by smtp.googlemail.com with ESMTPSA id j6sm2710647wru.18.2021.04.03.09.48.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Apr 2021 09:48:01 -0700 (PDT) Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Fix mini UART baud divisor calculation To: devel@edk2.groups.io, mariobalanica02@gmail.com References: <12335.1617466520975264572@groups.io> From: "Pete Batard" Message-ID: <0977f638-6c4a-ca56-07c7-6f4a2b7da6b8@akeo.ie> Date: Sat, 3 Apr 2021 17:48:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <12335.1617466520975264572@groups.io> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit On 2021.04.03 17:15, Mario Bălănică wrote: > > -#if (RPI_MODEL == 4) > > -  Divisor = MmioRead32(BCM2836_CM_BASE + > BCM2836_CM_VPU_CLOCK_DIVISOR) & 0xFFFFFF; > > -  if (Divisor != 0) > > -    BaseClockRate = (BaseClockRate << 12) / Divisor; > > -#endif > > Keeping this doesn't interfere with the rest of the patch. I've removed > it only because it's useless on the latest firmware. Okay, then can you please send a v2 of your patch that leaves this in? I believe this divisor arithmetic is still needed with older versions of start4.elf, and we may have people using choosing to use an older start4.elf for whatever reason. In general, if it doesn't interfere with your proposal, it's better to leave existing code in, as overzealous code removal may have unintended consequences, unless you are confident that the code is superfluous. Also make sure you update the commit message to mention what issue you are fixing. Thanks, /Pete