From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.groups.io with SMTP id smtpd.web11.46.1571244633643099377 for ; Wed, 16 Oct 2019 09:50:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: philmd@redhat.com) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DFE78806CD for ; Wed, 16 Oct 2019 16:50:32 +0000 (UTC) Received: by mail-wr1-f70.google.com with SMTP id n3so12015516wrt.9 for ; Wed, 16 Oct 2019 09:50:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1soCmEVLEc2FY+L8Qjw+5kRj5vBs/Na/m7t8UOCPxgM=; b=OHwCpA7ZPl05FmjXgKtanMYnK16ejo1DTmoJ8Q+StVE9idBgvnZxh73e4/aApmFqam PI41Ke3HJ3K98jRo/s5g2mdXpF1RBVp4zM/iH2NCWMXI+EJU93FTaY6r6VaCYXuiHjU2 4zGCRtgE8oWToRR5NR0J8inMnfiyT4JaNwNqzXiPoD/nMYM9zalNIDIXxR3rF8NO8LAx dt9ejU9+VB0zzZap6/mlQpwzEdO8g4IdZS/IDQvUqVjRY8YAgWYokB1qjkEEZ72cNqWy tAkB0eR3SdPB4ecIoFQ5sDizKtHC655me6X197zyXAvpdId09F2JXDoTz/zlUbaRDXf3 6kbw== X-Gm-Message-State: APjAAAWSyzfKTaNL0BDZhOScMSa/RNxs5Zjt4Hmz9RQEIkvpiS4EfEwi 3vXhX4pXJqMeA16RXTLLlyZyDitH2mbmH5iG9/VYyTYVebFWHT4XQcRGWoDXYWyujRVDapt0wX0 EqD42Tabd3y7vVg== X-Received: by 2002:adf:dbc4:: with SMTP id e4mr3448531wrj.354.1571244631582; Wed, 16 Oct 2019 09:50:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqynqKj8HVx/ZviSaQhmqznam2bcH1rXwAF67Oz7sMgo3tq6E1sb4kURag7TXRuFKgBs+FqsEA== X-Received: by 2002:adf:dbc4:: with SMTP id e4mr3448503wrj.354.1571244631291; Wed, 16 Oct 2019 09:50:31 -0700 (PDT) Received: from [192.168.1.36] (14.red-88-21-201.staticip.rima-tde.net. [88.21.201.14]) by smtp.gmail.com with ESMTPSA id y19sm3040809wmi.13.2019.10.16.09.50.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Oct 2019 09:50:30 -0700 (PDT) Subject: Re: [PATCH 0/3] BaseTools: Add a script to use with 'git-send-email --cc-cmd' To: Leif Lindholm , Stefan Hajnoczi Cc: devel@edk2.groups.io, Bob Feng , Liming Gao , Laszlo Ersek References: <20191016140940.18844-1-philmd@redhat.com> <20191016151812.GT25504@bivouac.eciton.net> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <09862a75-0aa5-84b2-ceab-1728ba7c17d0@redhat.com> Date: Wed, 16 Oct 2019 18:50:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191016151812.GT25504@bivouac.eciton.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/16/19 5:18 PM, Leif Lindholm wrote: > Hi Phil, >=20 > This is definitely a manual step that could do with automation, so > many thanks for having a go. ...But, I have a few reservations > regarding the actual solution. >=20 > First of all, doing it as a .sh means it will not work for those > developers working primarily with Visual Studio. Rewriting it as > python script would resolve this, and also let you import > GetMaintainer.py and use functions from there instead of adding a > quiet mode to that. (I would very much like to not turn the > GetMaintainer.py output into an ABI.) OK. I was not expecting the .sh to get merged but wanted to have=20 feedback as in a RFC, so I sent it mostly as a proof of concept. > Secondly, I agree with Laszlo that I would rather see something that > operated with format-patch than send-email (since we want to keep the > Cc: tags in the commit messages). That command does not have the same > useful hook, however. Laszlo's reply and yours are the feedback I was expecting :) > For this reason *I* would not use said script, but I'm not going to > say we shouldn't have it. I will say it shouldn't be enabled by > default by SetupGit.py though. Well, I wrote it because I use git-publish in my workflow and wanted to=20 use your GetMaintainer script output to select the recipients. I'm not custom to the Cc tag (I don't use it). Maybe my problem is=20 git-publish not handling correctly the Cc tag feature, so forget about=20 this series for now, I'll see how to better integrate both tools in my=20 workflow and eventually respin (without using your script as a stable ABI= ). Regards, Phil. > On Wed, Oct 16, 2019 at 04:09:37PM +0200, Philippe Mathieu-Daude wrote: >> This series contains trivial fixes to the GetMaintainer.py script, >> then adds a new script which allow git-send-email to automatically >> fills the email addresses relevant to each patch, using the new >> Maintainer.txt format (with the GetMaintainer.py script). >> >> I sent this series adding: >> >> [sendemail] >> ccCmd =3D /home/phil/source/edk2/BaseTools/Scripts/GitCcCmd.sh >> >> To my /home/phil/source/edk2/.git/config >> >> The sendemail.ccCmd entry is documented here: >> https://git-scm.com/docs/git-send-email#Documentation/git-send-email.t= xt---cc-cmdltcommandgt >> >> Regards, >> >> Phil. >> >> Philippe Mathieu-Daud=C3=A9 (3): >> BaseTools: Let the GetMaintainer.py script be executable >> BaseTools: Add '--quiet' option to GetMaintainer.py script >> BaseTools: Add script to help git-send-email pick addresses to cc >> >> BaseTools/Scripts/GetMaintainer.py | 9 +++++-- >> BaseTools/Scripts/GitCcCmd.sh | 38 ++++++++++++++++++++++++++++= ++ >> 2 files changed, 45 insertions(+), 2 deletions(-) >> mode change 100644 =3D> 100755 BaseTools/Scripts/GetMaintainer.py >> create mode 100755 BaseTools/Scripts/GitCcCmd.sh >> >> --=20 >> 2.21.0 >>