Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned

["Oliver Smith-Denny" <osde@linux.microsoft.com>]

On 1/19/2024 8:34 AM, Rebecca Cran wrote:
> On 1/18/2024 12:26 PM, Oliver Smith-Denny wrote:
> 
>> Does this solve your issue? I have to run to a meeting, but I can
>> write this in actual patch form (and give it a quick test) later.
> 
> Unfortunately that didn't work: I still get the assert.
> 
> ...
> SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table
> 
> ASSERT_EFI_ERROR (Status = Invalid Parameter)
> ASSERT [SmbiosDxe] 
> /local-data/src/ampereone/edk2/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c(145): !(((INTN)(RETURN_STATUS)(Status)) < 0)
> 

Thanks for trying. In lieu of being able to test myself, all I can offer
is adding some more prints, when the memory gets allocated, making sure
it is 64k aligned then. I'd be curious to see what the address is that
is attempting to be freed.

My guess (as it was earlier) is that it is going to be aligned to
64k but + 4k. I.e the guard page at the front is throwing it off. There
may have just been an error in my attempt to fix the check for that.

If however that address is not 64k + 4k aligned, then something else is
afoot.

Happy to look at some more data if you get it or can engineer an example
on an open source system (can you force the system to call this function
twice even without the extra SMBIOS entries, etc.).

Thanks,
Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114098): https://edk2.groups.io/g/devel/message/114098
Mute This Topic: https://groups.io/mt/103810212/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-