From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 27C50AC18D3 for ; Fri, 19 Jan 2024 20:03:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QG5XGMEZQh6YQ3Yl6ybJIH6dxaVR6J2GPlIDPm7U2h4=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705694586; v=1; b=KIf3LRAkXDouaF+MuFpW9w9ciWjf+CzCtJjxBS+n0A6fZ7hi/BhfXtypB+t6+us2Vc8aL7cV 2d7og2UXjqvuWNfxwnUnntMP3452zw6vAmatnXDQ6mUovUxChClncyOQqdKhK0FZwm868oKTOBq 9nMHnQ/+MUJ+7UqUGR86nW4s= X-Received: by 127.0.0.2 with SMTP id 3b26YY7687511xZeAi890Ic0; Fri, 19 Jan 2024 12:03:06 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.4014.1705694586299508687 for ; Fri, 19 Jan 2024 12:03:06 -0800 X-Received: from [10.137.194.171] (unknown [131.107.160.171]) by linux.microsoft.com (Postfix) with ESMTPSA id A0B6820DFD73; Fri, 19 Jan 2024 12:03:05 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A0B6820DFD73 Message-ID: <09a8622e-be60-46e2-8e96-447dacb8c12f@linux.microsoft.com> Date: Fri, 19 Jan 2024 12:03:05 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned To: Rebecca Cran , devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Jian J Wang , Liming Gao , Dandan Bi References: <05f6388b-155e-427d-8e34-0ac571e97fb8@os.amperecomputing.com> <24affef7-eb96-4a82-b9d4-b616eb90024d@os.amperecomputing.com> <17AB84FD31479E00.28523@groups.io> <0a589fed-02f1-4598-bbbc-98bad0e8b04f@linux.microsoft.com> <14dac152-dfea-4ad3-bd52-300990bd1be8@os.amperecomputing.com> From: "Oliver Smith-Denny" In-Reply-To: <14dac152-dfea-4ad3-bd52-300990bd1be8@os.amperecomputing.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: urbSilLpNXAt8v0OSxwecWqax7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=KIf3LRAk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/19/2024 8:34 AM, Rebecca Cran wrote: > On 1/18/2024 12:26 PM, Oliver Smith-Denny wrote: >=20 >> Does this solve your issue? I have to run to a meeting, but I can >> write this in actual patch form (and give it a quick test) later. >=20 > Unfortunately that didn't work: I still get the assert. >=20 > ... > SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit table >=20 > ASSERT_EFI_ERROR (Status =3D Invalid Parameter) > ASSERT [SmbiosDxe]=20 > /local-data/src/ampereone/edk2/MdePkg/Library/UefiMemoryAllocationLib/Mem= oryAllocationLib.c(145): !(((INTN)(RETURN_STATUS)(Status)) < 0) >=20 Thanks for trying. In lieu of being able to test myself, all I can offer is adding some more prints, when the memory gets allocated, making sure it is 64k aligned then. I'd be curious to see what the address is that is attempting to be freed. My guess (as it was earlier) is that it is going to be aligned to 64k but + 4k. I.e the guard page at the front is throwing it off. There may have just been an error in my attempt to fix the check for that. If however that address is not 64k + 4k aligned, then something else is afoot. Happy to look at some more data if you get it or can engineer an example on an open source system (can you force the system to call this function twice even without the extra SMBIOS entries, etc.). Thanks, Oliver -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114098): https://edk2.groups.io/g/devel/message/114098 Mute This Topic: https://groups.io/mt/103810212/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-