From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.2767.1575634609196717265 for ; Fri, 06 Dec 2019 04:16:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IAeKVh4v; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575634608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=47bfRnrbIOMnmyHOe9jU/CFKYE3LwMCQumX1+bWw1qs=; b=IAeKVh4vE1qXl8Y3pyg65bDPHpgp5EZox5BweBn7QVCl8vLo/Jj7VKVkXJZ3jqUXKRm5mw d1aeScgFpBQJMA6CLp3H3YNBUTlChtKyo25VPAlw0660Au89lzKlf135zTE/TZFGmMqinU 2g6pQrgdrDqg1uhK9q9K+Fmt7yntcgc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-252-pUWaJQaWP7O9ps-1otvYlA-1; Fri, 06 Dec 2019 07:16:45 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 26B9C911EA; Fri, 6 Dec 2019 12:16:44 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 322EA5DA60; Fri, 6 Dec 2019 12:16:43 +0000 (UTC) Subject: Re: [PATCH edk2-platforms 1/2] Platform/ARM/ArmJunoDxe: make mAcpiRegistration STATIC To: Ard Biesheuvel , devel@edk2.groups.io Cc: Sami Mujawar , Leif Lindholm References: <20191206110219.32190-1-ard.biesheuvel@linaro.org> <20191206110219.32190-2-ard.biesheuvel@linaro.org> From: "Laszlo Ersek" Message-ID: <09ca9f4d-b897-4af4-6661-bdff790ca599@redhat.com> Date: Fri, 6 Dec 2019 13:16:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20191206110219.32190-2-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: pUWaJQaWP7O9ps-1otvYlA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 12/06/19 12:02, Ard Biesheuvel wrote: > Generally, variables should only have external linkage if needed, > so make mAcpiRegistration STATIC, given that static linkage suffices > for it. > > Signed-off-by: Ard Biesheuvel > --- > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > index ea7591d70443..c0ad7ced2959 100644 > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > @@ -64,7 +64,7 @@ STATIC CONST EFI_PCI_ROOT_BRIDGE_DEVICE_PATH mPciRootComplexDevicePath = { > } > }; > > -EFI_EVENT mAcpiRegistration = NULL; > +STATIC EFI_EVENT mAcpiRegistration = NULL; > > /** > This function reads PCI ID of the controller. > The patch does what it says on the tin, so: Reviewed-by: Laszlo Ersek But, this too should have type "VOID *"; so if you have capacity for an extra patch (or an extra change in this same patch), I'd recommend fixing up the type. Related commits (from edk2): - 10eec5aa9297 ("MdeModulePkg: stop abusing EFI_EVENT for protocol notify registration", 2019-10-09) - fcf8bdcd5313 ("SecurityPkg: stop abusing EFI_EVENT for protocol notify registration", 2019-10-09) Thanks! Laszlo