From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Cc: Anthony Perard <anthony.perard@citrix.com>,
Jiewen Yao <jiewen.yao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>
Subject: Re: [edk2-devel] [PATCH v2 00/11] support QEMU's "SMRAM at default SMBASE" feature
Date: Wed, 5 Feb 2020 14:44:09 +0100 [thread overview]
Message-ID: <09dd27e2-444c-092e-f569-50e312b92888@redhat.com> (raw)
In-Reply-To: <CAKv+Gu-MxR8Vj8X_mSVXMj3sCLmWGZ+6BfBE=1p551TQ0184PQ@mail.gmail.com>
On 02/05/20 01:22, Ard Biesheuvel wrote:
> On Wed, 29 Jan 2020 at 21:44, Laszlo Ersek <lersek@redhat.com> wrote:
>>
>> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512
>> Repo: https://github.com/lersek/edk2.git
>> Branch: smram_at_default_smbase_bz_1512_wave_1_v2
>> Supersedes: <20190924113505.27272-1-lersek@redhat.com>
>>
>> V1 is archived at:
>> - http://mid.mail-archive.com/20190924113505.27272-1-lersek@redhat.com
>> - https://edk2.groups.io/g/devel/message/47924
>>
>> Igor's patch set, mentioned in the v1 blurb, has been merged into QEMU
>> meanwhile. The relevant QEMU commit is f404220e279c ("q35: implement
>> 128K SMRAM at default SMBASE address", 2020-01-22).
>>
>> In v2:
>> - trim the Cc list
>>
>> - pick up Jiewen's R-b for patches #1 through #9, from:
>> - http://mid.mail-archive.com/74D8A39837DF1E4DA445A8C0B3885C503F7CBCB2@shsmsx102.ccr.corp.intel.com
>> - https://edk2.groups.io/g/devel/message/48166
>>
>> - add patch #10, and update patch #11, for satisfying Jiewen's condition
>> on his R-b.
>>
>> Cc: Anthony Perard <anthony.perard@citrix.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Julien Grall <julien@xen.org>
>>
>> Thanks,
>> Laszlo
>>
>> Laszlo Ersek (11):
>> OvmfPkg: introduce PcdQ35SmramAtDefaultSmbase
>> OvmfPkg/IndustryStandard: increase vertical whitespace in Q35 macro
>> defs
>> OvmfPkg/IndustryStandard: add MCH_DEFAULT_SMBASE* register macros
>> OvmfPkg/PlatformPei: factor out Q35BoardVerification()
>> OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (skeleton)
>> OvmfPkg/PlatformPei: assert there's no permanent PEI RAM at default
>> SMBASE
>> OvmfPkg/PlatformPei: reserve the SMRAM at the default SMBASE, if it
>> exists
>> OvmfPkg/SEV: don't manage the lifecycle of the SMRAM at the default
>> SMBASE
>> OvmfPkg/SmmAccess: close and lock SMRAM at default SMBASE
>> OvmfPkg: introduce PcdCsmEnable feature flag
>> OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (for real)
>>
>
> For the series,
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Much appreciated!
Pushed via <https://github.com/tianocore/edk2/pull/332>, commit range
422da35375c6..75839f977d37.
Laszlo
>
>
>> OvmfPkg/Include/IndustryStandard/Q35MchIch9.h | 106 +++++++++++---------
>> OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 21 +++-
>> OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 4 +
>> OvmfPkg/OvmfPkg.dec | 11 ++
>> OvmfPkg/OvmfPkgIa32.dsc | 4 +
>> OvmfPkg/OvmfPkgIa32X64.dsc | 4 +
>> OvmfPkg/OvmfPkgX64.dsc | 4 +
>> OvmfPkg/OvmfXen.dsc | 3 +
>> OvmfPkg/PlatformPei/AmdSev.c | 24 ++++-
>> OvmfPkg/PlatformPei/MemDetect.c | 94 ++++++++++++++---
>> OvmfPkg/PlatformPei/Platform.c | 24 +++++
>> OvmfPkg/PlatformPei/Platform.h | 7 ++
>> OvmfPkg/PlatformPei/PlatformPei.inf | 2 +
>> OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 7 ++
>> OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 1 +
>> OvmfPkg/SmmAccess/SmmAccessPei.c | 6 ++
>> OvmfPkg/SmmAccess/SmmAccessPei.inf | 1 +
>> OvmfPkg/SmmAccess/SmramInternal.c | 25 +++++
>> OvmfPkg/SmmAccess/SmramInternal.h | 8 ++
>> 19 files changed, 285 insertions(+), 71 deletions(-)
>>
>> --
>> 2.19.1.3.g30247aa5d201
>>
>
>
>
prev parent reply other threads:[~2020-02-05 13:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 21:44 [PATCH v2 00/11] support QEMU's "SMRAM at default SMBASE" feature Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 01/11] OvmfPkg: introduce PcdQ35SmramAtDefaultSmbase Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 02/11] OvmfPkg/IndustryStandard: increase vertical whitespace in Q35 macro defs Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 03/11] OvmfPkg/IndustryStandard: add MCH_DEFAULT_SMBASE* register macros Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 04/11] OvmfPkg/PlatformPei: factor out Q35BoardVerification() Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 05/11] OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (skeleton) Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 06/11] OvmfPkg/PlatformPei: assert there's no permanent PEI RAM at default SMBASE Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 07/11] OvmfPkg/PlatformPei: reserve the SMRAM at the default SMBASE, if it exists Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 08/11] OvmfPkg/SEV: don't manage the lifecycle of the SMRAM at the default SMBASE Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 09/11] OvmfPkg/SmmAccess: close and lock SMRAM at " Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 10/11] OvmfPkg: introduce PcdCsmEnable feature flag Laszlo Ersek
2020-01-29 21:44 ` [PATCH v2 11/11] OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (for real) Laszlo Ersek
2020-02-05 0:22 ` [PATCH v2 00/11] support QEMU's "SMRAM at default SMBASE" feature Ard Biesheuvel
2020-02-05 13:44 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09dd27e2-444c-092e-f569-50e312b92888@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox