From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.7538.1580910262757070101 for ; Wed, 05 Feb 2020 05:44:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XyHfThvu; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580910261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1VsskPDZkmb9a+jAuuT5jD4o+xbHY7+hY4QCydgvqao=; b=XyHfThvu0hRHp1JWRAp3ryCq4jM65GfGAwsaVzNqfsE9b6YY55syeC0IZeR6BvYTNeB+cR bk1gjaPM92/yrFmy0CHMhsqOHGLwFvi9Qtr2kP0+B5CC7hDCW7oTtWl/M2JDB3abqV7Pbe N5n937rpSforZiBAO3RUEQtjX8T+Hb0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-157-r54Q5NcKPgytGTRVKZ3XzQ-1; Wed, 05 Feb 2020 08:44:13 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 373E7DB63; Wed, 5 Feb 2020 13:44:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-248.ams2.redhat.com [10.36.116.248]) by smtp.corp.redhat.com (Postfix) with ESMTP id 868FF10018FF; Wed, 5 Feb 2020 13:44:10 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 00/11] support QEMU's "SMRAM at default SMBASE" feature To: devel@edk2.groups.io, ard.biesheuvel@linaro.org Cc: Anthony Perard , Jiewen Yao , Jordan Justen , Julien Grall References: <20200129214412.2361-1-lersek@redhat.com> From: "Laszlo Ersek" Message-ID: <09dd27e2-444c-092e-f569-50e312b92888@redhat.com> Date: Wed, 5 Feb 2020 14:44:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: r54Q5NcKPgytGTRVKZ3XzQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/05/20 01:22, Ard Biesheuvel wrote: > On Wed, 29 Jan 2020 at 21:44, Laszlo Ersek wrote: >> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1512 >> Repo: https://github.com/lersek/edk2.git >> Branch: smram_at_default_smbase_bz_1512_wave_1_v2 >> Supersedes: <20190924113505.27272-1-lersek@redhat.com> >> >> V1 is archived at: >> - http://mid.mail-archive.com/20190924113505.27272-1-lersek@redhat.com >> - https://edk2.groups.io/g/devel/message/47924 >> >> Igor's patch set, mentioned in the v1 blurb, has been merged into QEMU >> meanwhile. The relevant QEMU commit is f404220e279c ("q35: implement >> 128K SMRAM at default SMBASE address", 2020-01-22). >> >> In v2: >> - trim the Cc list >> >> - pick up Jiewen's R-b for patches #1 through #9, from: >> - http://mid.mail-archive.com/74D8A39837DF1E4DA445A8C0B3885C503F7CBCB2@shsmsx102.ccr.corp.intel.com >> - https://edk2.groups.io/g/devel/message/48166 >> >> - add patch #10, and update patch #11, for satisfying Jiewen's condition >> on his R-b. >> >> Cc: Anthony Perard >> Cc: Ard Biesheuvel >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Julien Grall >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (11): >> OvmfPkg: introduce PcdQ35SmramAtDefaultSmbase >> OvmfPkg/IndustryStandard: increase vertical whitespace in Q35 macro >> defs >> OvmfPkg/IndustryStandard: add MCH_DEFAULT_SMBASE* register macros >> OvmfPkg/PlatformPei: factor out Q35BoardVerification() >> OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (skeleton) >> OvmfPkg/PlatformPei: assert there's no permanent PEI RAM at default >> SMBASE >> OvmfPkg/PlatformPei: reserve the SMRAM at the default SMBASE, if it >> exists >> OvmfPkg/SEV: don't manage the lifecycle of the SMRAM at the default >> SMBASE >> OvmfPkg/SmmAccess: close and lock SMRAM at default SMBASE >> OvmfPkg: introduce PcdCsmEnable feature flag >> OvmfPkg/PlatformPei: detect SMRAM at default SMBASE (for real) >> > > For the series, > > Reviewed-by: Ard Biesheuvel Much appreciated! Pushed via , commit range 422da35375c6..75839f977d37. Laszlo > > >> OvmfPkg/Include/IndustryStandard/Q35MchIch9.h | 106 +++++++++++--------- >> OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 21 +++- >> OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 4 + >> OvmfPkg/OvmfPkg.dec | 11 ++ >> OvmfPkg/OvmfPkgIa32.dsc | 4 + >> OvmfPkg/OvmfPkgIa32X64.dsc | 4 + >> OvmfPkg/OvmfPkgX64.dsc | 4 + >> OvmfPkg/OvmfXen.dsc | 3 + >> OvmfPkg/PlatformPei/AmdSev.c | 24 ++++- >> OvmfPkg/PlatformPei/MemDetect.c | 94 ++++++++++++++--- >> OvmfPkg/PlatformPei/Platform.c | 24 +++++ >> OvmfPkg/PlatformPei/Platform.h | 7 ++ >> OvmfPkg/PlatformPei/PlatformPei.inf | 2 + >> OvmfPkg/SmmAccess/SmmAccess2Dxe.c | 7 ++ >> OvmfPkg/SmmAccess/SmmAccess2Dxe.inf | 1 + >> OvmfPkg/SmmAccess/SmmAccessPei.c | 6 ++ >> OvmfPkg/SmmAccess/SmmAccessPei.inf | 1 + >> OvmfPkg/SmmAccess/SmramInternal.c | 25 +++++ >> OvmfPkg/SmmAccess/SmramInternal.h | 8 ++ >> 19 files changed, 285 insertions(+), 71 deletions(-) >> >> -- >> 2.19.1.3.g30247aa5d201 >> > > >