Re: [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg

["Leif Lindholm" <quic_llindhol@quicinc.com>]

Hi Oliver,

On 2024-08-01 23:39, Oliver Smith-Denny wrote:
> CompilerIntrinsicsLib and ArmSoftFloatLib add ARM/AARCH64 compiler
> intrinsics and floating point functions required by OpenSSL,
> respectively. CompilerIntrinsicsLib is used almost in every DSC that
> builds ARM/AARCH64 and ArmSoftFloatLib is used by every DSC that builds
> logic from OpenSSL. Together these make almost every DSC have a
> dependency on ArmPkg, which is odd and for a handful, MdeModulePkg,
> EmbeddedPkg, and ShellPkg, namely, it is a circular dependency.
> 
> There have been previous mailing list suggestions to move
> CompilerIntrinsicsLib to MdePkg (possibly combining with other arch
> intrinsics). I am not sure the end status of those conversations. By
> moving these two libraries to MdePkg package, we accomplish a few
> things:
> 
>    - Removing the circular dependency from MdeModulePkg and ShellPkg
>      (EmbeddedPkg has other ArmPkg dependencies)
> 
>    - Aligning MdePkg as the base package where baseline build and spec
>      dependencies are found with other industry standard behavior
> 
>    - Detangling ArmPkg and making ARM/AARCH64 more of a first class
>      citizen in edk2 instead of bolted onto the side
> 
> There is no functional change here and the amount of work is light, but
> I think it moves edk2 in the direction it wants to go, so I'm happy to
> put up a PR for this, but I wanted to get feedback before I did so. This
> aligns with similar efforts, such as moving more ARM/AARCH64 chipset
> definitions to MdePkg from ArmPkg [1][2][3]. This also aligns to the
> overall goal of deleting ArmPkg:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4121

As you might expect, I'm a big fan of this.

Of course, there is still bikeshedding to be done.

For example, if we move ArmSoftFloatLib out of ArmPkg, Should it become 
SoftFloatLib? It's a pretty thin wrapper on the berkley softfloat library.

So yes, please, create the PR :)

Regards,

Leif

> Thanks,
> Oliver
> 
> [1] 
> https://github.com/tianocore/edk2/commit/f2b9d5417dccf763bcbb68cd0effed0e25890aab
> [2] 
> https://github.com/tianocore/edk2/commit/cf323e2839ce260fde43487baae205527dee1b2f
> [3] 
> https://github.com/tianocore/edk2/commit/c68fb69dfefa7a76ebad33674a49632c4f8c6926



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120222): https://edk2.groups.io/g/devel/message/120222
Mute This Topic: https://groups.io/mt/107675828/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-