From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 87CEDD8065A for ; Mon, 5 Aug 2024 10:13:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=0u2n/5pdn+Zs4pNy66QIkHtYHNm5dPK03gDf0k+TD3k=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1722852827; v=1; b=Y5cakrOtsskBl6EmwS5kzv5yvhI2wV6ANO00r21jSdR+ToHt0nJVrg/Ewj+7x66EKrVAyua7 dyDf+C5+XDBwPDEtkHHhdG2aHC0Sp/KpTFl760UOcNamRIhZz09c35NAvMN93HRlaCj8MHpMCEM VNVbA2KHnlsLoLyrdBcXxXvKAcQLgv3EYmu12w75ctSL/bvJoA2qO3hHL70wN7MIvPYDGGk415x VmBEs4wki0uU7DY0rcMuiyddRkkXAcbwxWkPCx2JcaJKZymO1bQ/nEs2aDmNr+phetnM0DYBOaM iHPu9/WDKtgfeTzj8ha/IFeDSv1yxgXKMd4UofwxhUghQ== X-Received: by 127.0.0.2 with SMTP id gzvrYY7687511xfO2w24wJBD; Mon, 05 Aug 2024 03:13:45 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.4788.1722852825243976779 for ; Mon, 05 Aug 2024 03:13:45 -0700 X-Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4752VWpA023712; Mon, 5 Aug 2024 10:13:33 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40sbgrumg6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Aug 2024 10:13:33 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 475ADWqj013834 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Aug 2024 10:13:32 GMT X-Received: from [10.111.137.42] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 5 Aug 2024 03:13:30 -0700 Message-ID: <09e1aacd-8848-46e6-9f09-c6947e35be79@quicinc.com> Date: Mon, 5 Aug 2024 11:13:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RFC] Move CompilerIntrinsicsLib and ArmSoftFloatLib to MdePkg To: Oliver Smith-Denny , "devel@edk2.groups.io" , Ard Biesheuvel , Sami Mujawar , Michael Kinney , Liming Gao , Zhiguang Liu References: From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: dko7fVALzQ801l3dnqayzkEGT_X5gK4g X-Proofpoint-GUID: dko7fVALzQ801l3dnqayzkEGT_X5gK4g X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 4752VWpA023712 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 05 Aug 2024 03:13:45 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eM8FulVMbEinTt90Gi9IWLwZx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Y5cakrOt; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) Hi Oliver, On 2024-08-01 23:39, Oliver Smith-Denny wrote: > CompilerIntrinsicsLib and ArmSoftFloatLib add ARM/AARCH64 compiler > intrinsics and floating point functions required by OpenSSL, > respectively. CompilerIntrinsicsLib is used almost in every DSC that > builds ARM/AARCH64 and ArmSoftFloatLib is used by every DSC that builds > logic from OpenSSL. Together these make almost every DSC have a > dependency on ArmPkg, which is odd and for a handful, MdeModulePkg, > EmbeddedPkg, and ShellPkg, namely, it is a circular dependency. >=20 > There have been previous mailing list suggestions to move > CompilerIntrinsicsLib to MdePkg (possibly combining with other arch > intrinsics). I am not sure the end status of those conversations. By > moving these two libraries to MdePkg package, we accomplish a few > things: >=20 > =C2=A0 - Removing the circular dependency from MdeModulePkg and ShellPkg > =C2=A0=C2=A0=C2=A0 (EmbeddedPkg has other ArmPkg dependencies) >=20 > =C2=A0 - Aligning MdePkg as the base package where baseline build and sp= ec > =C2=A0=C2=A0=C2=A0 dependencies are found with other industry standard b= ehavior >=20 > =C2=A0 - Detangling ArmPkg and making ARM/AARCH64 more of a first class > =C2=A0=C2=A0=C2=A0 citizen in edk2 instead of bolted onto the side >=20 > There is no functional change here and the amount of work is light, but > I think it moves edk2 in the direction it wants to go, so I'm happy to > put up a PR for this, but I wanted to get feedback before I did so. This > aligns with similar efforts, such as moving more ARM/AARCH64 chipset > definitions to MdePkg from ArmPkg [1][2][3]. This also aligns to the > overall goal of deleting ArmPkg: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4121 As you might expect, I'm a big fan of this. Of course, there is still bikeshedding to be done. For example, if we move ArmSoftFloatLib out of ArmPkg, Should it become=20 SoftFloatLib? It's a pretty thin wrapper on the berkley softfloat library. So yes, please, create the PR :) Regards, Leif > Thanks, > Oliver >=20 > [1]=20 > https://github.com/tianocore/edk2/commit/f2b9d5417dccf763bcbb68cd0effed0e= 25890aab > [2]=20 > https://github.com/tianocore/edk2/commit/cf323e2839ce260fde43487baae20552= 7dee1b2f > [3]=20 > https://github.com/tianocore/edk2/commit/c68fb69dfefa7a76ebad33674a49632c= 4f8c6926 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120222): https://edk2.groups.io/g/devel/message/120222 Mute This Topic: https://groups.io/mt/107675828/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-